ebaaa4834f
Make our compiler-hardening checks robust against MinGW
...
First, specify -Werror when we are testing each option; if it causes
a warning to appear, we shouldn't be adding it.
Second, do not attempt to add these options until after we have
found the libraries we want. Previously, I would hit a bug where
the linker hardening options worked fine when we weren't linking
anything, but failed completely once we added openssl or libevent.
2012-06-11 11:21:04 -04:00
e6dbe693b7
Make the option-checker code work with osx clang
...
This is a matter of making gcc and friends squirm more loudly when
they get an option they don't like (-pedantic) and making clang shut
up with it gets an option it tolerates but doesnt know
(-Qunknown-argument).
Is there no better way?
2012-05-11 15:52:36 -04:00
e36cd01633
Try to manually test for whether the compiler hardening flags work
...
Also, make the check for whether they're on by default work; there's
no need to mess around with this "$enableval" silliness.
2012-05-11 15:08:16 -04:00
62f3121a3d
fix for bug #5210 : enable GCC and LD hardening by default
2012-03-15 10:17:30 +00:00
4ade55ecb9
merge in the changes files so far
2012-03-14 23:54:26 -04:00
12594f27db
Stop discarding command-line arguments when TestingTorNetwork is set
...
Discovered by Kevin Bauer. Fixes bug 5373; bugfix on 0.2.3.9-alpha,
where task 4552 added support for two layers of torrc files.
2012-03-14 02:40:04 -04:00
279f03e76f
retroactively say which ticket the defaults torrc patch was
2012-03-14 02:31:18 -04:00
fecb341d6b
Fix spelling of Esteban Manchado Velázquez.
2012-03-12 13:12:13 -04:00
aae570b493
Close fds on pipe() error in tor_spawn_background().
2012-03-12 12:41:29 -04:00
9f88c1e14f
Merge remote-tracking branch 'origin/maint-0.2.2'
...
Conflicts:
src/or/circuitbuild.c
2012-03-09 14:30:12 -05:00
99bd5400e8
Never choose a bridge as an exit. Bug 5342.
2012-03-09 14:27:50 -05:00
978cfcfbbb
Merge remote-tracking branch 'origin/maint-0.2.2'
2012-03-09 14:25:18 -05:00
8abfcc0804
Revise "sufficient exit nodes" check to work with restrictive ExitNodes
...
If you set ExitNodes so that only 1 exit node is accepted, the
previous patch would have made you unable to build circuits.
2012-03-09 14:23:23 -05:00
d4526e1d4a
Merge remote-tracking branch 'origin/maint-0.2.2'
...
Conflicts:
src/or/routerlist.c
2012-03-09 13:57:32 -05:00
a574f7f3fe
Merge branch 'bug5343' into maint-0.2.2
2012-03-09 13:54:04 -05:00
c13dc5170f
Merge remote-tracking branch 'origin/maint-0.2.2'
2012-03-09 11:54:45 -05:00
31f253ae6a
Oops; credit bug5090 patch to flupzor. estebanm only found the bug.
2012-03-09 11:54:27 -05:00
be0535f00b
Correctly handle broken escape sequences in torrc values
...
Previously, malformatted torrc values could crash us.
Patch by Esteban Manchado. Fixes bug 5090; fix on 0.2.0.16-alpha.
2012-03-09 11:50:22 -05:00
0f7e96038d
changes file for extra-tests branch
2012-03-08 21:16:46 -05:00
c4bfc7ca0e
Disable some tor_sscanf tests that gcc says are illegal formats
2012-03-08 21:16:46 -05:00
97b15e6fb0
Fix new strcmp_opt/len tests on OSs where strcmp() can return values >1 or <-1
2012-03-08 21:16:46 -05:00
998891e734
Add unit tests for path_is_relative
2012-03-08 21:16:46 -05:00
dbd170f752
Some more corner cases for tor_sscanf
2012-03-08 21:16:46 -05:00
8e88377905
expand_filename tests for trailing slash in $HOME
2012-03-08 21:16:46 -05:00
043e154cdd
Add some tests for expand_filename
2012-03-08 21:16:45 -05:00
6beec6a373
Add two small tests for tor_sscanf
2012-03-08 21:16:45 -05:00
fa4ca5ddc1
Add test for broken escapes in parse_config_...
2012-03-08 21:16:45 -05:00
8bb68011f0
Add some unit tests for parse_iso_time
2012-03-08 21:16:45 -05:00
c097401879
Add tests for string_is_C_identifier
2012-03-08 21:16:45 -05:00
1f6e3ec500
Improve coverage in string-related unit tests
2012-03-08 21:16:45 -05:00
03258529d8
Improve coverage in time-related unit tests
2012-03-08 21:16:45 -05:00
a3679d30c0
Remove unreliable assertion
...
* This assertion fails when executing the whole suite, but not when executing
this test by itself
* Ideally I'd prefer starting with a guaranteed empty directory, but it's not
very important in this case as non-existence of other paths is being checked
explicitly
2012-03-08 20:49:26 -05:00
8d62e42fd3
Add extra tests for wrap_string
2012-03-08 20:49:26 -05:00
9ae7d511f4
Add extra tests for get_parent_directory
2012-03-08 20:49:26 -05:00
fa1d6f812c
Tweak test case text so it's clearer
2012-03-08 20:49:26 -05:00
4beebea698
Improve eat_whitespace* unit tests
2012-03-08 20:49:25 -05:00
3e4a977781
Put expected first in n_bits_set_u8 unit tests
2012-03-08 20:49:25 -05:00
afb89b83f2
Improve tor_split_lines unit tests
...
* Add some more test cases
* Switch to test_assert et al
2012-03-08 20:49:25 -05:00
699af29bae
Use test_streq in join_win_cmdline unit tests
2012-03-08 20:49:25 -05:00
7b8a7556a8
Use test_eq et al in spawn_background unit tests
2012-03-08 20:49:25 -05:00
6b3854f8a3
Use test_streq in format_helper_exit_status tests
2012-03-08 20:49:25 -05:00
22a915bcd2
Improve get_parent_directory unit tests
...
* Add more test cases to the get_parent_directory tests
* Switch the parameter order so that the expected value is the first one
2012-03-08 20:49:25 -05:00
275b81ec5d
Improve listdir unit tests
2012-03-08 20:49:24 -05:00
667f30e465
Improve a bit asprintf unit tests
2012-03-08 20:49:24 -05:00
781c6676ca
Rewrite the find_str_at_start_of_line unit tests
2012-03-08 20:49:24 -05:00
667f5ea409
Improve/extend strtok_r unit tests
...
* Add several failing tests (embedded in an "#if 0" block) for behaviour that
doesn't match strtok_r
* Add another, passing, more interesting test
* Use test_eq_ptr(NULL, ...) instead of test_assert(NULL == ...)
2012-03-08 20:49:24 -05:00
ee317256bb
Improve tor_sscanf tests
...
* Add many new test cases, tweak/improve existing ones, reorganize them a bit
* Switch the parameters in all test_eq calls so the expected value is the first
* Change all the "r = tor_sscanf(...);\ntest_eq(1, r)" to the more compact
"test_eq(1, tor_sscanf(...))". It may be a tiny bit harder to find the
tor_sscanf calls (it's the long lines anyway), but it saves a lot of lines,
which should help readability.
2012-03-08 20:49:24 -05:00
8a633a3ebd
Small fix in tor_sscanf documentation
2012-03-08 20:49:23 -05:00
4e44024ced
Improve test case for read_escaped_data unit test
2012-03-08 20:49:23 -05:00
3c5a3b33e8
Trivial readability changes in mmap unit tests
2012-03-08 20:49:23 -05:00
Nick Mathewson
Florent Daigniere
Roger Dingledine
George Kadianakis
Esteban Manchado Velázquez