torproject/tor
1
0
Fork 0
mirror of https://gitlab.torproject.org/tpo/core/tor.git synced 2024-12-06 19:41:15 +01:00
Code Issues Actions Packages Projects Releases Wiki Activity
26,865 Commits 53 Branches 631 Tags
dd5ca2505599dee6a589e228b69c4e8d4f29d7e6
Commit Graph
26865 Commits
This Branch
This Branch
All Branches
Author SHA1 Message Date
Nick Mathewson dd5ca25055 Merge branch 'maint-0.3.2' into release-0.3.2 2017-12-12 09:32:29 -05:00
Nick Mathewson cf5ab5934e Merge remote-tracking branch 'dgoulet/bug24595_032_02' into maint-0.3.2 2017-12-12 09:32:24 -05:00
George Kadianakis b6fd78ea30 hs-v3: Don't lookup an intro point while cleaning it up 
Commit e80893e51b made tor call
hs_service_intro_circ_has_closed() when we mark for close a circuit.

When we cleanup intro points, we iterate over the descriptor's map of intro
points and we can possibly mark for close a circuit. This was problematic
because we would MAP_DEL_CURRENT() the intro point then free it and finally
mark for close the circuit which would lookup the intro point that we just
free in the map we are iterating over.

This can't be done and leads to a use-after-free because the intro point will
be returned successfully due to the fact that we are still in the loop
iterating. In other words, MAP_DEL_CURRENT() followed by a digest256map_get()
of the same object should never be done in the same loop.

Fixes #24595

Signed-off-by: David Goulet <dgoulet@torproject.org>
 2017-12-12 09:21:25 -05:00
Nick Mathewson 706e6893d1 Merge branch 'maint-0.3.2' into release-0.3.2 2017-12-12 09:13:12 -05:00
Nick Mathewson 4c54021baf Merge branch 'maint-0.3.1' into maint-0.3.2 2017-12-12 09:13:12 -05:00
Nick Mathewson 31ce03a2b9 Merge branch 'maint-0.3.0' into maint-0.3.1 2017-12-12 09:13:12 -05:00
Nick Mathewson d3b7a2bd27 rename changes file 2017-12-12 09:13:05 -05:00
Nick Mathewson 58f974818c Merge branch 'maint-0.3.2' into release-0.3.2 2017-12-11 16:56:31 -05:00
Nick Mathewson 4593f5a6e1 Merge branch 'maint-0.3.1' into maint-0.3.2 2017-12-11 16:56:31 -05:00
Nick Mathewson cdee62da9e Merge branch 'maint-0.3.0' into maint-0.3.1 2017-12-11 16:56:31 -05:00
Nick Mathewson da38904efb Merge branch 'maint-0.2.9' into maint-0.3.0 2017-12-11 16:56:31 -05:00
Nick Mathewson eecfed0cd2 Merge branch 'maint-0.2.8' into maint-0.2.9 2017-12-11 16:56:31 -05:00
Nick Mathewson f7151387d9 Merge branch 'maint-0.2.5' into maint-0.2.8 2017-12-11 16:56:31 -05:00
Nick Mathewson 1deda2106b Merge branch 'bug24167_025' into maint-0.2.5 2017-12-11 16:56:28 -05:00
Nick Mathewson 43fb8fc5cb Merge branch 'maint-0.3.1' into maint-0.3.2 2017-12-11 16:54:14 -05:00
Nick Mathewson 2cfb7b0413 Merge branch 'maint-0.3.2' into release-0.3.2 2017-12-11 16:54:14 -05:00
Nick Mathewson 04524443d0 Merge branch 'maint-0.3.0' into maint-0.3.1 2017-12-11 16:54:14 -05:00
Nick Mathewson 2ea573ece8 Merge branch 'maint-0.2.9' into maint-0.3.0 2017-12-11 16:54:14 -05:00
Nick Mathewson eaaa1108a3 Merge branch 'maint-0.2.8' into maint-0.2.9 2017-12-11 16:54:14 -05:00
Nick Mathewson bc1ea4f470 Merge branch 'maint-0.2.5' into maint-0.2.8 2017-12-11 16:54:11 -05:00
Nick Mathewson f5d4bdf305 Merge remote-tracking branch 'public/ticket23856_025_01' into maint-0.2.5 2017-12-11 16:53:02 -05:00
Nick Mathewson e553bf3ce4 Merge branch 'maint-0.3.1' into maint-0.3.2 2017-12-11 16:51:58 -05:00
Nick Mathewson a14ff6b9c7 Merge branch 'maint-0.3.2' into release-0.3.2 2017-12-11 16:51:58 -05:00
Nick Mathewson 736e7299ce Merge branch 'maint-0.3.0' into maint-0.3.1 2017-12-11 16:51:58 -05:00
Nick Mathewson 7fcb222ab7 Merge branch 'maint-0.2.9' into maint-0.3.0 2017-12-11 16:51:58 -05:00
Nick Mathewson 7e486dd6f7 Merge remote-tracking branch 'public/bug23985_029' into maint-0.2.9 2017-12-11 16:51:54 -05:00
Nick Mathewson bfc9be4c77 Merge branch 'maint-0.3.1' into maint-0.3.2 2017-12-11 16:50:48 -05:00
Nick Mathewson d77e827693 Merge branch 'maint-0.3.2' into release-0.3.2 2017-12-11 16:50:48 -05:00
Nick Mathewson f7b41bcdf0 Merge branch 'bug24086_031' into maint-0.3.1 2017-12-11 16:49:01 -05:00
Nick Mathewson 828333e38c Merge remote-tracking branch 'public/bug24099_031' into maint-0.3.1 2017-12-11 16:48:44 -05:00
Nick Mathewson dc79d5299d Merge branch 'maint-0.3.1' into maint-0.3.2 2017-12-11 16:46:00 -05:00
Nick Mathewson ca554b22f8 Merge branch 'maint-0.3.2' into release-0.3.2 2017-12-11 16:46:00 -05:00
Nick Mathewson d2031f2c60 Merge remote-tracking branch 'public/bug23817_031' into maint-0.3.1 2017-12-11 16:45:54 -05:00
Nick Mathewson fdd13697d5 Merge branch 'maint-0.3.2' into release-0.3.2 2017-12-11 16:43:51 -05:00
Nick Mathewson acc462c965 Merge branch 'maint-0.3.1' into maint-0.3.2 2017-12-11 16:43:48 -05:00
Nick Mathewson ae608408e9 Merge remote-tracking branch 'asn/bug23862_031' into maint-0.3.1 2017-12-11 16:43:41 -05:00
Nick Mathewson 8e100d1a17 Merge branch 'maint-0.3.0' into maint-0.3.1 
"ours" merge to avoid taking the 030 version of 23862.
 2017-12-11 16:43:24 -05:00
Nick Mathewson c55a054236 Merge remote-tracking branch 'asn/bug23862_030' into maint-0.3.0 2017-12-11 16:41:28 -05:00
Nick Mathewson 418d8bbe92 Merge branch 'stack_fixes_032_v2' into maint-0.3.2 2017-12-11 16:25:04 -05:00
Nick Mathewson 35d56a127d Add a changelog for the STACK fixes 2017-12-11 16:23:11 -05:00
Nick Mathewson f539d89fd9 Move subtraction in rephist to try to avoid STACK warning 
(I do not know why this one is happening)
 2017-12-11 16:23:11 -05:00
Nick Mathewson 3da15bcbe8 Stop checking for sandbox:new_element() failures: it can't fail. 
(It can't fail because the tor_malloc*() family of functions can
never return NULL)

Found with STACK
 2017-12-11 16:06:25 -05:00
Nick Mathewson 472473ec5d transport_new() cannot fail; do not check for it to fail. 
(It can't fail because the tor_malloc*() family of functions can
never return NULL)

Found with STACK.
 2017-12-11 16:06:00 -05:00
Nick Mathewson 4fc402496e Merge branch 'maint-0.3.2' into release-0.3.2 2017-12-11 16:02:10 -05:00
David Goulet 057139d383 sched: Avoid integer overflow when computing tcp_space 
In KIST, we could have a small congestion window value than the unacked
packets leading to a integer overflow which leaves the tcp_space value to be
humongous.

This has no security implications but it results in KIST scheduler allowing to
send cells on a potentially saturated connection.

Found by #24423. Fixes #24590.

Signed-off-by: David Goulet <dgoulet@torproject.org>
 2017-12-11 15:45:19 -05:00
Nick Mathewson 68ec14dc18 Merge branch 'maint-0.3.2' into release-0.3.2 2017-12-11 09:45:17 -05:00
Nick Mathewson d68abbe358 Merge remote-tracking branch 'dgoulet/bug23603_032_02' into maint-0.3.2 2017-12-11 09:42:12 -05:00
Nick Mathewson cd084c2036 Merge branch 'maint-0.3.2' into release-0.3.2 2017-12-07 08:42:56 -05:00
Nick Mathewson 4b41ffa64d Merge branch 'arthuredelstein_18859+1_031' into maint-0.3.2 2017-12-07 08:42:49 -05:00
Nick Mathewson 13049a9866 Rewrite 18859 changes file from user POV. 2017-12-07 08:41:00 -05:00