d7afdb3b0f
Merge branch 'tor-github/pr/1195'
2019-08-06 14:51:47 +03:00
4ee65a6f87
Merge branch 'tor-github/pr/1193'
2019-08-06 07:42:20 -04:00
8248812188
Rename handle_relay_command to handle_relay_cell_command .
...
As per David's review.
2019-08-05 18:03:23 +03:00
1e970d17b8
Test that regular cells get ignored in padding circuits.
2019-08-05 18:03:23 +03:00
ce477da8a7
Ignore regular cells in padding circuits.
...
Padding circuits were regular cells that got closed before their padding
machine could finish. This means that they can still receive regular cells from
their past life, but they have no way or reason to answer them anymore. Hence
let's ignore them before they even get to the proper subsystems.
2019-08-05 18:03:23 +03:00
7a032c5e48
Split connection_edge_process_relay_cell() in two functions.
...
One function does the validation, the other does the handling.
2019-08-05 18:02:33 +03:00
54ad92a240
Merge branch 'maint-0.4.1'
2019-08-05 09:59:40 -04:00
74c0595965
Ignore regular cells in padding circuits.
...
Padding circuits were regular cells that got closed before their padding
machine could finish. This means that they can still receive regular cells from
their past life, but they have no way or reason to answer them anymore. Hence
let's ignore them before they even get to the proper subsystems.
2019-08-05 13:48:58 +03:00
1440c2cb34
Adjust test_practracker.sh to work on windows
...
The required change is to ignore trailing CRs when diffing files.
2019-08-01 15:43:54 -04:00
fa60fee8d5
practracker: Add unit tests to test script, and test script to makefile
...
This makes all of the practracker tests get run by make check, and
hence by our CI.
Closes ticket 31304.
2019-08-01 14:01:43 -04:00
5d98b54725
Port practracker unit tests to python 3
2019-08-01 14:00:48 -04:00
30da1b61c6
Distribute practracker unit and integration tests.
2019-08-01 13:59:26 -04:00
49c696fb46
Merge branch 'ticket31311_041' into ticket31304
2019-08-01 13:48:58 -04:00
3945282419
make dist: only include files from practracker dir intentionally.
...
Previously, we included temporary files and whatnot, which is not
good.
Fixes bug 31311; bugfix on 0.4.1.1-alpha.
2019-08-01 13:47:05 -04:00
223afc2d8f
practracker: add envvar TOR_PRACTRACKER_OPTIONS
...
We have Makefile.am use this to decide how to invoke practracker on
the Tor source.
2019-08-01 12:57:26 -04:00
e57209dc32
Regenerate the practracker exceptions.txt file
2019-08-01 10:25:42 -04:00
a4e4896e66
practracker: restore exceptions.txt header when running --regen
2019-08-01 10:25:20 -04:00
c4864de573
Merge branch 'tor-github/pr/1177'
2019-08-01 10:18:10 -04:00
19536fd18d
practracker: replaces "overstrict" with "overbroad"
...
I had the logic reversed here.
2019-08-01 09:35:33 -04:00
3221dc1b32
Lower check of TOR_DISABLE_PRACTRACKER
...
Since we sometimes call practracker directly, that's where we should
check the TOR_DISABLE_PRACTRACKER envvar.
2019-08-01 08:40:56 -04:00
8d3f3e5d30
Practracker: add an integration test.
...
This test runs practracker with a set of 0 thresholds, to make sure
that it enumerates all its values right. It tries running with an
empty exceptions file, and with an exceptions file that covers
_some_ of the data, and it makes sure that the outputs are as expected.
2019-07-30 12:14:46 -04:00
a79e2c2975
practracker: better warning/regen handling
...
Now that there is only one toplevel place where we print problems,
we can redirect just that one print to a file when we are
regenerating the exceptions.txt file. Previously we redirected
sys.stdout, which is naughty, and forced us to send warnings (and
warnings alone) to stderr.
2019-07-30 11:54:05 -04:00
3f303c102a
Practracker: new flags to control output.
...
These flags let you suppress the message about the number of
problems and warnings, and let you control the thresholds above
which something counts as a problem.
I need this for testing.
2019-07-30 11:49:50 -04:00
31a0b81854
practracker: Remove problemvault global.
2019-07-30 10:17:56 -04:00
65cb4fead5
practracker: Move the warning/error distinction to a higher level.
...
Previously warnings were generated by magic inside ProblemVault; now
they're printed on demand.
2019-07-30 10:17:47 -04:00
bcef6a5802
practracker: Refactor flow to use generators
...
Instead of having "consider" functions that have to call a global
ProblemVault, we can now generate all the metrics for the code
separately from the decision about what to do for them.
2019-07-30 09:24:41 -04:00
ec13a727b0
practracker: Rename "Problem" to "Item".
...
I'm about to refactor the code into a set of iterators that yield
*all* the metrics for the code, and then add a filter on top of that
to return the problems.
2019-07-30 09:03:58 -04:00
6dba86d7c9
Merge branch 'maint-0.4.1'
2019-07-29 12:02:54 -04:00
1d6054f750
Merge branch 'tor-github/pr/1179' into maint-0.4.1
2019-07-29 12:02:47 -04:00
142612bd16
Merge branch 'maint-0.4.1'
...
"ours" to avoid version bump.
2019-07-25 21:52:02 -04:00
d8264ab62b
bump to 0.4.1.4-rc-dev
2019-07-25 21:51:53 -04:00
eb021e8c6f
forward-port the changelog for 0.4.1.4-rc
2019-07-25 21:44:17 -04:00
2722296b95
Merge branch 'maint-0.4.1'
2019-07-25 20:11:47 -04:00
278e65887b
Fix more 32-bit errors with domain and tt_int_op
2019-07-25 20:11:33 -04:00
69921a6a8a
Merge branch 'maint-0.4.1'
2019-07-25 16:57:32 -04:00
6095bbf74e
test: Use a 64-bit comparison for logging domains.
2019-07-25 16:57:06 -04:00
57f955a38b
practracker: Make it happing for circuitpadding.c
...
Signed-off-by: David Goulet <dgoulet@torproject.org >
2019-07-25 10:28:38 -04:00
044bb019b6
Merge branch 'maint-0.4.1'
2019-07-25 10:27:41 -04:00
af26cd6101
Always check the retval of circpad_machine_current_state().
2019-07-25 10:24:23 -04:00
bd1ac408d8
Remove dead code from circpad_machine_remove_token().
2019-07-25 10:24:19 -04:00
cfb15d513d
Merge branch 'maint-0.4.1'
2019-07-25 09:03:01 -04:00
2a4b156978
Merge branch 'tor-github/pr/1171' into maint-0.4.1
2019-07-25 09:02:53 -04:00
7082cc1684
Merge branch 'maint-0.4.1'
...
"ours" to avoid version bump.
2019-07-25 09:01:20 -04:00
b2a6b52825
Bump version to 0.4.1.4-rc
2019-07-25 09:00:53 -04:00
167d873bde
Fix clang-detected errors related to log_domain_mask_t
2019-07-24 09:08:48 -04:00
2944b091fc
Merge branch 'maint-0.4.1'
2019-07-24 12:32:06 +03:00
bb33a2f290
Merge branch 'tor-github/pr/1181' into maint-0.4.1
2019-07-24 12:31:56 +03:00
91f04d006b
Merge branch 'tor-github/pr/1165'
2019-07-24 12:29:57 +03:00
ab1f82ea2a
Merge branch 'ticket24963_042_02'
2019-07-23 14:03:30 -04:00
df12ff3dea
Add a test for disallowing single-hop introductions.
...
Code from dgoulet.
2019-07-23 12:42:33 -04:00
George Kadianakis
David Goulet
Nick Mathewson