Commit Graph

2483 Commits

Author SHA1 Message Date
Roger Dingledine bee4292de4 and another one
svn:r2484
2004-10-14 02:49:48 +00:00
Roger Dingledine 46fccc2bc6 oh, and some more in common/
svn:r2483
2004-10-14 02:48:57 +00:00
Roger Dingledine a6a422144d more int to size_t conversions, fixing one or more amd64 bugs
plus a whitespace patch on config.c from vicman


svn:r2482
2004-10-14 02:47:09 +00:00
Nick Mathewson 32e37039dd Add missing line; add similar check
svn:r2481
2004-10-14 02:29:03 +00:00
Nick Mathewson b7e5ad714c Patch from "J Doe": Use SHGetSpecialFolderLocation instead of
SHGetSpecialFolderPath in order to find application data folder.

Apparently, until IE 4 (!?) came out, nobody realized that programmers
might like to get paths as strings.  Clearly, a fancy pseudo-OO list
of "identifiers" is a far more convenient way to deal with these
things.  And while we're being OO, why return object that you can free
with free()?  Instead, let's make the user get a handle to an abstract
allocation object, and ask it to free the fancy list, and then ask it
to release itself.  Won't that be fun and convenient?

Navigating ancient Win32 APIs is like bikini-waxing creatures from HP
Lovecraft: to do a good job you must understand what's going on... but
the understanding itself can blast your sanity.


svn:r2480
2004-10-14 02:04:43 +00:00
Nick Mathewson acdaf583f1 Remove need for dirservers file: now, we note trusted dirservers in configuration options, and only need to remember addr:port and key digest for each one.
svn:r2479
2004-10-14 01:44:32 +00:00
Roger Dingledine b9c2a71ca1 backport from pre3:
sometimes circuit_get_open_circ_or_launch() can return 0 but not
return a circuit, e.g. because too many circuits have failed recently
so the new one didn't launch. we need to tolerate that.


svn:r2478
2004-10-13 22:02:31 +00:00
Roger Dingledine 7da0c2d705 backport from pre3:
fix a string format vulnerability
(probably not exploitable)


svn:r2477
2004-10-13 21:58:24 +00:00
Roger Dingledine 4c44f4a3cb backport from pre3:
fix a stale pointer assert bug when a stream detaches and reattaches


svn:r2476
2004-10-13 21:56:35 +00:00
Roger Dingledine 160ec8defb backport patch from pre3:
fix a bug in parsing opt keywords with objects


svn:r2475
2004-10-13 21:44:08 +00:00
Roger Dingledine 0574aad336 backport patch from pre1:
fix a rare seg fault for people running hidden services on
intermittent connections


svn:r2474
2004-10-13 21:34:23 +00:00
Roger Dingledine 0a68d93639 backport patch from pre1:
fix a bug in OutboundBindAddress


svn:r2473
2004-10-13 21:24:54 +00:00
Roger Dingledine 05bab55b97 backport patch from pre1:
Fix a rare assert trigger, where routerinfos for entries in our cpath
would expire while we're building the path.


svn:r2472
2004-10-13 21:15:02 +00:00
Roger Dingledine af112c7a1c bump stable version to 0.0.8.1
svn:r2471
2004-10-13 21:12:14 +00:00
Nick Mathewson 3d71bec1dc Fix comment in dirserv.c
svn:r2470
2004-10-13 20:28:46 +00:00
Roger Dingledine 0df7bf0f06 stop trying to print a NULL
plus make router_nickname_is_approved() more obviously unused


svn:r2469
2004-10-13 20:17:45 +00:00
Nick Mathewson 903fb2c35e Unify tests for "did I originate this nonopen OR connection?"
svn:r2468
2004-10-13 20:05:57 +00:00
Nick Mathewson d037d4b05e Add default trusted-dir-server entries only when no dirserver lines are given in the config file
svn:r2467
2004-10-13 19:56:42 +00:00
Nick Mathewson ef2fd7f6ad fix typo
svn:r2466
2004-10-13 19:55:40 +00:00
Nick Mathewson 241950b4c5 fix warning about always-false comparison; detect too-large realport better
svn:r2465
2004-10-13 19:53:34 +00:00
Nick Mathewson 3cad0ad4f6 answer question about rep_hist_note_connect_failed
svn:r2464
2004-10-13 19:42:36 +00:00
Nick Mathewson 0ed257433d hex-to-hex compare makes more sense than hex-to-bin.
svn:r2463
2004-10-13 19:17:27 +00:00
Nick Mathewson 9d7c55c5ff Make directories get generated properly again; debug key lookup. Also, it is hard to find entries in a table when you never put them there.
svn:r2462
2004-10-13 18:28:39 +00:00
Roger Dingledine 38319c49be a few more ints to size_ts
svn:r2461
2004-10-13 05:54:58 +00:00
Roger Dingledine 10741e1865 fix const char * vs char * issue
plus unshadow some variables


svn:r2460
2004-10-13 04:44:37 +00:00
Nick Mathewson c5649776ad Omit any exit rules that follow a catch-all rule when writing a router descriptor.
svn:r2459
2004-10-13 01:25:42 +00:00
Nick Mathewson e4cc4e87d2 Check fingerprint list before generating running-routers lists; also add as-yet-uncalled function to update an OR connection nickname on the fly
svn:r2458
2004-10-13 01:13:37 +00:00
Roger Dingledine 8580e2555d ok, vim isn't the greatest editor in the world
svn:r2457
2004-10-12 20:28:53 +00:00
Roger Dingledine 63ef1b7926 parse HttpProxy address in config
fix a potential confusion in fetch_from_buf_http()
make all our int config options non-negative
better bounds checking on options that are ports


svn:r2456
2004-10-12 20:22:09 +00:00
Roger Dingledine 0ef947f5bf start the great migration from int to size_t
and clean some deadweight from util.h


svn:r2455
2004-10-12 20:20:19 +00:00
Nick Mathewson 111653ee8e Appease overzealous gcc
svn:r2454
2004-10-12 20:17:45 +00:00
Nick Mathewson 42ce5238e6 Use tor_parse_long in more places
svn:r2453
2004-10-12 19:33:03 +00:00
Nick Mathewson b7e68c8a53 Make a bounds-checking replacement for strtol with slightly easier error-checking in the common case
svn:r2452
2004-10-12 19:32:41 +00:00
Roger Dingledine acf6bf75e4 fix signed/unsigned comparison, plus typo
svn:r2451
2004-10-12 19:09:40 +00:00
Nick Mathewson e4182e7b3b Better bounds checking on parsed ints
svn:r2450
2004-10-12 19:01:53 +00:00
Nick Mathewson 50075c6c52 Add default directory servers
svn:r2449
2004-10-12 19:01:28 +00:00
Nick Mathewson 8c9cc221d6 Backport fix for remote-crash bug
svn:r2448
2004-10-12 18:39:32 +00:00
Nick Mathewson 7607423aaa Add fix for remote-crash bug.
svn:r2447
2004-10-12 18:38:36 +00:00
Roger Dingledine 3b658d8af7 fix a signed/unsigned comparison
svn:r2446
2004-10-12 18:32:34 +00:00
Nick Mathewson bcb53b771a Oops, missed one
svn:r2445
2004-10-12 16:04:25 +00:00
Nick Mathewson 7861df1b8b Note byte-order on result for parse_addr_port()
svn:r2444
2004-10-12 16:02:15 +00:00
Nick Mathewson 79dd0a62b9 Add an implementation of trusted_dir_server logic to switch towards simply remembering an addr/port/keyid for each trusted dir server
svn:r2443
2004-10-12 15:55:20 +00:00
Nick Mathewson f939baaf78 Add long-term format for dir-signing-key fields (commented out)
svn:r2442
2004-10-12 15:52:57 +00:00
Nick Mathewson 48ea08e737 Use parse_addr_port() function instead of ad-hoc variants
svn:r2441
2004-10-12 15:52:09 +00:00
Nick Mathewson 54415aae93 Add functions to parse addr[:port] consistently
svn:r2440
2004-10-12 15:48:30 +00:00
Roger Dingledine 70759d8529 bugfix on my friday commit: make hidden services work again in cvs
svn:r2439
2004-10-12 06:03:10 +00:00
Roger Dingledine 3082705a4f fix paul gardner's assert bug.
sometimes circuit_get_open_circ_or_launch() can return 0 but not
return a circuit, e.g. because too many circuits have failed recently
so the new one didn't launch. we need to tolerate that.


svn:r2438
2004-10-11 22:19:12 +00:00
Roger Dingledine 519317f4a2 Fix a potential buffer overflow found by Ilja van Sprundel.
We don't think this is exploitable, but best to fix it anyway.


svn:r2437
2004-10-11 21:55:19 +00:00
Roger Dingledine 9c2442f4b6 fix the stale pointer assert bug reported by joe magic
svn:r2436
2004-10-11 01:17:42 +00:00
Roger Dingledine 567f512167 when a begin cell has an invalid port, give us a better hint of
what went wrong


svn:r2435
2004-10-10 01:47:24 +00:00