bd61a4e848
Add a simple test for checkSpace.pl
...
This script is not expected to work on windows due to line-ending
issues, so I'm not making it get run on an automated basis. We
should use it when editing checkSpace.pl.
Closes ticket 32613.
2019-12-03 12:56:46 +10:00
2aaa7ae6e2
checkSpace.pl: make output more uniform.
...
There were lots of slight differences in indentation and formatting
among the in-file error messages.
2019-11-26 12:58:25 -05:00
fadd292bf0
practracker/includes.py: Don't read editor temp files
...
(Or any files that start with "." or "#".)
Obviously correct changes to already-reviewed code.
2019-11-26 17:52:18 +10:00
3669a2f827
Merge remote-tracking branch 'tor-github/pr/1564'
2019-11-26 11:30:49 +10:00
c7baacf4c0
Makefile: Fix more targets for out-of-tree builds
...
Support callgraph and rectify-includes in out-of-tree builds.
Part of 32522.
2019-11-26 11:04:02 +10:00
5ec4fb7558
crypt_ops: Fix some weird macro spacing
2019-11-26 11:03:22 +10:00
e66fde45f1
Code Style: Remove double newlines in win32/orconfig.h
...
There's no reason for them to be in there.
Part of 32522.
2019-11-26 11:02:58 +10:00
0ce11433c0
check-spaces: Fix an outdated comment
2019-11-26 11:02:28 +10:00
d7fdab49f7
test/controller: Stop including a ".c" source file
...
Part of 32522.
2019-11-26 11:02:05 +10:00
ab70c315bd
practracker: Fix a typo in a logging function call
...
Obviously correct changes to already-reviewed code.
2019-11-26 11:01:34 +10:00
2a71a58d4f
test: Fix a python double-space
2019-11-26 11:00:39 +10:00
031f204a10
configure: reject Python 2.
...
Python 2 will be end-of-life as of 1 Jan 2020, so we can finally
stop supporting it. As a first step, we should make our configure
script stop accepting python 2 as something acceptable to run our
tests with.
Closes ticket 32608.
2019-11-25 13:01:04 -05:00
31f8b4fa65
Merge branch 'stream-socks-auth' into bug19859_merged
2019-11-25 07:58:02 -05:00
68b6d85248
Merge branch 'maint-0.4.2'
...
Merge tor_free() notes with whitespace fixes.
2019-11-25 12:52:10 +10:00
eb81704081
CodingStandards: Use consistent spacing
...
* 2 newlines before ====== headers
* 1 newline before ------ headers
2019-11-25 12:50:15 +10:00
03867b3dd7
Merge branch 'maint-0.4.2'
2019-11-25 12:37:26 +10:00
3d6545250e
Merge branch 'maint-0.4.1' into maint-0.4.2
2019-11-25 12:37:15 +10:00
26071aa3be
Merge branch 'maint-0.4.0' into maint-0.4.1
2019-11-25 12:37:07 +10:00
055f5d4d1b
Merge branch 'maint-0.3.5' into maint-0.4.0
2019-11-25 12:36:59 +10:00
c17ab20ac0
Merge remote-tracking branch 'tor-github/pr/1441' into maint-0.4.0
2019-11-25 12:36:41 +10:00
ed6f2f61a2
Merge remote-tracking branch 'tor-github/pr/1396' into maint-0.4.0
2019-11-25 12:35:58 +10:00
501b5174d8
Merge remote-tracking branch 'tor-github/pr/1464' into maint-0.3.5
2019-11-25 12:35:11 +10:00
400cee261e
Merge remote-tracking branch 'tor-github/pr/1422' into maint-0.3.5
2019-11-25 12:34:29 +10:00
54c01119ed
Merge remote-tracking branch 'tor-github/pr/1405' into maint-0.3.5
2019-11-25 12:33:55 +10:00
83424cb62f
Merge remote-tracking branch 'tor-github/pr/1395' into maint-0.3.5
2019-11-25 12:33:14 +10:00
f9812ee5f7
Merge remote-tracking branch 'tor-github/pr/1394' into maint-0.3.5
2019-11-25 12:29:43 +10:00
e6ceded7d8
Merge remote-tracking branch 'tor-github/pr/1557'
2019-11-25 12:24:22 +10:00
969ee5d77f
CodingStandards: Use the correct changes file format
...
And remove a duplicate description of the format.
Obviously correct changes to documentation.
2019-11-25 11:44:22 +10:00
d9d75d4ae1
rename_c_identifier: don't crash when doing only one replacement.
2019-11-23 15:30:18 -05:00
ff7d0ebcfe
Fix a low-impact memory leak in options_act_reversible()
...
Found by Coverity as CID 1455953
Fixes bug 32575; bug not in any released Tor.
2019-11-22 09:04:36 -05:00
cf22841e3b
ht.h: improve documentation for HT_NEXT_RMV.
2019-11-21 11:56:42 -05:00
da15448eb8
Merge branch 'ticket32209'
2019-11-21 08:26:20 -05:00
55fac8dafc
config.md: suggestions from teor
2019-11-21 08:26:12 -05:00
d8ff7d0236
Merge branch 'reversible_3'
2019-11-21 07:49:18 -05:00
f23d4df091
Merge branch 'tor-github/pr/1555'
2019-11-21 13:03:44 +02:00
cb11276068
hs-v3: Add changes file for ticket #30382
...
Signed-off-by: David Goulet <dgoulet@torproject.org >
2019-11-21 13:02:29 +02:00
709d7fba11
hs-v3: Return bad address SOCKS5 extended error
...
If ExtendedErrors is set for the SocksPort, an invalid .onion address now
returns the 0xF6 error code per prop304.
Closes #30022
Signed-off-by: David Goulet <dgoulet@torproject.org >
2019-11-21 13:02:29 +02:00
fe68d83b24
Merge branch 'bug32555'
2019-11-20 13:31:32 -05:00
b33f3c960d
options_act_reversible: add more comments to explain ordering
2019-11-20 09:49:25 -05:00
a3d06179ce
Typo/grammar fixes.
2019-11-20 09:28:12 -05:00
acb97cfa68
log config: Set safelogging_changed even if we aren't running Tor.
2019-11-20 09:26:47 -05:00
89c355b386
Some tests for log changes, commit, and rollback
2019-11-20 09:26:47 -05:00
a30d143228
Make KeyDirectory's GroupReadable behave the same as CacheDirectory's.
...
In #26913 we solved a bug where CacheDirectoryGroupReadable would
override DataDirectoryGroupReadable when the two directories are the
same. We never did the same for KeyDirectory, though, because
that's a rare setting.
Now that I'm testing this code, though, fixing this issue seems
fine. Fixes bug #27992 ; bugfix on 0.3.3.1-alpha.
2019-11-20 09:26:47 -05:00
3094651fa3
New unit tests for options_create_directories().
2019-11-20 09:26:47 -05:00
9951afe177
parseconf test: ControlSocketsGroupWriteable without ControlSocket.
2019-11-20 09:26:47 -05:00
cd8c96ce02
Typo fix in warning message about ControlSocket
2019-11-20 09:26:47 -05:00
cf7580ab06
Free options objects for which validation fails.
...
Also free options objects when we discard them due to
TestingTorOptions.
Fixes bug 32555; bug not in any released Tor.
2019-11-20 09:14:08 -05:00
929b46f44a
Split listener configuration out of options_act_reversible()
2019-11-19 16:05:07 -05:00
5060007f4b
Split log configuration out of options_act_reversible().
2019-11-19 16:03:32 -05:00
20c24e72d9
options_act_reversible(): Extract more startup-only pieces.
...
These have to happen after opening listeners and before opening logs :/
2019-11-19 16:03:10 -05:00
Nick Mathewson
teor
George Kadianakis
David Goulet