8577243cd2
hs: Remove last artefact of HSv2 in the code
...
Closes #40266
Signed-off-by: David Goulet <dgoulet@torproject.org >
2021-02-19 13:20:49 -05:00
9782cd2c9b
hs: Remove v2 code from HS circuitmap
...
Related to #40266
Signed-off-by: David Goulet <dgoulet@torproject.org >
2021-02-19 13:20:49 -05:00
897ec8a34c
hs: Remove v2 stats
...
We still keep v2 rendezvous stats since we will allow them until the network
has entirely phased out.
Related to #40266
Signed-off-by: David Goulet <dgoulet@torproject.org >
2021-02-19 13:20:49 -05:00
9f2e74cac7
test: Change chutney test to use HSv3 only
...
Related to #40266
Signed-off-by: David Goulet <dgoulet@torproject.org >
2021-02-19 13:20:49 -05:00
330aec798b
man: Cleanup of v2 options and config
...
Signed-off-by: David Goulet <dgoulet@torproject.org >
2021-02-19 13:20:49 -05:00
90c1a1f8b1
or: Cleanup or.h header of HSv2 code
...
Signed-off-by: David Goulet <dgoulet@torproject.org >
2021-02-19 13:20:49 -05:00
ca04e9b8ed
hs: Remove introduction point v2 support
...
Related to #40266
Signed-off-by: David Goulet <dgoulet@torproject.org >
2021-02-19 13:20:49 -05:00
2c865542b6
hs-v2: Removal of service and relay support
...
This is unfortunately massive but both functionalities were extremely
intertwined and it would have required us to actually change the HSv2 code in
order to be able to split this into multiple commits.
After this commit, there are still artefacts of v2 in the code but there is no
more support for service, intro point and HSDir.
The v2 support for rendezvous circuit is still available since that code is
the same for the v3 and we will leave it in so if a client is able to
rendezvous on v2 then it can still transfer traffic. Once the entire network
has moved away from v2, we can remove v2 rendezvous point support.
Related to #40266
Signed-off-by: David Goulet <dgoulet@torproject.org >
2021-02-19 13:20:48 -05:00
a34885bc80
hs: Rename service config port object
...
Remove it from rendservice.c and move everything related to hs_common.{c|h}.
Related to #40266
Signed-off-by: David Goulet <dgoulet@torproject.org >
2021-02-19 13:19:08 -05:00
2444629c86
hs-v2: Remove client support
...
Related to #40266
Signed-off-by: David Goulet <dgoulet@torproject.org >
2021-02-19 13:19:08 -05:00
67938e0198
Merge branch 'maint-0.4.5'
2021-02-19 13:26:52 +02:00
03c686563b
Merge remote-tracking branch 'tor-gitlab/mr/308' into maint-0.4.5
2021-02-19 13:26:33 +02:00
cf1f03fe1d
Merge remote-tracking branch 'tor-gitlab/mr/308'
2021-02-19 13:25:47 +02:00
e8cce1058c
Merge remote-tracking branch 'tor-gitlab/mr/305'
2021-02-19 13:24:34 +02:00
b2f025cb56
Merge branch 'bug40168+34088-035-v3' into bug40168+34088-035-v3-master
2021-02-18 18:17:18 +00:00
917f8beb54
Add CBT unit test for Xm and alpha estimation.
2021-02-18 11:21:25 -06:00
a0690f079d
Update documentation for the number of modes for Xm estimator.
2021-02-18 11:21:25 -06:00
525195a715
Bug 34088: Changes file
2021-02-18 11:21:25 -06:00
d16b3d12a1
Bug 34088: Remove max timeout calculation and warning.
...
With the maximum likelihood estimator for alpha from #40168 , we no longer need
max_time to calculate alpha.
2021-02-18 11:21:25 -06:00
1fadb1bdf1
Bug 40168 changes file
2021-02-18 11:21:25 -06:00
ed9d60cb92
Fix Xm mode calculation to properly average N=10 modes.
...
This is still fast enough. ~100usec on my laptop with 1000 build times.
2021-02-18 11:21:25 -06:00
406400a74d
Lower circuit build time bin width to 10ms.
...
50ms is not enough resolution. CBT can be as low as 80ms in datacenter
clients close to their relays.
2021-02-18 11:21:25 -06:00
86acd4d940
Log circuit timeout in milliseconds
2021-02-18 11:21:25 -06:00
c90b0cb6fb
Raise the circuit close time quantile to 99.
...
This should allow us to more accurately estimate pareto parameters
without relying on "right-censorship" of circuit build timeout values.
2021-02-18 11:21:25 -06:00
761dd9f2ab
Lower min circ timeout from 1.5s to bin width (10ms)
2021-02-18 11:21:25 -06:00
37b2159150
Completely ignore abandoned circs from circ timeout calc
...
This prevents the timeout curve from getting spread out as much, resulting in
more accurate timeout values for quantiles from 60-80.
2021-02-18 11:21:25 -06:00
2709828494
Merge branch 'tor-gitlab/mr/311'
2021-02-17 13:22:36 -05:00
aebd0a4080
Make our configure.ac script use the portable = comparison
...
Back in 0.4.5.1-alpha we added an `==` comparison, which isn't
portable.
Fixes bug #40298 ; bugfix on 0.4.5.1-alpha.
2021-02-17 12:36:23 -05:00
9f61d9238c
metrics: Handle the connection finished flushing event
...
Turns out, we forgot to add the METRICS connection type fo the finished
flushing handler.
Fixes #40295
Signed-off-by: David Goulet <dgoulet@torproject.org >
2021-02-17 09:54:05 -05:00
1b74c49048
copy changelog entries forward
2021-02-15 13:09:30 -05:00
67fdb1cd55
Merge branch 'maint-0.4.5'
...
"ours" to avoid version bump.
2021-02-15 13:00:20 -05:00
336c45f1a5
Bump to 0.4.5.6-dev
2021-02-15 13:00:14 -05:00
2ae3148304
Merge branch 'maint-0.4.5'
...
"ours" to avoid version bump.
2021-02-15 09:55:17 -05:00
18db584caf
Bump to 0.4.5.6.
2021-02-15 09:55:09 -05:00
7f32ae0eb5
Remove Proposal.md.
...
I don't think the Proposal.md fits well with the kind of tickets we see.
Let's start with Features and Bug and expand upon it as we go.
2021-02-12 20:39:48 +00:00
22df6a3127
Use titlecase for template filenames.
2021-02-12 20:39:28 +00:00
003e237dfc
Elaborate a few of the items from Gaba's initial templates.
2021-02-12 20:38:21 +00:00
cdc6638002
Remove documentation issue template.
...
I think the issues we get in here will be covered by either the bug or
feature document.
2021-02-12 20:36:17 +00:00
e74fc69448
Remove changes files from master that will appear in 0.4.5.6
2021-02-12 13:43:38 -05:00
3b0e0a87e7
Adds issue creation templates for bugs, features, proposals and documentation.
2021-02-12 18:36:42 +00:00
71e9c56578
Merge branch 'maint-0.4.5'
2021-02-12 13:13:57 -05:00
5887c1f1f3
Merge branch 'tor-gitlab/mr/304' into maint-0.4.5
2021-02-12 13:13:50 -05:00
d47e937a50
test: Fix duplicate ORPort test
...
The comment of that specific unit test wanted 4 ORPorts but for some reasons
we tested for 3 which before the previous commit related to #40289 , test would
pass but it was in fact wrong.
Now the code is correct and 4 was in fact correct expected number of ports.
Related to #40289
Signed-off-by: David Goulet <dgoulet@torproject.org >
2021-02-12 13:13:43 -05:00
dfcb050bbf
config: Do not compare for duplicate ORPorts with different addresses
...
We were just looking at the family which is not correct because it is possible
to have two explicit ORPort for the same family but different addresses. One
example is:
ORPort 127.0.0.1:9001 NoAdvertise
ORPort 1.2.3.4:9001 NoListen
Thus, this patch now ignores ports that have different addresses iff they are
both explicits. That is, if we have this example, also two different
addresses:
ORPort 9001
ORPort 127.0.0.1:9001 NoAdvertise
The first one is implicit and second one is explicit and thus we have to
consider them for removal which in this case would remove the "ORPort 9001" in
favor of the second port.
Fixes #40289
Signe-off-by: David Goulet <dgoulet@torproject.org >
2021-02-12 13:13:43 -05:00
c1b5e7fa1b
Merge branch 'maint-0.4.5'
2021-02-12 12:57:18 -05:00
bdca475518
Merge branch 'tor-gitlab/mr/302' into maint-0.4.5
2021-02-12 12:56:15 -05:00
73bedcaf4d
Merge branch 'tor-gitlab/mr/303' into maint-0.4.5
2021-02-12 12:54:52 -05:00
e6caf7d8c7
Merge branch 'maint-0.4.5'
2021-02-12 15:23:34 +00:00
d24a6b2f75
Merge remote-tracking branch 'tor-gitlab/mr/293' into maint-0.4.5
2021-02-12 15:23:02 +00:00
9b6b1aedcd
Merge branch 'maint-0.4.5'
2021-02-12 13:54:18 +02:00
David Goulet
George Kadianakis
Mike Perry
Nick Mathewson
Alexander Færøy
Gaba