e95b13f8ce
Merge remote-tracking branch 'ageis/control-getinfo-uptime'
2018-09-06 09:30:55 -04:00
bcfab63ca5
Merge remote-tracking branch 'teor/ticket27467'
2018-09-06 09:24:47 -04:00
d0965561a5
Remove GetAdaptersAddresses_fn_t
...
The code that used it was removed as part of the 26481 refactor.
Closes ticket 27467.
2018-09-06 12:54:03 +10:00
b8a2bdbdc8
Backport to older NSS, which does not have SEC_DerSignDataWithAlgorithmID
2018-09-05 16:49:15 -04:00
5656144290
Fix checkspaces
2018-09-05 16:48:53 -04:00
710aa122e4
Suppress strict-prototypes warnings in one more batch of NSS headers
2018-09-05 16:36:18 -04:00
8cd091a8d3
Add a last-ditch memwipe() implementation for nss+old glibc
...
On new glibc versions, there's an explicit_bzero(). With openssl,
there's openssl_memwipe().
When no other approach works, use memwipe() and a memory barrier.
2018-09-05 16:34:01 -04:00
824160fd82
Fix a type, and hopefully the win64 builds.
2018-09-05 09:36:15 -04:00
dc7c979453
Add note about use of tor_memcmp()
2018-09-05 09:11:53 -04:00
79a7fbb79b
Fix a reverse-inull warning from coverity in new code.
2018-09-05 08:34:14 -04:00
3b61bdb5ae
Try to fix new coverity warnings in unit tests.
2018-09-05 08:30:35 -04:00
03efb67b42
Debug one last reference-counting issue that only appeared on openssl master
2018-09-04 20:46:46 -04:00
eeba944ee0
Fix an easy refcounting bug in a unit test
2018-09-04 20:25:25 -04:00
0db5c54957
Merge branch 'nss_squashed' into nss_merge
2018-09-04 20:21:07 -04:00
d644c93ae9
Resolve openssl-only memory leaks
2018-09-04 19:45:28 -04:00
c50537fd94
Fix a pair of remaining leaks in tortls_nss.c
...
Fun fact: PR_Close leaks memory if its socket is not valid.
2018-09-04 19:45:21 -04:00
274efb1263
Use FREE_AND_NULL for impl types
2018-09-04 14:52:35 -04:00
ad94d43fc5
Port test_tortls_verify to not depend on openssl internals
2018-09-04 14:52:35 -04:00
59c1b34b72
Remove tor_tls_check_lifetime as unused.
...
Everything that might have used it, uses tor_tls_cert_is_valid() instead.
2018-09-04 14:52:35 -04:00
3cdf0497f9
Add unit test for bridge-style TLS initialization.
2018-09-04 14:52:35 -04:00
7acb8c8d18
Document winsock includes better
2018-09-04 14:52:35 -04:00
70c27b7e39
Fix documentation of initialized fields in crypto_init.c
2018-09-04 14:52:35 -04:00
edbb5ef5b2
Make some additional RSA functions const
2018-09-04 14:52:35 -04:00
600e046ed3
Rename crypto_pk_check_key(), use it more reasonably, add tests
...
This function was a wrapper around RSA_check_key() in openssl, which
checks for invalid RSA private keys (like those where p or q are
composite, or where d is not the inverse of e, or where n != p*q).
We don't need a function like this in NSS, since unlike OpenSSL, NSS
won't let you import a bogus private key.
I've renamed the function and changed its return type to make it
more reasonable, and added a unit test for trying to read a key
where n != p*q.
2018-09-04 14:52:35 -04:00
3b5d6ef15b
Unify functions for reading/writing PEM keys, to avoid duplication.
2018-09-04 14:52:35 -04:00
b892133fb9
Do not leave a certificate allocated after testing dirvote_add()
2018-09-04 14:52:35 -04:00
f46a7eafb8
Do not leak a reference to "slot" when decoding private key.
2018-09-04 14:52:35 -04:00
36f3bdac03
Update prefork and postfork NSS code for unit tests.
2018-09-04 14:52:35 -04:00
52ac539b99
Test a few more tortls.c functions
2018-09-04 14:52:35 -04:00
7163389b55
Several unit tests to improve test coverage of x509*.c
2018-09-04 14:52:35 -04:00
02086a216f
Remove tor_x509_get_cert_impl as unneeded.
2018-09-04 14:52:35 -04:00
b5fddbd241
Avoid double-close on TCP sockets under NSS.
2018-09-04 14:52:35 -04:00
52d5f4da12
Avoid spurious error logs when using NSS
...
The tls_log_errors() function now behaves differently for NSS than
it did for OpenSSL, so we need to tweak it a bit.
2018-09-04 14:52:35 -04:00
dd04fc35c6
Remove tor_tls_shutdown()
...
This function was supposed to implement a half-duplex mode for our
TLS connections. However, nothing in Tor actually uses it (besides
some unit tests), and the implementation looks really questionable
to me. It's probably best to remove it. We can add a tested one
later if we need one in the future.
2018-09-04 14:52:35 -04:00
5205c7fd90
Initial NSS support for TLS.
...
This is enough to get a chutney network to bootstrap, though a bunch
of work remains.
2018-09-04 14:52:35 -04:00
fd994f55c4
Merge remote-tracking branch 'rl1987/doc26908'
2018-09-04 11:08:49 -04:00
1e71e2c104
c99 style in loop
2018-09-04 11:04:55 -04:00
3507fead10
Merge branch 'tor_api_owning_control'
2018-09-04 11:04:21 -04:00
94b04d6c64
Merge branch 'bug24104_029_squashed'
2018-09-04 10:44:36 -04:00
ce4f73f8a3
Update sample torrc files to warn about not using BridgeRelay and MyFamily together
2018-09-02 21:11:52 +03:00
81f4223329
Test for descriptor does not change when hibernating
2018-09-01 18:47:20 -04:00
d4e51a2eeb
Add missing router_tests to test.h
2018-09-01 18:47:20 -04:00
e033d98f79
Check descriptor bandwidth changed if not hibernating
...
There should be a separate check to update descriptor when start
or end hibernating.
2018-09-01 18:47:20 -04:00
1066fdd8d1
Add test for check_descriptor_bandwidth_changed
2018-09-01 18:47:20 -04:00
e13ddee166
Allow mocking rep_hist_bandwidth_assess
2018-09-01 18:47:20 -04:00
842b18ab26
Add test log helpers for msgs not containing str
2018-09-01 18:47:20 -04:00
6210d568ec
Make bandwidth change factor a constant
...
used to determine large changes in bandwidth.
2018-09-01 18:47:20 -04:00
1c62adb65b
Change mention of is_extrainfo router_parse_list_from_string() to want_extrainfo
2018-08-29 21:05:24 -04:00
94605f08fb
Merge branch 'ticket27246_035_01_squashed'
2018-08-29 15:05:05 -04:00
6c0c08bbb5
Expand the comments on ASN.1-encoded TAP keys
2018-08-29 15:04:54 -04:00
Nick Mathewson
teor
rl1987
juga0
Neel Chauhan