mirror of
https://gitlab.torproject.org/tpo/core/tor.git
synced 2024-12-06 19:41:15 +01:00
Fix a pair of remaining leaks in tortls_nss.c
Fun fact: PR_Close leaks memory if its socket is not valid.
This commit is contained in:
@@ -361,7 +361,13 @@ tor_tls_new(tor_socket_t sock, int is_server)
|
||||
(void)sock;
|
||||
tor_tls_context_t *ctx = tor_tls_context_get(is_server);
|
||||
|
||||
PRFileDesc *tcp = PR_ImportTCPSocket(sock);
|
||||
PRFileDesc *tcp = NULL;
|
||||
if (SOCKET_OK(sock)) {
|
||||
tcp = PR_ImportTCPSocket(sock);
|
||||
} else {
|
||||
tcp = PR_NewTCPSocket();
|
||||
}
|
||||
|
||||
if (!tcp)
|
||||
return NULL;
|
||||
|
||||
|
||||
@@ -52,6 +52,8 @@ NS(router_get_my_routerinfo)(void)
|
||||
mock_routerinfo->onion_pkey = crypto_pk_dup_key(tap_key);
|
||||
mock_routerinfo->bandwidthrate = 9001;
|
||||
mock_routerinfo->bandwidthburst = 9002;
|
||||
crypto_pk_free(ident_key);
|
||||
crypto_pk_free(tap_key);
|
||||
}
|
||||
|
||||
return mock_routerinfo;
|
||||
|
||||
Reference in New Issue
Block a user