torproject/tor
1
0
Fork 0
mirror of https://gitlab.torproject.org/tpo/core/tor.git synced 2024-12-06 19:41:15 +01:00
Code Issues Actions Packages Projects Releases Wiki Activity

dirvote: Improve the posted vote log message

Browse Source 
Cleanup after 4631.
This commit is contained in:
teor
2020-02-19 11:15:20 +10:00
committed by Nick Mathewson
parent 15192f88c0
commit bed3b292ad
2 changed files with 7 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/feature/dirauth/dirvote.c
+5 -3
View File
@@ -3223,9 +3223,11 @@ dirvote_add_vote(const char *vote_body, time_t time_posted,
char tbuf1[ISO_TIME_LEN+1], tbuf2[ISO_TIME_LEN+1];
format_iso_time(tbuf1, time_posted);
format_iso_time(tbuf2, voting_schedule.fetch_missing_votes);
log_warn(LD_DIR, "Rejecting vote from %s received at %s; "
"our cutoff for received votes is %s", vi->address, tbuf1, tbuf2);
*msg_out = "Vote received too late, would be dangerous to count it";
log_warn(LD_DIR, "Rejecting posted vote from %s received at %s; "
"our cutoff for received votes is %s. Check your clock, "
"CPU load, and network load. Also check the authority that "
"posted the vote.", vi->address, tbuf1, tbuf2);
*msg_out = "Posted vote received too late, would be dangerous to count it";
goto err;
}
src/test/test_dir_handle_get.c
+2 -2
View File
@@ -2750,7 +2750,7 @@ test_dir_handle_get_status_vote_too_late(void* data)
tt_assert(!vote);
tt_int_op(status_out, OP_EQ, 400);
tt_str_op(msg_out, OP_EQ,
"Vote received too late, would be dangerous to count it");
"Posted vote received too late, would be dangerous to count it");
/* Just after fetch missing */
vote = dirvote_add_vote(VOTE_BODY_V3,
@@ -2759,7 +2759,7 @@ test_dir_handle_get_status_vote_too_late(void* data)
tt_assert(!vote);
tt_int_op(status_out, OP_EQ, 400);
tt_str_op(msg_out, OP_EQ,
"Vote received too late, would be dangerous to count it");
"Posted vote received too late, would be dangerous to count it");
/* On fetch missing */
vote = dirvote_add_vote(VOTE_BODY_V3,