Demote "we stalled too much while trying to write" message to INFO

Resolves ticket 5286.
This commit is contained in:
Nick Mathewson
2014-04-09 11:34:00 -04:00
parent 2f73525883
commit a790454368
2 changed files with 5 additions and 10 deletions
+4
View File
@@ -0,0 +1,4 @@
o Minor features:
- Demote the message that we give when a flushing connection times
out for too long from NOTICE to INFO. It was usually meaningless.
Resolves ticket 5286.
+1 -10
View File
@@ -919,16 +919,7 @@ conn_close_if_marked(int i)
return 0;
}
if (connection_wants_to_flush(conn)) {
int severity;
if (conn->type == CONN_TYPE_EXIT ||
(conn->type == CONN_TYPE_OR && server_mode(get_options())) ||
(conn->type == CONN_TYPE_DIR && conn->purpose == DIR_PURPOSE_SERVER))
severity = LOG_INFO;
else
severity = LOG_NOTICE;
/* XXXX Maybe allow this to happen a certain amount per hour; it usually
* is meaningless. */
log_fn(severity, LD_NET, "We stalled too much while trying to write %d "
log_fn(LOG_INFO, LD_NET, "We stalled too much while trying to write %d "
"bytes to address %s. If this happens a lot, either "
"something is wrong with your network connection, or "
"something is wrong with theirs. "