torproject/tor
1
0
Fork 0
mirror of https://gitlab.torproject.org/tpo/core/tor.git synced 2024-12-06 19:41:15 +01:00
Code Issues Actions Packages Projects Releases Wiki Activity

Remove some XXXX commens in dns.c

Browse Source 
Previously, I was freaking out about passing an unspec address to
dns_found_answer() on an error, since I was using the address type to
determine whether the error was an error on an ipv4 address lookup or
on an ipv6 address lookup.  But now dns_found_answer() has a separate
orig_query_type argument to tell what kind of query it is, so there's
no need to freak out.
This commit is contained in:
Nick Mathewson
2012-11-15 12:17:36 -05:00
parent 12f997528d
commit a4fce0fee8
1 changed files with 3 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/or/dns.c
+3 -3
View File
@@ -1580,7 +1580,7 @@ evdns_callback(int result, char type, int count, int ttl, void *addresses,
const char *hostname = NULL;
int was_wildcarded = 0;
tor_addr_make_unspec(&addr); /*WRONG WRONG WRONG XXXX XXXXX IPV6 prop208*/
tor_addr_make_unspec(&addr);
/* Keep track of whether IPv6 is working */
if (type == DNS_IPv6_AAAA) {
@@ -1615,7 +1615,7 @@ evdns_callback(int result, char type, int count, int ttl, void *addresses,
safe_str(escaped_address),
escaped_safe_str(answer_buf));
was_wildcarded = 1;
tor_addr_make_null(&addr, AF_INET); /* ???? */
tor_addr_make_unspec(&addr);
result = DNS_ERR_NOTEXIST;
} else {
log_debug(LD_EXIT, "eventdns said that %s resolves to %s",
@@ -1637,7 +1637,7 @@ evdns_callback(int result, char type, int count, int ttl, void *addresses,
safe_str(escaped_address),
escaped_safe_str(answer_buf));
was_wildcarded = 1;
tor_addr_make_unspec(&addr); /* WRONG WRONG ETC XXXXXXXX */
tor_addr_make_unspec(&addr);
result = DNS_ERR_NOTEXIST;
} else {
log_debug(LD_EXIT, "eventdns said that %s resolves to %s",