Guard: Don't pick ourselves as a possible Guard

TROVE-2017-12. Severity: Medium

Thankfully, tor will close any circuits that we try to extend to
ourselves so this is not problematic but annoying.

Part of #21534.
This commit is contained in:
David Goulet
2017-11-28 19:09:13 -05:00
committed by Nick Mathewson
parent b1c4ab0bec
commit 91cee3c9e7
2 changed files with 7 additions and 1 deletions
+5
View File
@@ -0,0 +1,5 @@
o Major bugfixes (security, relay):
- When running as a relay, make sure that we never ever choose ourselves
as a guard. Previously, this was possible. Fixes part of bug 21534;
bugfix on 0.3.0.1-alpha. This issue is also tracked as TROVE-2017-012
and CVE-2017-8822.
+2 -1
View File
@@ -740,7 +740,8 @@ node_is_possible_guard(const node_t *node)
node->is_stable &&
node->is_fast &&
node->is_valid &&
node_is_dir(node));
node_is_dir(node) &&
!router_digest_is_me(node->identity));
}
/**