torproject/tor
1
0
Fork 0
mirror of https://gitlab.torproject.org/tpo/core/tor.git synced 2024-12-06 19:41:15 +01:00
Code Issues Actions Packages Projects Releases Wiki Activity

point out some bugs for nick, noticed by whiteout

Browse Source 
svn:r4574
This commit is contained in:
Roger Dingledine
2005-07-15 18:48:38 +00:00
parent 6cb32f0c9d
commit 83dc42055d
1 changed files with 3 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/or/control.c
+3 -2
View File
@@ -315,11 +315,12 @@ read_escaped_data(const char *data, size_t len, int translate_newlines,
*out = outp = tor_malloc(len);
while (len) {
while (len) { /* XXX: len never changes during the loop? */
if (*data == '.')
++data;
if (translate_newlines)
next = tor_memmem(data, len, "\r\n", 2);
/* XXX: as data increases, we're reading past our allowed buffer! */
else
next = tor_memmem(data, len, "\r\n.", 3);
if (next) {
@@ -327,7 +328,7 @@ read_escaped_data(const char *data, size_t len, int translate_newlines,
outp += (next-data);
data = next+2;
} else {
memcpy(outp, data, len);
memcpy(outp, data, len); /* len is constant. scribbling from past *out. */
outp += len;
return outp - *out;
}