torproject/tor
1
0
Fork 0
mirror of https://gitlab.torproject.org/tpo/core/tor.git synced 2024-12-06 19:41:15 +01:00
Code Issues Actions Packages Projects Releases Wiki Activity

check-changes: Check bugfix version formatting

Browse Source 
Check that bugfix versions in changes files look like Tor versions
from the versions spec.

Part of ticket 27761.
This commit is contained in:
teor
2018-09-15 01:23:02 +10:00
parent aebc98d58c
commit 7e862c3ec0
2 changed files with 9 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files
changes/ticket27761
+3
View File
@@ -0,0 +1,3 @@
o Minor features (changelogs):
- Check that bugfix versions in changes files look like Tor versions
from the versions spec. Closes ticket 27761.
scripts/maint/lintChanges.py
+6
View File
@@ -87,6 +87,12 @@ def lintfile(fname):
warn("Bugfix does not say 'Fixes bug X; bugfix on Y'")
elif re.search('tor-([0-9]+)', contents):
warn("Do not prefix versions with 'tor-'. ('0.1.2', not 'tor-0.1.2'.)")
else:
bugfix_match = re.search('bugfix on ([0-9]+\.[0-9]+\.[0-9]+)', contents)
if bugfix_match is None:
warn("Versions must have at least 3 digits. ('0.1.2', '0.3.4.8', or '0.3.5.1-alpha'.)")
elif bugfix_match.group(0) is None:
warn("Versions must have at least 3 digits. ('0.1.2', '0.3.4.8', or '0.3.5.1-alpha'.)")
return have_warned != []