torproject/tor
1
0
Fork 0
mirror of https://gitlab.torproject.org/tpo/core/tor.git synced 2024-12-06 19:41:15 +01:00
Code Issues Actions Packages Projects Releases Wiki Activity

don't update dir_info_status when we have minimum dir info

Browse Source 
Nothing ever uses the string when we're in "have minimum dir info"
state. The flow of the function is "check for problems, if you see a
problem write an explanation to dir_info_status and set res to 0". If
you get to the end of the function without any problems, then res =
1 and we're all ready to start making circuits.

(Changed after consultation with Yawning.)
This commit is contained in:
Roger Dingledine
2015-02-19 06:15:25 -05:00
parent 0e4bdc4005
commit 70f46f7ae6
1 changed files with 0 additions and 16 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/or/nodelist.c
-16
View File
@@ -1703,22 +1703,6 @@ update_router_have_minimum_dir_info(void)
res = 0;
control_event_bootstrap(BOOTSTRAP_STATUS_REQUESTING_DESCRIPTORS, 0);
goto done;
} else {
/* these messages can be excessive in testing networks */
static ratelim_t last_warned =
RATELIM_INIT(NOTICE_DIR_INFO_STATUS_INTERVAL);
char *suppression_msg = NULL;
tor_snprintf(dir_info_status, sizeof(dir_info_status),
"We have enough %sdescriptors: we have %d/%d, and "
"can build %d%% of likely paths. (We have %s.)",
using_md?"micro":"", num_present, num_usable,
(int)(paths*100), status);
if ((suppression_msg = rate_limit_log(&last_warned, time(NULL)))) {
log_info(LD_NET, "%s%s", dir_info_status, suppression_msg);
tor_free(suppression_msg);
}
}
tor_free(status);