torproject/tor
1
0
Fork 0
mirror of https://gitlab.torproject.org/tpo/core/tor.git synced 2024-12-06 19:41:15 +01:00
Code Issues Actions Packages Projects Releases Wiki Activity

Don't crash on malformed EXTENDCIRCUIT.

Browse Source 
Fixes 14116; bugfix on ac68704f in 0.2.2.9-alpha.
This commit is contained in:
Nick Mathewson
2015-01-06 08:49:57 -05:00
parent 184a2dbbdd
commit 6d6643298d
2 changed files with 11 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files
changes/bug14116_025
+3
View File
@@ -0,0 +1,3 @@
o Minor bugfixes (controller):
- Avoid crashing on a malformed EXTENDCIRCUIT command. Fixes bug 14116;
bugfix on 0.2.2.9-alpha.
src/or/control.c
+8
View File
@@ -2451,6 +2451,14 @@ handle_control_extendcircuit(control_connection_t *conn, uint32_t len,
goto done;
}
if (smartlist_len(args) < 2) {
connection_printf_to_buf(conn,
"512 syntax error: not enough arguments.\r\n");
SMARTLIST_FOREACH(args, char *, cp, tor_free(cp));
smartlist_free(args);
goto done;
}
smartlist_split_string(router_nicknames, smartlist_get(args,1), ",", 0, 0);
SMARTLIST_FOREACH(args, char *, cp, tor_free(cp));