mirror of
https://gitlab.torproject.org/tpo/core/tor.git
synced 2024-12-06 19:41:15 +01:00
Do not call tor_tls_server_info_callback(NULL) from tests.
This isn't valid behavior, and it causes a crash when you run the unit tests at --debug. I've added an IF_BUG_ONCE() check for this case.
This commit is contained in:
@@ -1489,6 +1489,10 @@ tor_tls_server_info_callback(const SSL *ssl, int type, int val)
|
||||
tor_tls_t *tls;
|
||||
(void) val;
|
||||
|
||||
IF_BUG_ONCE(ssl == NULL) {
|
||||
return; // LCOV_EXCL_LINE
|
||||
}
|
||||
|
||||
tor_tls_debug_state_callback(ssl, type, val);
|
||||
|
||||
if (type != SSL_CB_ACCEPT_LOOP)
|
||||
|
||||
@@ -1831,8 +1831,6 @@ test_tortls_server_info_callback(void *ignored)
|
||||
tls->magic = TOR_TLS_MAGIC;
|
||||
tls->ssl = ssl;
|
||||
|
||||
tor_tls_server_info_callback(NULL, 0, 0);
|
||||
|
||||
SSL_set_state(ssl, SSL3_ST_SW_SRVR_HELLO_A);
|
||||
mock_clean_saved_logs();
|
||||
tor_tls_server_info_callback(ssl, SSL_CB_ACCEPT_LOOP, 0);
|
||||
|
||||
Reference in New Issue
Block a user