torproject/tor
1
0
Fork 0
mirror of https://gitlab.torproject.org/tpo/core/tor.git synced 2024-12-06 19:41:15 +01:00
Code Issues Actions Packages Projects Releases Wiki Activity

Don't leak on logic error in string_is_valid_nonrfc_hostname()

Browse Source 
This is CID 1437438.  No backport needed: this is unreachable, and
guarded with a BUG() check.
This commit is contained in:
Nick Mathewson
2019-04-11 17:40:05 -04:00
parent 7c98105d56
commit 4e3d144fb0
1 changed files with 6 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/lib/net/address.c
+6 -2
View File
@@ -2027,8 +2027,12 @@ string_is_valid_nonrfc_hostname(const char *string)
smartlist_split_string(components,string,".",0,0);
if (BUG(smartlist_len(components) == 0))
return 0; // LCOV_EXCL_LINE should be impossible given the earlier checks.
if (BUG(smartlist_len(components) == 0)) {
// LCOV_EXCL_START should be impossible given the earlier checks.
smartlist_free(components);
return 0;
// LCOV_EXCL_STOP
}
/* Allow a single terminating '.' used rarely to indicate domains
* are FQDNs rather than relative. */