mirror of
https://gitlab.torproject.org/tpo/core/tor.git
synced 2024-12-06 19:41:15 +01:00
Reserve enough space for rend_service_port_config_t
In #14803, Damian noticed that his Tor sometimes segfaults. Roger noted that his valgrind gave an invalid write of size one here. Whenever we use FLEXIBLE_ARRAY_MEMBER, we have to make sure to actually malloc a thing that's large enough. Fixes bug #14803, not in any released version of Tor.
This commit is contained in:
@@ -314,7 +314,7 @@ static rend_service_port_config_t *
|
||||
rend_service_port_config_new(const char *socket_path)
|
||||
{
|
||||
if (!socket_path)
|
||||
return tor_malloc_zero(sizeof(rend_service_port_config_t));
|
||||
return tor_malloc_zero(sizeof(rend_service_port_config_t) + 1);
|
||||
|
||||
const size_t pathlen = strlen(socket_path) + 1;
|
||||
rend_service_port_config_t *conf =
|
||||
|
||||
Reference in New Issue
Block a user