torproject/tor
1
0
Fork 0
mirror of https://gitlab.torproject.org/tpo/core/tor.git synced 2024-12-06 19:41:15 +01:00
Code Issues Actions Packages Projects Releases Wiki Activity

Fix a memory leak when freeing routerstatuses with exit policy summaries. Patch from mwenge.

Browse Source 
svn:r16659
This commit is contained in:
Nick Mathewson
2008-08-25 23:19:58 +00:00
parent 8b4e9ba02c
commit 2625eb204f
1 changed files with 11 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/or/networkstatus.c
+11 -5
View File
@@ -233,10 +233,19 @@ router_reload_consensus_networkstatus(void)
return 0;
}
static void
vote_routerstatus_free(vote_routerstatus_t *rs)
{
tor_free(rs->version);
tor_free(rs->status.exitsummary);
tor_free(rs);
}
/** Free all storage held by the routerstatus object <b>rs</b>. */
void
routerstatus_free(routerstatus_t *rs)
{
tor_free(rs->exitsummary);
tor_free(rs);
}
@@ -292,13 +301,10 @@ networkstatus_vote_free(networkstatus_t *ns)
if (ns->routerstatus_list) {
if (ns->type == NS_TYPE_VOTE || ns->type == NS_TYPE_OPINION) {
SMARTLIST_FOREACH(ns->routerstatus_list, vote_routerstatus_t *, rs,
{
tor_free(rs->version);
tor_free(rs);
});
vote_routerstatus_free(rs));
} else {
SMARTLIST_FOREACH(ns->routerstatus_list, routerstatus_t *, rs,
tor_free(rs));
routerstatus_free(rs));
}
smartlist_free(ns->routerstatus_list);