torproject/tor
1
0
Fork 0
mirror of https://gitlab.torproject.org/tpo/core/tor.git synced 2024-12-06 19:41:15 +01:00
Code Issues Actions Packages Projects Releases Wiki Activity

Stop silently skipping invalid args to setevents

Browse Source 
Return an error when the second or later arguments of the
"setevents" controller command are invalid events. Previously we
would return success while silently skipping invalid events.

Fixes bug 13205; bugfix on 0.2.3.2-alpha. Reported by "fpxnns".
This commit is contained in:
Roger Dingledine
2014-09-21 16:05:24 -04:00
parent e170205cd8
commit 1b40ea036f
2 changed files with 8 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files
changes/bug13205
+5
View File
@@ -0,0 +1,5 @@
o Minor bugfixes:
- Return an error when the second or later arguments of the
"setevents" controller command are invalid events. Previously we
would return success while silently skipping invalid events. Fixes
bug 13205; bugfix on 0.2.3.2-alpha. Reported by "fpxnns".
src/or/control.c
+3 -1
View File
@@ -949,7 +949,7 @@ static int
handle_control_setevents(control_connection_t *conn, uint32_t len,
const char *body)
{
int event_code = -1;
int event_code;
event_mask_t event_mask = 0;
smartlist_t *events = smartlist_new();
@@ -963,6 +963,8 @@ handle_control_setevents(control_connection_t *conn, uint32_t len,
continue;
} else {
int i;
event_code = -1;
for (i = 0; control_event_table[i].event_name != NULL; ++i) {
if (!strcasecmp(ev, control_event_table[i].event_name)) {
event_code = control_event_table[i].event_code;