mirror of
https://gitlab.torproject.org/tpo/core/tor.git
synced 2024-12-06 19:41:15 +01:00
Don't add redundant quotes with escaped() in log messages.
The escaped() function and its kin already wrap their output in quotes: there's no reason to do so twice. I am _NOT_ making a corresponding change in calls that make the same mistake in controller-related functions, however, due to the risk of a compatibility break. :( Closes #22723.
This commit is contained in:
@@ -0,0 +1,3 @@
|
||||
o Minor bugfixes (logging):
|
||||
- Avoid ""double-quoting"" strings in several log messages.
|
||||
Fixes bug 22723; bugfix on 0.1.2.2-alpha.
|
||||
@@ -110,7 +110,7 @@ add_rsa_fingerprint_to_dir(const char *fp, authdir_config_t *list,
|
||||
tor_strstrip(fingerprint, " ");
|
||||
if (base16_decode(d, DIGEST_LEN,
|
||||
fingerprint, strlen(fingerprint)) != DIGEST_LEN) {
|
||||
log_warn(LD_DIRSERV, "Couldn't decode fingerprint \"%s\"",
|
||||
log_warn(LD_DIRSERV, "Couldn't decode fingerprint %s",
|
||||
escaped(fp));
|
||||
tor_free(fingerprint);
|
||||
return -1;
|
||||
|
||||
@@ -768,11 +768,11 @@ dns_resolve_impl,(edge_connection_t *exitconn, int is_resolve,
|
||||
|
||||
if (!is_reverse || !is_resolve) {
|
||||
if (!is_reverse)
|
||||
log_info(LD_EXIT, "Bad .in-addr.arpa address \"%s\"; sending error.",
|
||||
log_info(LD_EXIT, "Bad .in-addr.arpa address %s; sending error.",
|
||||
escaped_safe_str(exitconn->base_.address));
|
||||
else if (!is_resolve)
|
||||
log_info(LD_EXIT,
|
||||
"Attempt to connect to a .in-addr.arpa address \"%s\"; "
|
||||
"Attempt to connect to a .in-addr.arpa address %s; "
|
||||
"sending error.",
|
||||
escaped_safe_str(exitconn->base_.address));
|
||||
|
||||
|
||||
Reference in New Issue
Block a user