Make an assert into a BUG warning in the bridge code

If future code asks if there are any running bridges, without checking
if bridges are enabled, log a BUG warning rather than crashing.

Fixes 23524 on 0.3.0.1-alpha
This commit is contained in:
teor
2017-09-15 14:02:22 +10:00
parent d60e7df2da
commit 033691212a
2 changed files with 7 additions and 1 deletions
+4
View File
@@ -0,0 +1,4 @@
o Minor bugfixes (DoS-resistance):
- If future code asks if there are any running bridges, without checking
if bridges are enabled, log a BUG warning rather than crashing.
Fixes 23524 on 0.3.0.1-alpha.
+3 -1
View File
@@ -836,7 +836,9 @@ learned_bridge_descriptor(routerinfo_t *ri, int from_cache)
MOCK_IMPL(int,
any_bridge_descriptors_known, (void))
{
tor_assert(get_options()->UseBridges);
if (BUG(!get_options()->UseBridges)) {
return 0;
}
if (!bridge_list)
return 0;