pi-hole/web
1
0
Fork 0
mirror of https://github.com/pi-hole/web.git synced 2024-12-06 19:36:21 +01:00
Code Issues Actions Packages Projects Releases Wiki Activity

Some simplificaton and fixes for php/savesettings.php

Browse Source
This commit is contained in:
DL6ER
2016-12-13 12:13:35 +01:00
parent 9cff0d41bc
commit ff5709b97f
1 changed files with 6 additions and 12 deletions
Download Patch File Download Diff File Expand all files Collapse all files
php/savesettings.php
+6 -12
View File
@@ -82,8 +82,7 @@ function validDomain($domain_name)
// If there has been no error we can save the new DNS server IPs
if(!strlen($error))
{
$cmd = "sudo pihole -a setdns ".$primaryIP." ".$secondaryIP;
exec($cmd);
exec("sudo pihole -a setdns ".$primaryIP." ".$secondaryIP);
}
break;
@@ -102,10 +101,10 @@ function validDomain($domain_name)
break;
// Set domains to be excludef from being shown in Top Domains (or Ads) and Top Clients
// Set domains to be excluded from being shown in Top Domains (or Ads) and Top Clients
case "API":
// Explode the contests of the textareas into PHP arrays
// Explode the contents of the textareas into PHP arrays
// \n (Unix) and \r\n (Win) will be considered as newline
// array_filter( ... ) will remove any empty lines
$domains = array_filter(preg_split('/\r\n|[\r\n]/', $_POST["domains"]));
@@ -156,10 +155,8 @@ function validDomain($domain_name)
if(!strlen($error))
{
// All entries are okay
$cmd = "sudo pihole -a setexcludedomains ".$domainlist;
exec($cmd);
$cmd = "sudo pihole -a setexcludeclients ".$clientlist;
exec($cmd);
exec("sudo pihole -a setexcludedomains ".$domainlist);
exec("sudo pihole -a setexcludeclients ".$clientlist);
}
// Set query log options
@@ -230,10 +227,9 @@ function validDomain($domain_name)
$error .= "Router IP (".$router.") is invalid! ";
}
$cmd = "sudo pihole -a enabledhcp ".$from." ".$to." ".$router;
if(!strlen($error))
{
exec($cmd);
exec("sudo pihole -a enabledhcp ".$from." ".$to." ".$router);
}
}
else
@@ -241,8 +237,6 @@ function validDomain($domain_name)
exec("sudo pihole -a disabledhcp");
}
// $error = $cmd;
break;
default: