pi-hole/web
1
0
Fork 0
mirror of https://github.com/pi-hole/web.git synced 2024-12-06 19:36:21 +01:00
Code Issues Actions Packages Projects Releases Wiki Activity

Address review comments

Browse Source 
Signed-off-by: yubiuser <ckoenig@posteo.de>
This commit is contained in:
yubiuser
2021-08-09 19:49:11 +02:00
parent 086a8dabbb
commit e0ba6ded2a
2 changed files with 2 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files
scripts/pi-hole/js/messages.js
+1 -1
View File
@@ -170,7 +170,7 @@ function deleteMessage() {
var id = tr.attr("data-id");
utils.disableAll();
utils.showAlert("info", "", "Deleting message # ", id);
utils.showAlert("info", "", "Deleting message with ID " + parseInt(id, 10), "...");
$.ajax({
url: "scripts/pi-hole/php/message.php",
method: "post",
scripts/pi-hole/php/message.php
+1 -5
View File
@@ -42,10 +42,9 @@ function JSON_error($message = null)
echo json_encode($response);
}
if ($_POST['action'] == 'delete_message') {
if ($_POST['action'] == 'delete_message' && isset($_POST['id'])) {
// Delete message identified by ID
try {
$db->query('BEGIN TRANSACTION;');
$stmt = $db->prepare('DELETE FROM message WHERE id=:id');
if (!$stmt) {
@@ -60,9 +59,6 @@ if ($_POST['action'] == 'delete_message') {
throw new Exception('While executing message statement: ' . $db->lastErrorMsg());
}
if(!$db->query('COMMIT;')) {
throw new Exception('While commiting changes to the database: ' . $db->lastErrorMsg());
}
$reload = true;
JSON_success();