Set stateDuration to 0 for all saved datatables to store the state indefinitely (#1944)

* Set stateDuration to 0 for all saved datatables to store the state indefinite

Signed-off-by: Christian König <ckoenig@posteo.de>

* Move stateDuration to utils.js

Signed-off-by: Christian König <ckoenig@posteo.de>

* Remove duplicated code as it is already part of utils.stateLoadCallback

Signed-off-by: Christian König <ckoenig@posteo.de>

* Fix function

Signed-off-by: Christian König <ckoenig@posteo.de>

* Revert "Fix function"

This reverts commit 2f54f5f988.

Signed-off-by: Christian König <ckoenig@posteo.de>

* Revert "Move stateDuration to utils.js"

This reverts commit 6a3e7786bc.

Signed-off-by: Christian König <ckoenig@posteo.de>

scripts/pi-hole/js/customcname.js

@@ -71,6 +71,7 @@ $(function () {
     ],
     order: [[0, "asc"]],
     stateSave: true,
+    stateDuration: 0,
     stateSaveCallback: function (settings, data) {
       utils.stateSaveCallback("LocalCNAMETable", data);
     },

scripts/pi-hole/js/customdns.js

@@ -71,6 +71,7 @@ $(function () {
     ],
     order: [[0, "asc"]],
     stateSave: true,
+    stateDuration: 0,
     stateSaveCallback: function (settings, data) {
       utils.stateSaveCallback("LocalDNSTable", data);
     },

scripts/pi-hole/js/groups-adlists.js

@@ -289,17 +289,13 @@ function initTable() {
       [10, 25, 50, 100, "All"],
     ],
     stateSave: true,
+    stateDuration: 0,
     stateSaveCallback: function (settings, data) {
       utils.stateSaveCallback("groups-adlists-table", data);
     },
     stateLoadCallback: function () {
       var data = utils.stateLoadCallback("groups-adlists-table");
 
-      // Return if not available
-      if (data === null) {
-        return null;
-      }
-
       // Reset visibility of ID column
       data.columns[0].visible = false;
       // Apply loaded state to table

scripts/pi-hole/js/groups-clients.js

@@ -217,17 +217,13 @@ function initTable() {
       [10, 25, 50, 100, "All"],
     ],
     stateSave: true,
+    stateDuration: 0,
     stateSaveCallback: function (settings, data) {
       utils.stateSaveCallback("groups-clients-table", data);
     },
     stateLoadCallback: function () {
       var data = utils.stateLoadCallback("groups-clients-table");
 
-      // Return if not available
-      if (data === null) {
-        return null;
-      }
-
       // Reset visibility of ID column
       data.columns[0].visible = false;
       // Apply loaded state to table

scripts/pi-hole/js/groups-domains.js

@@ -246,17 +246,13 @@ function initTable() {
       [10, 25, 50, 100, "All"],
     ],
     stateSave: true,
+    stateDuration: 0,
     stateSaveCallback: function (settings, data) {
       utils.stateSaveCallback("groups-domains-table", data);
     },
     stateLoadCallback: function () {
       var data = utils.stateLoadCallback("groups-domains-table");
 
-      // Return if not available
-      if (data === null) {
-        return null;
-      }
-
       // Reset visibility of ID column
       data.columns[0].visible = false;
       // Show group assignment column only on full page

scripts/pi-hole/js/groups.js

@@ -86,17 +86,13 @@ $(function () {
       [10, 25, 50, 100, "All"],
     ],
     stateSave: true,
+    stateDuration: 0,
     stateSaveCallback: function (settings, data) {
       utils.stateSaveCallback("groups-table", data);
     },
     stateLoadCallback: function () {
       var data = utils.stateLoadCallback("groups-table");
 
-      // Return if not available
-      if (data === null) {
-        return null;
-      }
-
       // Reset visibility of ID column
       data.columns[0].visible = false;
       // Apply loaded state to table

scripts/pi-hole/js/messages.js

@@ -141,15 +141,12 @@ $(function () {
       emptyTable: "No issues found.",
     },
     stateSave: true,
+    stateDuration: 0,
     stateSaveCallback: function (settings, data) {
       utils.stateSaveCallback("messages-table", data);
     },
     stateLoadCallback: function () {
       var data = utils.stateLoadCallback("messages-table");
-      // Return if not available
-      if (data === null) {
-        return null;
-      }
 
       // Reset visibility of ID and blob columns
       var hiddenCols = [0, 4, 5, 6, 7, 8];

scripts/pi-hole/js/network.js

@@ -276,6 +276,7 @@ $(function () {
       [10, 25, 50, 100, "All"],
     ],
     stateSave: true,
+    stateDuration: 0,
     stateSaveCallback: function (settings, data) {
       utils.stateSaveCallback("network_table", data);
     },

scripts/pi-hole/js/queries.js

@@ -334,6 +334,7 @@ $(function () {
       [10, 25, 50, 100, "All"],
     ],
     stateSave: true,
+    stateDuration: 0,
     stateSaveCallback: function (settings, data) {
       utils.stateSaveCallback("query_log_table", data);
     },

scripts/pi-hole/js/settings.js

@@ -223,6 +223,7 @@ $(function () {
       scrollX: true,
       order: [[2, "asc"]],
       stateSave: true,
+      stateDuration: 0,
       stateSaveCallback: function (settings, data) {
         utils.stateSaveCallback("activeDhcpLeaseTable", data);
       },