Merge pull request #1005 from pi-hole/fix/settings-xss

Fix some XSS issues in settings.php
This commit is contained in:
Adam Warner
2019-09-19 22:32:44 +01:00
committed by GitHub
+5 -5
View File
@@ -787,7 +787,7 @@ if (isset($_GET['tab']) && in_array($_GET['tab'], array("sysadmin", "blocklists"
<div class="radio">
<label><input type="radio" name="DNSinterface" value="single"
<?php if ($DNSinterface == "single"){ ?>checked<?php } ?>>
<strong>Listen only on interface <?php echo $piHoleInterface; ?></strong>
<strong>Listen only on interface <?php echo htmlentities($piHoleInterface); ?></strong>
</label>
</div>
<div class="radio">
@@ -1196,19 +1196,19 @@ if (isset($_GET['tab']) && in_array($_GET['tab'], array("sysadmin", "blocklists"
<tbody>
<tr>
<th scope="row">Pi-hole Ethernet Interface:</th>
<td><?php echo $piHoleInterface; ?></td>
<td><?php echo htmlentities($piHoleInterface); ?></td>
</tr>
<tr>
<th scope="row">Pi-hole IPv4 address:</th>
<td><?php echo $piHoleIPv4; ?></td>
<td><?php echo htmlentities($piHoleIPv4); ?></td>
</tr>
<tr>
<th scope="row">Pi-hole IPv6 address:</th>
<td><?php echo $piHoleIPv6; ?></td>
<td><?php echo htmlentities($piHoleIPv6); ?></td>
</tr>
<tr>
<th scope="row">Pi-hole hostname:</th>
<td><?php echo $hostname; ?></td>
<td><?php echo htmlentities($hostname); ?></td>
</tr>
</tbody>
</table>