pi-hole/docs
1
0
Fork 0
mirror of https://github.com/pi-hole/docs.git synced 2024-12-06 19:27:12 +01:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

Removed old image, replaced with new

Browse Source 
Signed-off-by: root <root@dev.toakan.uk>
This commit is contained in:
root
2018-12-10 16:40:59 +00:00
parent 65f92ad8b7
commit 897d01a330
2 changed files with 1 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files
docs/guides/github/contributing.md
+1 -5
View File
@@ -19,14 +19,10 @@ Contributors *sign-off* that they adhere to these requirements by adding a Signe
The Pi-hole project uses a DCO bot for all GitHub pulls to verify that each commit is signed off. When you create your pull request, it will automaticaly be verified by this bot. An example of what to expect is below.
![Screenshot](../../images/github-commit-bots.png)
![Screenshot](../../images/github-commit-bots-expanded.png)
If your Pull Request fails the DCO check, it's necessary to fix the entire commit history in the PR. Although this is a situation we'd like to avoid the best practice is to squash the commit history to a single commit, append the DCO sign-off as described above or interactively in the rebase comment editing process, and force push. For example, if you have 2 commits in your history (Note the ~2):
An example of the correct bot response is below.
![Screenshot](../../images/github-commit-bots-expanded.png)
```bash
git rebase --interactive HEAD~2
(interactive squash + DCO append)
docs/images/github-commit-bots.png
BIN
View File
Binary file not shown.
Side by Side

Before

Width:  |  Height:  |  Size: 7.1 KiB