pi-hole/FTL
1
0
Fork 0
mirror of https://github.com/pi-hole/FTL.git synced 2024-10-26 16:52:18 +02:00
Code Issues Actions Packages Projects Releases Wiki Activity

Merge pull request #991 from pi-hole/revert-984-tweak/fallback_ftruncate

Browse Source 
Revert #984
This commit is contained in:
Dan Schaper
2020-12-20 11:17:20 -08:00
committed by GitHub
parent d4a1be857c a66315d292
commit e71b6faba4
1 changed files with 9 additions and 55 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/shmem.c
+9 -55
View File
@@ -513,35 +513,12 @@ SharedMemory create_shm(const char *name, const size_t size, bool create_new)
// Using fallocate() will ensure that there's actually space for
// this file. Otherwise we end up with a sparse file that can give
// SIGBUS if we run out of space while writing to it.
int ret = fallocate(fd, 0, 0U, size);
const int fallocate_errno = errno;
const int ret = fallocate(fd, 0, 0U, size);
if(ret != 0)
{
// Try again with ftruncate() if fallocate() failed with
// "Operation not supported"
if(errno == ENOTSUP)
{
ret = ftruncate(fd, size);
// Report info that space has only been reserved, not
// really allocated
if(ret == 0)
{
logg("INFO: create_shm(): Failed to allocate %zu bytes for \"%s\" (%s, %i), "\
"space has only been reserved.",
size, sharedMemory.name, strerror(errno), errno);
}
}
if(ret != 0)
{
logg("FATAL: create_shm(): Failed to resize \"%s\" (%i) to %zu:",
sharedMemory.name, fd, size);
logg(" fallocate returned: %s (%i)",
strerror(fallocate_errno), fallocate_errno);
logg(" ftruncate returned: %s (%i)",
strerror(errno), errno);
exit(EXIT_FAILURE);
}
logg("FATAL: create_shm(): Failed to resize \"%s\" (%i) to %zu: %s (%i)",
sharedMemory.name, fd, size, strerror(errno), ret);
exit(EXIT_FAILURE);
}
// Create shared memory mapping
@@ -660,35 +637,12 @@ bool realloc_shm(SharedMemory *sharedMemory, const size_t size1, const size_t si
// Using fallocate() will ensure that there's actually space for
// this file. Otherwise we end up with a sparse file that can give
// SIGBUS if we run out of space while writing to it.
int ret = fallocate(fd, 0, 0U, size);
const int fallocate_errno = errno;
if(ret == -1)
const int ret = fallocate(fd, 0, 0U, size);
if(ret != 0)
{
// Try again with ftruncate() if fallocate() failed with
// "Operation not supported"
if(errno == ENOTSUP)
{
ret = ftruncate(fd, size);
// Report info that space has only been reserved, not
// really allocated
if(ret == 0)
{
logg("INFO: realloc_shm(): Failed to allocate %zu bytes for \"%s\" (%s), "\
"space has only been reserved.",
size, sharedMemory->name, strerror(errno));
}
}
if(ret == -1)
{
logg("FATAL: realloc_shm(): Failed to resize \"%s\" (%i) to %zu:",
sharedMemory->name, fd, size);
logg(" fallocate returned: %s (%i)",
strerror(fallocate_errno), fallocate_errno);
logg(" ftruncate returned: %s (%i)",
strerror(errno), errno);
exit(EXIT_FAILURE);
}
logg("FATAL: realloc_shm(): Failed to resize \"%s\" (%i) to %zu: %s (%i)",
sharedMemory->name, fd, size, strerror(errno), ret);
exit(EXIT_FAILURE);
}
// Close shared memory object file descriptor as it is no longer