blade/simplex-chat
1
0
Fork 0
mirror of https://github.com/simplex-chat/simplex-chat.git synced 2024-12-17 17:20:21 +01:00
Code Issues Actions Packages Projects Releases Wiki Activity

desktop: fix video calls in Firefox (#4034)

Browse Source 
* desktop: fix video calls in Firefox

* one more play()
This commit is contained in:
Stanislav Dmitrenko
2024-04-16 14:22:40 +07:00
committed by GitHub
parent 7ff4b05c90
commit c2169f7813
4 changed files with 15 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files
apps/multiplatform/common/src/commonMain/resources/assets/www/call.js
+8 -2
View File
@@ -38,7 +38,7 @@ const processCommand = (function () {
const defaultIceServers = [
{ urls: ["stuns:stun.simplex.im:443"] },
{ urls: ["stun:stun.simplex.im:443"] },
//{ urls: ["turns:turn.simplex.im:443?transport=udp"], username: "private2", credential: "Hxuq2QxUjnhj96Zq2r4HjqHRj" },
//{urls: ["turns:turn.simplex.im:443?transport=udp"], username: "private2", credential: "Hxuq2QxUjnhj96Zq2r4HjqHRj"},
{ urls: ["turns:turn.simplex.im:443?transport=tcp"], username: "private2", credential: "Hxuq2QxUjnhj96Zq2r4HjqHRj" },
];
function getCallConfig(encodedInsertableStreams, iceServers, relay) {
@@ -376,6 +376,9 @@ const processCommand = (function () {
// setupVideoElement(videos.remote)
videos.local.srcObject = call.localStream;
videos.remote.srcObject = call.remoteStream;
// Without doing it manually Firefox shows black screen but video can be played in Picture-in-Picture
videos.local.play();
videos.remote.play();
}
async function setupEncryptionWorker(call) {
if (call.aesKey) {
@@ -448,7 +451,9 @@ const processCommand = (function () {
codecs.splice(selectedCodecIndex, 1);
codecs.unshift(selectedCodec);
for (const t of call.connection.getTransceivers()) {
if (((_a = t.sender.track) === null || _a === void 0 ? void 0 : _a.kind) === "video") {
// Firefox doesn't have this function implemented:
// https://bugzilla.mozilla.org/show_bug.cgi?id=1396922
if (((_a = t.sender.track) === null || _a === void 0 ? void 0 : _a.kind) === "video" && t.setCodecPreferences) {
t.setCodecPreferences(codecs);
}
}
@@ -486,6 +491,7 @@ const processCommand = (function () {
replaceTracks(pc, videoTracks);
call.localStream = localStream;
videos.local.srcObject = localStream;
videos.local.play();
}
function replaceTracks(pc, tracks) {
if (!tracks.length)
apps/multiplatform/common/src/commonMain/resources/assets/www/desktop/call.html
-2
View File
@@ -10,7 +10,6 @@
<video
id="remote-video-stream"
class="inline"
autoplay
playsinline
poster="data:image/png;base64,iVBORw0KGgoAAAANSUhEUgAAAAoAAAAKCAQAAAAnOwc2AAAAEUlEQVR42mNk+M+AARiHsiAAcCIKAYwFoQ8AAAAASUVORK5CYII="
onclick="javascript:toggleRemoteVideoFitFill()"
@@ -19,7 +18,6 @@
id="local-video-stream"
class="inline"
muted
autoplay
playsinline
poster="data:image/png;base64,iVBORw0KGgoAAAANSUhEUgAAAAoAAAAKCAQAAAAnOwc2AAAAEUlEQVR42mNk+M+AARiHsiAAcCIKAYwFoQ8AAAAASUVORK5CYII="
></video>
packages/simplex-chat-webrtc/src/call.ts
+7 -1
View File
@@ -577,6 +577,9 @@ const processCommand = (function () {
// setupVideoElement(videos.remote)
videos.local.srcObject = call.localStream
videos.remote.srcObject = call.remoteStream
// Without doing it manually Firefox shows black screen but video can be played in Picture-in-Picture
videos.local.play()
videos.remote.play()
}
async function setupEncryptionWorker(call: Call) {
@@ -652,7 +655,9 @@ const processCommand = (function () {
codecs.splice(selectedCodecIndex, 1)
codecs.unshift(selectedCodec)
for (const t of call.connection.getTransceivers()) {
if (t.sender.track?.kind === "video") {
// Firefox doesn't have this function implemented:
// https://bugzilla.mozilla.org/show_bug.cgi?id=1396922
if (t.sender.track?.kind === "video" && t.setCodecPreferences) {
t.setCodecPreferences(codecs)
}
}
@@ -690,6 +695,7 @@ const processCommand = (function () {
replaceTracks(pc, videoTracks)
call.localStream = localStream
videos.local.srcObject = localStream
videos.local.play()
}
function replaceTracks(pc: RTCPeerConnection, tracks: MediaStreamTrack[]) {
packages/simplex-chat-webrtc/src/desktop/call.html
-2
View File
@@ -10,7 +10,6 @@
<video
id="remote-video-stream"
class="inline"
autoplay
playsinline
poster="data:image/png;base64,iVBORw0KGgoAAAANSUhEUgAAAAoAAAAKCAQAAAAnOwc2AAAAEUlEQVR42mNk+M+AARiHsiAAcCIKAYwFoQ8AAAAASUVORK5CYII="
onclick="javascript:toggleRemoteVideoFitFill()"
@@ -19,7 +18,6 @@
id="local-video-stream"
class="inline"
muted
autoplay
playsinline
poster="data:image/png;base64,iVBORw0KGgoAAAANSUhEUgAAAAoAAAAKCAQAAAAnOwc2AAAAEUlEQVR42mNk+M+AARiHsiAAcCIKAYwFoQ8AAAAASUVORK5CYII="
></video>