David Goulet df312b3cf6 hs-v3: Remove a BUG() when storing a descriptor in the client cache ...

It is possible in normal circumstances that  a client fetches a descriptor
that has a lower revision counter than the one in its cache. This can happen
due to HSDir desync.

Fixes #24976

Signed-off-by: David Goulet <dgoulet@torproject.org>

2018-01-31 12:51:42 -05:00

..

addressmap.c

Replace accumulated C ;;s with ;s

2017-09-15 16:43:17 -04:00

addressmap.h

Run our #else/#endif annotator on our source code.

2017-09-15 16:24:44 -04:00

bridges.c

Make sure bridges are definitely running before delaying directory fetches

2017-12-12 19:17:25 -05:00

bridges.h

Stop checking cached bridge descriptors for usable bridges

2017-11-22 02:00:34 +11:00

channel.c

Merge branch 'bug22805_v2_squashed'

2017-09-22 08:58:17 -04:00

channel.h

Merge branch 'bug22805_v2_squashed'

2017-09-22 08:58:17 -04:00

channelpadding.c

Merge branch 'bug22805_v2_squashed'

2017-09-22 08:58:17 -04:00

channelpadding.h

Run our #else/#endif annotator on our source code.

2017-09-15 16:24:44 -04:00

channeltls.c

Fix a comment that misunderstood is_canonical

2017-09-20 09:41:01 -04:00

channeltls.h

Run our #else/#endif annotator on our source code.

2017-09-15 16:24:44 -04:00

circpathbias.c

Run our #else/#endif annotator on our source code.

2017-09-15 16:24:44 -04:00

circpathbias.h

Run our #else/#endif annotator on our source code.

2017-09-15 16:24:44 -04:00

circuitbuild.c

Merge branch 'bug22805_v2_squashed'

2017-09-22 08:58:17 -04:00

circuitbuild.h

Run our #else/#endif annotator on our source code.

2017-09-15 16:24:44 -04:00

circuitlist.c

test: Add HSv3 unit test for expiring intro point

2017-12-05 10:55:41 -05:00

circuitlist.h

test: Add HSv3 unit test for expiring intro point

2017-12-05 10:55:41 -05:00

circuitmux_ewma.c

Switch to offsetof()

2017-08-03 08:56:35 -04:00

circuitmux_ewma.h

Run our #else/#endif annotator on our source code.

2017-09-15 16:24:44 -04:00

circuitmux.c

Merge branch 'maint-0.3.1' into maint-0.3.2

2017-12-21 10:50:33 -05:00

circuitmux.h

Merge branch 'maint-0.3.1' into maint-0.3.2

2017-12-21 10:50:33 -05:00

circuitstats.c

Tweak the message when we re-enable CBT.

2017-11-15 14:42:59 -05:00

circuitstats.h

Run our #else/#endif annotator on our source code.

2017-09-15 16:24:44 -04:00

circuituse.c

Merge branch 'bug24367_032_squashed' into maint-0.3.2

2017-12-12 19:17:38 -05:00

circuituse.h

Run our #else/#endif annotator on our source code.

2017-09-15 16:24:44 -04:00

command.c

Merge branch 'maint-0.3.1' into maint-0.3.2

2018-01-17 11:12:15 -05:00

command.h

Run our #else/#endif annotator on our source code.

2017-09-15 16:24:44 -04:00

config.c

Merge branch 'maint-0.3.0' into maint-0.3.1

2018-01-05 16:41:34 -05:00

config.h

Merge branch 'feature18329_029_squashed' into maint-0.3.2

2017-10-24 19:35:28 -04:00

confparse.c

Delete useless checks in confparse.c

2017-05-02 16:12:30 -04:00

confparse.h

Eat redundant semicolons

2017-09-26 15:12:34 -04:00

connection_edge.c

Revert "Make ClientDNSRejectInternalAddresses testing-only."

2017-11-04 18:30:59 +01:00

connection_edge.h

Run our #else/#endif annotator on our source code.

2017-09-15 16:24:44 -04:00

connection_or.c

Merge branch 'maint-0.3.1' into maint-0.3.2

2018-01-17 11:12:15 -05:00

connection_or.h

Run our #else/#endif annotator on our source code.

2017-09-15 16:24:44 -04:00

connection.c

Merge branch 'maint-0.3.0' into maint-0.3.1

2017-12-11 16:56:31 -05:00

connection.h

Run our #else/#endif annotator on our source code.

2017-09-15 16:24:44 -04:00

conscache.c

Merge branches 'bug24099_031' and 'bug24086_031' into maint-0.3.2

2017-11-21 12:37:46 -05:00

conscache.h

Run our #else/#endif annotator on our source code.

2017-09-15 16:24:44 -04:00

consdiff.c

Improve fragile-hardening performance of consensus_split_lines.

2018-01-16 12:42:40 -05:00

consdiff.h

Run our #else/#endif annotator on our source code.

2017-09-15 16:24:44 -04:00

consdiffmgr.c

Merge branch 'maint-0.3.1' into maint-0.3.2

2018-01-31 10:06:49 -05:00

consdiffmgr.h

Run our #else/#endif annotator on our source code.

2017-09-15 16:24:44 -04:00

control.c

control: Fix wrong Action on failure to upload an HS descriptor

2017-11-10 15:31:31 -05:00

control.h

Run our #else/#endif annotator on our source code.

2017-09-15 16:24:44 -04:00

cpuworker.c

Merge branch 'maint-0.3.1'

2017-07-27 16:30:52 -04:00

cpuworker.h

Run our #else/#endif annotator on our source code.

2017-09-15 16:24:44 -04:00

dircollate.c

Switch to offsetof()

2017-08-03 08:56:35 -04:00

dircollate.h

Run our #else/#endif annotator on our source code.

2017-09-15 16:24:44 -04:00

directory.c

Make sure bridges are definitely running before delaying directory fetches

2017-12-12 19:17:25 -05:00

directory.h

Intoduce unittest for skipping outdated dirservers.

2017-11-17 09:57:46 -05:00

dirserv.c

Merge branch 'maint-0.2.9' into maint-0.3.0

2017-10-23 08:46:29 -04:00

dirserv.h

Run our #else/#endif annotator on our source code.

2017-09-15 16:24:44 -04:00

dirvote.c

dirauth: Recalculate voting schedule at first vote

2017-11-08 14:46:49 -05:00

dirvote.h

dirauth: Recalculate voting schedule at first vote

2017-11-08 14:46:49 -05:00

dns_structs.h

Run our #else/#endif annotator on our source code.

2017-09-15 16:24:44 -04:00

dns.c

Merge branch 'maint-0.3.0' into maint-0.3.1

2017-11-30 11:48:12 -05:00

dns.h

Run our #else/#endif annotator on our source code.

2017-09-15 16:24:44 -04:00

dnsserv.c

Run our #else/#endif annotator on our source code.

2017-09-15 16:24:44 -04:00

dnsserv.h

Run our #else/#endif annotator on our source code.

2017-09-15 16:24:44 -04:00

entrynodes.c

Merge branch 'bug24367_032_squashed' into maint-0.3.2

2017-12-12 19:17:38 -05:00

entrynodes.h

Make sure bridges are definitely running before delaying directory fetches

2017-12-12 19:17:25 -05:00

ext_orport.c

Warn on ExtORPort USERADDR that is missing or 0.

2017-09-20 08:50:49 -04:00

ext_orport.h

Run our #else/#endif annotator on our source code.

2017-09-15 16:24:44 -04:00

fallback_dirs.inc

Add 7 other fallback dirs from teor's tests

2018-01-08 11:03:44 -05:00

fp_pair.c

Run the copyright update script.

2017-03-15 16:13:17 -04:00

fp_pair.h

Run our #else/#endif annotator on our source code.

2017-09-15 16:24:44 -04:00

geoip.c

New GETINFO target to check if geoip is loaded

2017-08-25 12:25:05 -04:00

geoip.h

Run our #else/#endif annotator on our source code.

2017-09-15 16:24:44 -04:00

hibernate.c

Run our #else/#endif annotator on our source code.

2017-09-15 16:24:44 -04:00

hibernate.h

Run our #else/#endif annotator on our source code.

2017-09-15 16:24:44 -04:00

hs_cache.c

hs-v3: Remove a BUG() when storing a descriptor in the client cache

2018-01-31 12:51:42 -05:00

hs_cache.h

Run our #else/#endif annotator on our source code.

2017-09-15 16:24:44 -04:00

hs_cell.c

prop224: Add a function to clear INTRO data

2017-08-24 13:03:28 -04:00

hs_cell.h

Run our #else/#endif annotator on our source code.

2017-09-15 16:24:44 -04:00

hs_circuit.c

Merge branch 'bug24895_031_02' into bug24895_032_02

2018-01-19 16:26:26 -05:00

hs_circuit.h

hs-v3: Cleanup HS circuits when marking as closed

2017-12-05 10:55:41 -05:00

hs_circuitmap.c

Run our #else/#endif annotator on our source code.

2017-09-15 16:24:44 -04:00

hs_circuitmap.h

Run our #else/#endif annotator on our source code.

2017-09-15 16:24:44 -04:00

hs_client.c

When a tor_cert_T check fails, log the reason why.

2018-01-26 13:55:25 -05:00

hs_client.h

hs-v3: Attempt descriptor refetch when dirinfo changes

2017-10-31 12:14:11 -04:00

hs_common.c

Merge branch 'bug24895_031_02' into bug24895_032_02

2018-01-19 16:26:26 -05:00

hs_common.h

Merge branch 'bug24895_031_02' into bug24895_032_02

2018-01-19 16:26:26 -05:00

hs_config.c

Stop users configuring IPv6-only v3 single onion services

2017-11-02 10:19:05 -04:00

hs_config.h

Run our #else/#endif annotator on our source code.

2017-09-15 16:24:44 -04:00

hs_descriptor.c

When a tor_cert_T check fails, log the reason why.

2018-01-26 13:55:25 -05:00

hs_descriptor.h

double newline

2017-10-31 14:18:48 -04:00

hs_ident.c

hs-v3: Cancel active descriptor directory connections before uploading

2017-09-12 01:32:04 +03:00

hs_ident.h

Run our #else/#endif annotator on our source code.

2017-09-15 16:24:44 -04:00

hs_intropoint.c

hs: Avoid possible double circuit close on error

2017-09-22 09:09:13 -04:00

hs_intropoint.h

Run our #else/#endif annotator on our source code.

2017-09-15 16:24:44 -04:00

hs_ntor.c

Explicit length checks in create_rend_cpath().

2017-07-07 11:12:27 -04:00

hs_ntor.h

Run our #else/#endif annotator on our source code.

2017-09-15 16:24:44 -04:00

hs_service.c

Merge branch 'bug24895_029_02' into bug24895_031_02

2018-01-19 16:21:55 -05:00

hs_service.h

Run our #else/#endif annotator on our source code.

2017-09-15 16:24:44 -04:00

include.am

sched: Groundwork before KIST implementation

2017-09-15 11:40:59 -04:00

keypin.c

Run the copyright update script.

2017-03-15 16:13:17 -04:00

keypin.h

Run our #else/#endif annotator on our source code.

2017-09-15 16:24:44 -04:00

main.c

Update entry guard state whenever we download a consensus.

2017-12-01 14:09:29 +02:00

main.h

Run our #else/#endif annotator on our source code.

2017-09-15 16:24:44 -04:00

Makefile.nmake

Netflow record collapsing defense.

2017-05-08 13:49:21 -04:00

microdesc.c

Merge branch 'bug23817_031' into maint-0.3.2

2017-11-17 09:56:53 -05:00

microdesc.h

Introduce cache for outdated microdesc dirservers.

2017-11-17 09:52:40 -05:00

networkstatus.c

Make sure bridges are definitely running before delaying directory fetches

2017-12-12 19:17:25 -05:00

networkstatus.h

Run our #else/#endif annotator on our source code.

2017-09-15 16:24:44 -04:00

nodelist.c

nodelist: Downgrade warning to protocol warning

2017-11-02 10:33:57 -04:00

nodelist.h

Run our #else/#endif annotator on our source code.

2017-09-15 16:24:44 -04:00

ntmain.c

Merge remote-tracking branch 'public/bug23081_025' into maint-0.2.9

2017-10-23 08:47:52 -04:00

ntmain.h

Run our #else/#endif annotator on our source code.

2017-09-15 16:24:44 -04:00

onion_fast.c

Run the copyright update script.

2017-03-15 16:13:17 -04:00

onion_fast.h

Run our #else/#endif annotator on our source code.

2017-09-15 16:24:44 -04:00

onion_ntor.c

Run the copyright update script.

2017-03-15 16:13:17 -04:00

onion_ntor.h

Run our #else/#endif annotator on our source code.

2017-09-15 16:24:44 -04:00

onion_tap.c

Rename the hybrid_encrypt/decrypt functions; label them as dangerous

2017-07-24 14:34:53 -04:00

onion_tap.h

Run our #else/#endif annotator on our source code.

2017-09-15 16:24:44 -04:00

onion.c

Fix ntohs() that should have been htons()

2017-08-04 12:17:53 -04:00

onion.h

Run our #else/#endif annotator on our source code.

2017-09-15 16:24:44 -04:00

or.h

Merge branch 'maint-0.3.1' into maint-0.3.2

2017-12-21 10:50:33 -05:00

parsecommon.c

Fix warnings about passing uninitialized buffers into functions

2017-09-12 21:32:42 -04:00

parsecommon.h

Run our #else/#endif annotator on our source code.

2017-09-15 16:24:44 -04:00

periodic.c

Run the copyright update script.

2017-03-15 16:13:17 -04:00

periodic.h

Run our #else/#endif annotator on our source code.

2017-09-15 16:24:44 -04:00

policies.c

Merge branch 'maint-0.3.0' into maint-0.3.1

2018-01-02 10:10:28 -05:00

policies.h

Run our #else/#endif annotator on our source code.

2017-09-15 16:24:44 -04:00

proto_cell.c

Add unit tests for var_cell and control0 proto functions.

2017-09-27 09:09:00 -04:00

proto_cell.h

Run our #else/#endif annotator on our source code.

2017-09-15 16:24:44 -04:00

proto_control0.c

Refactor buffer APIs to put a buf_t first.

2017-09-05 13:57:51 -04:00

proto_control0.h

Run our #else/#endif annotator on our source code.

2017-09-15 16:24:44 -04:00

proto_ext_or.c

Refactor buffer APIs to put a buf_t first.

2017-09-05 13:57:51 -04:00

proto_ext_or.h

Run our #else/#endif annotator on our source code.

2017-09-15 16:24:44 -04:00

proto_http.c

Refactor buffer APIs to put a buf_t first.

2017-09-05 13:57:51 -04:00

proto_http.h

Run our #else/#endif annotator on our source code.

2017-09-15 16:24:44 -04:00

proto_socks.c

Fix our "not an HTTP Proxy" message in light of HTTPTunnelPort

2017-10-02 12:53:13 -04:00

proto_socks.h

Run our #else/#endif annotator on our source code.

2017-09-15 16:24:44 -04:00

protover.c

Merge branch 'maint-0.2.9' into maint-0.3.0

2017-11-30 12:07:59 -05:00

protover.h

Run our #else/#endif annotator on our source code.

2017-09-15 16:24:44 -04:00

reasons.c

Run our #else/#endif annotator on our source code.

2017-09-15 16:24:44 -04:00

reasons.h

Run our #else/#endif annotator on our source code.

2017-09-15 16:24:44 -04:00

relay.c

Merge branch 'maint-0.3.1' into maint-0.3.2

2017-12-21 10:50:33 -05:00

relay.h

Merge branch 'maint-0.3.1' into maint-0.3.2

2017-12-21 10:50:33 -05:00

rendcache.c

prop224: Purge client state on NEWNYM

2017-08-30 09:15:54 -04:00

rendcache.h

Run our #else/#endif annotator on our source code.

2017-09-15 16:24:44 -04:00

rendclient.c

Run our #else/#endif annotator on our source code.

2017-09-15 16:24:44 -04:00

rendclient.h

Run our #else/#endif annotator on our source code.

2017-09-15 16:24:44 -04:00

rendcommon.c

Merge branch 'maint-0.3.1'

2017-08-25 11:39:38 -04:00

rendcommon.h

Run our #else/#endif annotator on our source code.

2017-09-15 16:24:44 -04:00

rendmid.c

rephist: Remove unused crypto_pk statistics.

2017-07-13 20:24:48 +00:00

rendmid.h

Run our #else/#endif annotator on our source code.

2017-09-15 16:24:44 -04:00

rendservice.c

Merge branch 'bug24895_031_02' into bug24895_032_02

2018-01-19 16:26:26 -05:00

rendservice.h

Run our #else/#endif annotator on our source code.

2017-09-15 16:24:44 -04:00

rephist.c

Merge branch 'maint-0.3.0' into maint-0.3.1

2017-12-11 16:54:14 -05:00

rephist.h

Run our #else/#endif annotator on our source code.

2017-09-15 16:24:44 -04:00

replaycache.c

Run the copyright update script.

2017-03-15 16:13:17 -04:00

replaycache.h

Run our #else/#endif annotator on our source code.

2017-09-15 16:24:44 -04:00

router.c

Merge branch 'maint-0.3.0' into maint-0.3.1

2017-12-11 16:54:14 -05:00

router.h

Run our #else/#endif annotator on our source code.

2017-09-15 16:24:44 -04:00

routerkeys.c

When a tor_cert_T check fails, log the reason why.

2018-01-26 13:55:25 -05:00

routerkeys.h

Run our #else/#endif annotator on our source code.

2017-09-15 16:24:44 -04:00

routerlist.c

Merge branch 'maint-0.3.0' into maint-0.3.1

2017-12-11 16:51:58 -05:00

routerlist.h

Run our #else/#endif annotator on our source code.

2017-09-15 16:24:44 -04:00

routerparse.c

Merge branch 'scan-build-032'

2017-09-15 16:40:11 -04:00

routerparse.h

Run our #else/#endif annotator on our source code.

2017-09-15 16:24:44 -04:00

routerset.c

Refactor node lookup APIs to take flags

2017-08-22 19:13:40 -04:00

routerset.h

Run our #else/#endif annotator on our source code.

2017-09-15 16:24:44 -04:00

scheduler_kist.c

Merge remote-tracking branch 'dgoulet/bug24671_032_01' into maint-0.3.2

2017-12-21 11:13:33 -05:00

scheduler_vanilla.c

sched: only log when scheduler type changes

2017-09-22 08:51:22 -04:00

scheduler.c

Fix a wide comment

2017-11-17 09:57:15 -05:00

scheduler.h

sched: Implement SCHED_BUG()

2017-10-03 14:43:09 -04:00

shared_random_state.c

sr: Don't use a dynamic voting schedule

2017-10-27 09:23:37 -04:00

shared_random_state.h

sr: Don't use a dynamic voting schedule

2017-10-27 09:23:37 -04:00

shared_random.c

sr: Don't use a dynamic voting schedule

2017-10-27 09:23:37 -04:00

shared_random.h

Run our #else/#endif annotator on our source code.

2017-09-15 16:24:44 -04:00

statefile.c

Add test to make sure all confparse variables are well-typed

2017-09-26 12:24:04 -04:00

statefile.h

Run our #else/#endif annotator on our source code.

2017-09-15 16:24:44 -04:00

status.c

Run the copyright update script.

2017-03-15 16:13:17 -04:00

status.h

Run our #else/#endif annotator on our source code.

2017-09-15 16:24:44 -04:00

tor_main.c

Run the copyright update script.

2017-03-15 16:13:17 -04:00

torcert.c

When a tor_cert_T check fails, log the reason why.

2018-01-26 13:55:25 -05:00

torcert.h

When a tor_cert_T check fails, log the reason why.

2018-01-26 13:55:25 -05:00

transports.c

transport_new() cannot fail; do not check for it to fail.

2017-12-11 16:06:00 -05:00

transports.h

Run our #else/#endif annotator on our source code.

2017-09-15 16:24:44 -04:00