Nick Mathewson 39640728c3 Add comments to try to prevent recurrence of #31495. ...

There is a bad design choice in two of our configuration types,
where the empty string encodes a value that is not the same as the
default value.  This design choice, plus an implementation mistake,
meant that config_dup() did not preserve the value of routerset_t,
and thereby caused bug #31495.

This comment-only patch documents the two types with the problem,
and suggests that implementors try to avoid it in the future.

Closes ticket 31907.

2019-10-01 09:45:12 -04:00

..

api

Re-run "make autostyle" with improved annotate_ifdef_directives

2019-09-30 08:57:37 -04:00

client

Re-run "make autostyle" with improved annotate_ifdef_directives

2019-09-30 08:57:37 -04:00

control

feature/control: add a missing word to the send_control_done() comment

2019-09-24 15:08:37 +10:00

dirauth

Re-run "make autostyle" with improved annotate_ifdef_directives

2019-09-30 08:57:37 -04:00

dircache

Re-run "make autostyle" with improved annotate_ifdef_directives

2019-09-30 08:57:37 -04:00

dirclient

Run "make autostyle."

2019-06-05 09:33:35 -04:00

dircommon

Merge remote-tracking branch 'tor-github/pr/848' into maint-0.3.5

2019-08-12 09:38:46 +10:00

dirparse

Re-run "make autostyle" with improved annotate_ifdef_directives

2019-09-30 08:57:37 -04:00

hibernate

Run "make autostyle."

2019-06-05 09:33:35 -04:00

hs

Re-run "make autostyle" with improved annotate_ifdef_directives

2019-09-30 08:57:37 -04:00

hs_common

Run "make autostyle."

2019-06-05 09:33:35 -04:00

keymgt

Run "make autostyle."

2019-06-05 09:33:35 -04:00

nodelist

Add comments to try to prevent recurrence of #31495.

2019-10-01 09:45:12 -04:00

relay

Merge branch 'tor-github/pr/1346'

2019-09-30 13:56:51 +03:00

rend

fix typo in comment

2019-09-23 18:32:05 -04:00

stats

Run "make autostyle."

2019-06-05 09:33:35 -04:00