mirror of
https://gitlab.torproject.org/tpo/core/tor.git
synced 2024-12-06 19:41:15 +01:00
Nick Mathewson
884a0e269c
A comment by rransom on #8795 taken together with a comment by doorss recorded on #2077 suggest that *every* attempt to replace the md cache will fail on Vista/Win7 if we don't have the FILE_SHARE_DELETE flag passed to CreateFile, and if we try to replace the file ourselves before unmapping it. I'm adding the FILE_SHARE_DELETE, since that's this simplest fix. Broken indexers (the favored #2077 hypothesis) could still cause trouble here, but at least this patch should make us stop stepping on our own feet. Likely fix for #2077 and its numerous duplicates. Bugfix on 0.2.2.6-alpha, which first had a microdescriptor cache that would get replaced before remapping it.
8 lines
372 B
Plaintext
8 lines
372 B
Plaintext
o Major bugfixes (windows):
|
|
- Open files to be mapped with FILE_SHARE_DELETE so that we can
|
|
replace them before closing the mapping. This is a likely cause of
|
|
warnings and crashes when replacing the microdescriptor cache
|
|
file. Diagnosed based on comments by "doorss" and by Robert
|
|
Ransom. Possible fix for bug 2077; bugfix on 0.2.2.6-alpha.
|
|
|