George Kadianakis 248cbc2d22
statistics: Properly count all rendezvous cells (avoid undercounting). ...
tl;dr We were not counting cells flying from the client to the service, but we
were counting cells flying from the service to the client.
When a rendezvous cell arrives from the client to the RP, the RP forwards it to
the service.
For this to happen, the cell first passes through command_process_relay_cell()
which normally does the statistics counting. However because the `rend_circ`
circuit was not flagged with `circuit_carries_hs_traffic_stats` in
rend_mid_rendezvous(), the cell is not counted there.
Then the cell goes to circuit_receive_relay_cell() which has a special code
block based on `rend_splice` specifically for rendezvous cells, and the cell
gets directly passed to `rend_circ` via a direct call to
circuit_receive_relay_cell(). The cell never passes through
command_process_relay_cell() ever again and hence is never counted by our
rephist module.
The fix here is to flag the `rend_circ` circuit with
`circuit_carries_hs_traffic_stats` so that the cell is counted as soon as it
hits command_process_relay_cell().
Furthermore we avoid double-counting cells since the special code block of
circuit_receive_relay_cell() makes us count rendezvous cells only as they enter
the RP and not as they exit it.
Fixes #40117 .
2020-09-07 13:29:44 +03:00
2015-05-11 11:41:48 -04:00
2019-04-06 11:06:22 +10:00
2019-09-02 14:09:39 -04:00
2019-02-25 16:03:42 -06:00
2020-06-30 11:54:13 -04:00
2019-05-31 08:26:10 -04:00
2019-08-23 16:25:33 +10:00
2019-08-23 15:08:43 +10:00
2019-08-23 15:10:45 +10:00
2018-11-22 16:54:22 +10:00
2018-09-15 23:19:31 +00:00
2018-08-18 19:23:28 +00:00
2018-09-21 05:16:22 +00:00
2018-09-17 11:57:56 -04:00
2018-11-14 15:42:52 -05:00
2018-10-17 15:39:55 -05:00
2018-09-21 04:57:26 +00:00
2018-11-06 17:04:08 -05:00
2018-10-23 11:21:10 +10:00
2018-10-10 12:19:56 -04:00
2018-11-02 13:14:23 -04:00
2018-11-15 12:19:11 +10:00
2018-10-19 08:41:25 -04:00
2018-10-30 10:49:03 -04:00
2018-11-12 08:23:58 -05:00
2018-10-25 09:06:13 -04:00
2018-11-09 10:10:25 -05:00
2018-11-06 15:50:56 +01:00
2018-11-06 15:17:19 -05:00
2018-11-06 07:40:02 -05:00
2018-11-15 19:23:33 +10:00
2018-11-12 15:39:28 -05:00
2018-11-14 07:51:36 -05:00
2018-11-14 07:45:55 -05:00
2018-11-14 18:16:34 +10:00
2018-11-15 19:23:37 +10:00
2018-11-19 10:18:44 -05:00
2018-11-19 15:48:08 -06:00
2019-08-09 13:55:31 +10:00
2018-11-22 16:42:32 +10:00
2018-12-17 10:57:47 -05:00
2018-12-20 13:01:18 +10:00
2018-11-22 16:54:34 +10:00
2018-12-18 13:55:08 -05:00
2018-11-26 14:45:53 -05:00
2019-03-15 08:57:28 -04:00
2019-02-19 11:24:51 -05:00
2019-01-09 09:35:36 -05:00
2019-01-14 14:01:55 -05:00
2019-01-09 08:52:05 -05:00
2019-01-02 15:19:52 -05:00
2019-01-16 16:10:20 -05:00
2019-01-16 14:40:31 -05:00
2019-01-07 17:28:21 -06:00
2019-01-08 18:21:10 +10:00
2019-01-10 07:59:59 +10:00
2019-06-05 12:56:49 -07:00
2019-04-01 13:40:16 +10:00
2019-02-08 08:37:23 -05:00
2019-01-22 12:27:46 -05:00
2019-01-23 10:37:10 -05:00
2019-03-01 12:34:21 +10:00
2019-02-19 11:38:32 -05:00
2019-01-23 12:37:12 -05:00
2019-01-26 11:06:33 +02:00
2019-04-06 11:07:20 +10:00
2019-02-01 16:38:23 +01:00
2019-02-26 09:58:52 +10:00
2019-02-27 15:04:40 +10:00
2019-02-28 07:43:57 +10:00
2019-03-14 12:54:16 +02:00
2019-05-29 11:00:09 -04:00
2019-03-22 13:20:23 +10:00
2019-03-09 11:59:52 +10:00
2019-12-17 09:47:28 -05:00
2019-05-31 12:39:52 -04:00
2019-04-08 17:02:14 -04:00
2019-04-04 13:21:35 +10:00
2019-04-04 11:24:55 -04:00
2019-04-10 12:46:27 +03:00
2019-04-09 12:05:33 -04:00
2019-04-11 18:18:14 -04:00
2019-04-15 14:16:23 -04:00
2019-04-17 01:55:04 +02:00
2019-04-29 14:31:09 -04:00
2019-10-09 16:24:49 -04:00
2019-05-14 19:19:53 -04:00
2019-05-10 17:47:43 -04:00
2019-05-29 09:38:57 -04:00
2019-06-10 20:49:59 +10:00
2019-06-10 19:18:35 +10:00
2019-06-06 09:51:24 +10:00
2019-06-15 16:47:16 -04:00
2019-09-18 11:14:45 -04:00
2019-07-19 09:49:52 -04:00
2020-07-28 11:30:47 -04:00
2019-09-17 09:13:25 -04:00
2019-08-06 11:11:06 -04:00
2019-09-24 11:06:20 +10:00
2019-08-22 22:09:32 +10:00
2019-08-30 21:51:11 +10:00
2019-09-06 16:43:14 +10:00
2019-10-20 20:09:35 +10:00
2019-09-30 15:14:21 +10:00
2019-10-04 12:33:34 +10:00
2019-11-11 13:19:15 +10:00
2020-02-12 12:21:41 +10:00
2020-01-06 09:37:12 -05:00
2020-03-11 10:35:17 -04:00
2020-01-29 08:31:22 -05:00
2020-07-06 16:19:16 -04:00
2020-03-20 14:48:31 +10:00
2020-05-06 16:58:06 -04:00
2020-05-30 02:20:48 -04:00
2020-07-07 15:05:38 -04:00
2020-07-30 14:24:25 -04:00
2020-08-12 14:25:46 -04:00
2020-09-07 13:29:44 +03:00
2019-06-12 08:55:38 -04:00
2019-03-26 12:24:45 +10:00
2019-08-08 22:46:51 +10:00
2018-11-11 11:25:59 +01:00
2018-12-05 21:02:39 +01:00
2019-01-07 09:00:29 +01:00
2019-02-12 14:40:42 +01:00
2019-03-06 11:45:27 +01:00
2019-04-03 09:26:28 +02:00
2019-05-17 08:52:13 +02:00
2019-06-11 16:12:50 +02:00
2019-10-02 11:11:27 +02:00
2019-11-09 10:10:19 +01:00
2019-12-06 11:50:35 +01:00
2018-10-30 08:45:37 -04:00
2018-11-30 12:16:18 -05:00
2018-12-11 10:00:19 -05:00
2018-10-18 12:56:51 -04:00
2018-09-25 18:43:23 +00:00
2018-10-22 16:34:41 -04:00
2018-10-29 15:18:07 -04:00
2018-10-18 11:46:07 -04:00
2018-10-30 11:28:53 -04:00
2018-11-05 11:49:19 +10:00
2018-11-15 14:36:39 -05:00
2018-12-01 11:18:03 -05:00
2018-12-04 18:49:19 +02:00
2018-11-05 16:21:58 +10:00
2018-11-15 21:04:17 +10:00
2018-11-27 14:53:50 +01:00
2019-01-16 15:47:33 -05:00
2018-12-04 14:34:04 -05:00
2019-06-28 21:38:33 +10:00
2018-12-13 11:26:09 -05:00
2019-01-03 09:45:43 -05:00
2018-12-17 09:15:37 -05:00
2018-12-18 13:52:25 -05:00
2018-12-17 09:53:17 -05:00
2018-12-21 11:25:23 -05:00
2019-01-02 16:09:10 -05:00
2019-10-24 08:50:01 -04:00
2019-01-03 09:00:47 -05:00
2020-02-12 14:09:40 +10:00
2019-02-08 08:52:46 -05:00
2019-01-23 12:04:57 -05:00
2019-02-21 10:07:34 -05:00
2019-02-08 10:43:38 -05:00
2019-05-17 10:03:41 -04:00
2019-04-10 19:03:43 +10:00
2019-03-21 12:00:45 +10:00
2019-04-01 14:08:24 +10:00
2019-04-12 08:38:30 -04:00
2019-04-30 09:15:35 +03:00
2019-04-22 11:48:07 +10:00
2019-05-20 08:56:34 -04:00
2019-05-28 10:20:36 +10:00
2019-05-30 20:05:03 +10:00
2019-09-30 23:58:38 +10:00
2019-06-19 07:40:05 -04:00
2019-09-23 15:08:34 -04:00
2019-09-23 15:05:08 -04:00
2019-08-08 11:44:19 -04:00
2019-08-15 08:20:47 -04:00
2019-09-18 15:38:33 -04:00
2019-10-07 10:20:09 -04:00
2019-08-29 21:56:16 +10:00
2019-09-09 17:07:08 -04:00
2019-09-10 10:55:44 -04:00
2019-09-10 11:07:25 -04:00
2019-09-30 23:58:38 +10:00
2019-10-25 09:53:11 +10:00
2019-10-17 10:11:32 -04:00
2019-10-20 22:04:08 +10:00
2019-12-16 09:06:25 +10:00
2019-10-24 11:44:43 +10:00
2019-10-24 09:26:54 +10:00
2019-11-06 11:33:23 -05:00
2019-12-03 12:42:39 +10:00
2019-12-06 10:51:43 +10:00
2020-03-16 16:04:51 +10:00
2020-01-28 19:56:56 +10:00
2020-02-05 12:02:32 -05:00
2020-02-13 13:52:41 +10:00
2020-02-13 13:43:59 +10:00
2020-02-10 13:32:09 -05:00
2020-03-12 12:43:00 -04:00
2020-03-10 14:45:13 -04:00
2020-03-19 18:36:36 -04:00
2020-03-19 18:36:36 -04:00
2020-07-07 09:53:54 -04:00
2020-07-23 10:08:42 -04:00
2020-03-17 11:44:45 -04:00
George Kadianakis
248cbc2d22