772ce9d085
Fix compile on Snow Leopard
2009-09-20 23:17:00 -04:00
93b33e15ab
Fix build warnings on OSX 10.5.8
2009-09-20 23:01:43 -04:00
134266b984
Change the condition on the nonlive timeout counting.
...
Try to clarify things in the comment too.
2009-09-20 18:20:10 -07:00
e2cc4e353a
Add a couple of time helper functions.
...
Also add rounding support to tv_mdiff().
2009-09-20 18:03:39 -07:00
cf2afcd707
Fix typos and comments, plus two bugs
...
A) We were considering a circuit had timed out in the special cases
where we close rendezvous circuits because the final rendezvous
circuit couldn't be built in time.
B) We were looking at the wrong timestamp_created when considering
a timeout.
2009-09-20 19:50:44 -04:00
f39bedf250
Implement and document new network liveness algorithm.
...
Based on irc discussion with arma.
2009-09-20 14:51:30 -07:00
6700e528be
Fix some precision-related asserts in unit tests.
...
Mostly by storing the timeout as milliseconds and not seconds
internally.
2009-09-20 14:43:45 -07:00
cc53e7cb0e
disable the end of circuitbuildtimeout units tests
...
until mike figures out some other way to make them pass reliably
2009-09-18 02:00:20 -04:00
335b67a354
Fix compile on freebsd
2009-09-18 02:43:45 +02:00
67f280feb3
Let our config abbreviations rewrite more than once
2009-09-17 20:32:42 -04:00
b02b11c4b4
a mish-mash of stuff in my sandbox
2009-09-17 01:58:39 -04:00
ee89061ef2
give proposal 151 a changelog and other touchups
2009-09-17 01:42:33 -04:00
feccaa5c83
Choose early circuit idle timeout better.
...
Don't discard all circuits every MaxCircuitDirtiness, because the
user might legitimately have set that to a very lower number.
Also don't use up all of our idle circuits with testing circuits,
since that defeats the point of preemptive circuits.
2009-09-17 01:41:47 -04:00
4b10ba484b
Merge commit 'origin/maint-0.2.1'
2009-09-17 00:42:41 -04:00
9c38941195
Work around a memory leak in openssl 0.9.8g (and maybe others)
2009-09-17 00:01:20 -04:00
b3991ea7d1
Merge commit 'karsten/fix-1073' into maint-0.2.1
2009-09-16 23:36:01 -04:00
4850a3a75f
Merge commit 'mikeperry/circuitbuildtimeout-final'
2009-09-16 21:43:31 -04:00
43c18746bd
Clarify use of magic number 0.98 with #define.
2009-09-16 18:41:22 -07:00
926ca5befd
Merge branch 'maint-0.2.1'
2009-09-16 21:28:49 -04:00
7d838971dd
Merge commit 'karsten/no-time-maint-0.2.1'
2009-09-16 20:45:01 -04:00
9eb5edc093
Merge commit 'sebastian/specconformance'
2009-09-16 20:37:43 -04:00
1aac7de1ea
Fix unit tests and compile issues on Snow Leopard
2009-09-16 17:22:21 -07:00
e2c2fa7a1f
Change liveness value to be a function of the timeout.
...
And also the number of recent circuits used to decide
when the network changes.
2009-09-16 17:20:34 -07:00
e4e0ce94f0
Add log message so we have accurate build time values.
2009-09-16 17:20:34 -07:00
5bd60d8a41
Address nickm's issues from his review #1 .
2009-09-16 17:20:29 -07:00
0352d43917
Move circuitbuildtimeout config check.
...
We want it to be under our control so it doesn't mess
up initialization. This is likely the cause for
the bug the previous assert-adding commit (09a75ad
2009-09-16 15:58:42 -07:00
09a75ad316
Time for some debugging by asserts.
...
Got a negative timeout value on startup. Need to narrow it down.
2009-09-16 15:55:51 -07:00
742e08046f
Fix bugs relating to not counting timeouts as circuit builds.
...
Also use bin midpoints for time values.
2009-09-16 15:55:51 -07:00
67cee75ca2
Document functions and constants.
2009-09-16 15:55:50 -07:00
c9363df09f
Remove an assert.
...
It seems to fire because of precision issues. Added
more debug info to the warn to try to figure out for sure.
2009-09-16 15:55:50 -07:00
63be2df84f
Fix issues found by arma in review.
2009-09-16 15:55:36 -07:00
672e2f6908
space/indent cleanups, plus point out three bugs
2009-09-16 15:55:32 -07:00
4b3bc714a3
Woops. Fix a couple memory leaks.
...
Also change the max timeout quantile to 0.98, so we can
avoid huge synthetic timeout values.
2009-09-16 15:54:37 -07:00
b508e4748f
Remove trailing spaces. As if bytes were free...
...
Also correct some typos.
2009-09-16 15:52:05 -07:00
535423a3bb
Resolve mode ties in favor of the higher (slower) mode.
2009-09-16 15:52:04 -07:00
8210336182
More detail for some log msgs.
2009-09-16 15:52:04 -07:00
6eba08e22f
Use our variable directly for timeout.
...
Using CircuitBuildTimeout is prone to issues with SIGHUP, etc.
Also, shuffle the circuit build times array after loading it
in so that newer measurements don't replace chunks of
similarly timed measurements.
2009-09-16 15:52:04 -07:00
fca8446949
Fix a couple of assert bugs.
2009-09-16 15:52:03 -07:00
c4e6b3eadb
Fix timeout edge case when we get enough samples.
...
Also switch Xm calculation to mode, not min.
2009-09-16 15:52:03 -07:00
95735e5478
Fix the math.h log() conflict.
...
It was compiling, but causing segfaults.
Also, adjust when the timer starts for new test circs
and save state every 25 circuits.
2009-09-16 15:51:17 -07:00
7ac9a66c8f
Recover from changing network connections.
...
Also add code to keep creating circuits every minute until we
hit our minimum threshhold.
2009-09-16 15:51:16 -07:00
411b60325b
Factor out the pretimeout handling code.
...
We need to also call it if we're going to calculate alpha
after a normal circuit build.
2009-09-16 15:51:15 -07:00
b52bce91fc
Write unit tests and fix issues they uncovered.
2009-09-16 15:51:10 -07:00
04414830fe
Implement the pareto fitting and timeout calculating bits.
2009-09-16 15:48:52 -07:00
7750bee21d
Clean up Fallon's partially complete GSoC project.
...
The code actually isn't that bad. It's a shame she didn't finish.
Using it as the base for this feature.
2009-09-16 15:48:51 -07:00
2dbf5b7741
Merge branch 'tmp'
2009-09-16 17:18:35 -04:00
dc3229313b
Teach connection_ap_can_use_exit about Exclude*Nodes
...
To further attempt to fix bug 1090, make sure connection_ap_can_use_exit
always returns 0 when the chosen exit router is excluded. This should fix
bug1090.
2009-09-16 02:29:57 +02:00
ed7283d283
Merge commit 'origin/maint-0.2.1'
...
Resolved conflicts in:
src/or/circuitbuild.c
2009-09-15 19:37:26 -04:00
24c740e5fd
Merge commit 'sebastian/memleak' into maint-0.2.1
2009-09-15 19:35:16 -04:00
113ba0e727
make some bug 1090 warnings go away
...
When we excluded some Exits, we were sometimes warning the user that we
were going to use the node regardless. Many of those warnings were in
fact bogus, because the relay in question was not used to connect to
the outside world.
Based on patch by Rotor, thanks!
2009-09-16 01:17:51 +02:00
Sebastian Hahn
Nick Mathewson
Mike Perry
Roger Dingledine
Karsten Loesing