torproject/tor
1
0
Fork 0
mirror of https://gitlab.torproject.org/tpo/core/tor.git synced 2024-12-06 19:41:15 +01:00
Code Issues Actions Packages Projects Releases Wiki Activity
26,778 Commits 53 Branches 631 Tags
ca8e9813bf125d68d64228d1bb39a170ae6ea16b
Commit Graph

3991 Commits

Author SHA1 Message Date
Nick Mathewson 15b41fa6ae Make sandbox.c compile when libseccomp-dev is installed on arm64 
Fixes ticket 24424.  Patch from weasel.
 2017-12-12 19:46:03 -05:00
Nick Mathewson 418d8bbe92 Merge branch 'stack_fixes_032_v2' into maint-0.3.2 2017-12-11 16:25:04 -05:00
Nick Mathewson 3da15bcbe8 Stop checking for sandbox:new_element() failures: it can't fail. 
(It can't fail because the tor_malloc*() family of functions can
never return NULL)

Found with STACK
 2017-12-11 16:06:25 -05:00
Nick Mathewson 779e4b9dcf Tweaks to strings in 24500 2017-12-05 12:09:57 -05:00
Fernando Fernandez Mancera 313360e6e6 Make errno error log more useful for getrandom() 
Making errno error log more useful for getrandom() call. Adding if statement to
make difference between ENOSYS and other errors.

Fixes #24500

Signed-off-by: Fernando Fernandez Mancera <ffernandezmancera@gmail.com>
 2017-12-05 12:05:09 -05:00
Nick Mathewson fd73a168ca Merge branch 'maint-0.3.1' into maint-0.3.2 2017-11-30 12:07:59 -05:00
Nick Mathewson ee48eb1eb5 Merge branch 'maint-0.3.0' into maint-0.3.1 2017-11-30 12:07:59 -05:00
Nick Mathewson 5fc0587c04 Merge branch 'maint-0.2.9' into maint-0.3.0 2017-11-30 12:07:59 -05:00
Nick Mathewson 7e2b012b46 Merge branch 'maint-0.2.8' into maint-0.2.9 2017-11-30 12:07:59 -05:00
Nick Mathewson ba4a9cf0c0 Merge branch 'maint-0.2.5' into maint-0.2.8 2017-11-30 12:07:59 -05:00
Nick Mathewson 1880a6a88e Avoid asking for passphrase on junky PEM input 
Fixes bug 24246 and TROVE-2017-011.

This bug is so old, it's in Matej's code.  Seems to have been
introduced with e01522bbed.
 2017-11-27 15:25:03 -05:00
Nick Mathewson ba94dc28e8 Merge branches 'bug24099_031' and 'bug24086_031' into maint-0.3.2 2017-11-21 12:37:46 -05:00
Nick Mathewson 846df5b3cd Merge remote-tracking branches 'public/ticket24315_029' and 'public/bug24198_029' into maint-0.3.2 2017-11-20 13:20:25 -05:00
Nick Mathewson cabcb752d7 In storagedir, take more care with errno on empty or mislabeled file 
Required for 24099 fix -- we won't be able to act based on errno
unless we can trust it.
 2017-11-20 10:10:13 -05:00
Nick Mathewson 2d3904aba6 Check the libc version to decide whether to allow openat. 2017-11-16 14:06:38 -05:00
Nick Mathewson d2d6a1b082 Make our seccomp2 sandbox handle Glibc 2.26 
There are three changes here:
  * We need to allow epoll_pwait.
  * We need to allow PF_NETLINK sockets to be opened with SOCK_CLOEXEC.
  * We need to use openat() instead of open().

Note that this fix is not complete, since the openat() change is
turned off.  The next commit will make the openat() change happen
when we're running glibc 2.26 or later.

Fix for 24315.
 2017-11-16 13:56:22 -05:00
Nick Mathewson 7461cd3067 Permit kill(pid, 0) in the seccomp2 sandbox. 
We don't want to allow general signals to be sent, but there's no
problem sending a kill(0) to probe whether a process is there.

Fixes bug 24198; bugfix on 0.2.5.1-alpha when the seccomp2 sandbox
was introduced.
 2017-11-16 12:44:47 -05:00
Nick Mathewson b0ddaac074 Make some assertions nonfatal to help prevent bug23690 recurrence. 2017-09-29 10:29:33 -04:00
Alexander Færøy 8d6940814a Better error handling when trying to compress/decompress into empty buffer. 
This patch ensures that we return TOR_COMPRESS_BUFFER_FULL in case we
have a input bytes left to process, but are out of output buffer or in
case we need to finish where the compression implementation might need
to write an epilogue.

See: https://bugs.torproject.org/23551
 2017-09-28 20:17:41 +02:00
Alexander Færøy 44dc4b73ec Better error handling when trying to compress/decompress into empty buffer. 
This patch ensures that we return TOR_COMPRESS_BUFFER_FULL in case we
have a input bytes left to process, but are out of output buffer or in
case we need to finish where the compression implementation might need
to write an epilogue.

See: https://bugs.torproject.org/23551
 2017-09-28 18:58:15 +02:00
Alexander Færøy c3b7f9d762 Fix whitespace issue in compress.c 2017-09-28 18:58:15 +02:00
Alexander Færøy a196fdb622 Fix typo in buffers.c. 2017-09-28 18:58:09 +02:00
Nick Mathewson 3a073c463d Improve unit test coverage for compression code. 
These tests try uncompressing garbage, verify that we won't
make compression bombs, and verify that we won't uncompress
compression bombs.
 2017-09-28 12:20:02 -04:00
Nick Mathewson 14614a592e Fix spelling: compressing, not compresing 2017-09-28 12:17:34 -04:00
Nick Mathewson 55873107d0 Correct docs for config_lines_dup_and_filter 2017-09-28 09:40:04 -04:00
Nick Mathewson a64d79ca4c Move around some LCOV_EXCLs in src/common 
Apparently, my compiler now generates coverage markers for
label-only lines, so we need to exclude those too if they are meant
to be unreachable.
 2017-09-28 09:25:17 -04:00
Nick Mathewson 01d67a9071 Note an unreachable (?) section in buffers.c 2017-09-28 08:35:24 -04:00
Nick Mathewson ff0aabc35d Merge branch 'maint-0.3.1' 2017-09-20 09:45:07 -04:00
Andreas Stieger 427c2cc9e8 in zstd compression, fix 32 bit build 
format '%lu' expects argument of type 'long unsigned int', but argument ... has type 'size_t'

Closes ticket 23568.
 2017-09-20 09:43:08 -04:00
David Goulet 5dea4b565f Add a BASE32_DIGEST_LEN define 
Use this value instead of hardcoded values of 32 everywhere. This also
addresses the use of REND_DESC_ID_V2_LEN_BASE32 in
hs_lookup_last_hid_serv_request() for the HSDir encoded identity digest length
which is accurate but semantically wrong.

Fixes #23305.

Signed-off-by: David Goulet <dgoulet@torproject.org>
 2017-09-19 12:33:04 -04:00
Nick Mathewson 76c33f7ff4 Merge branch 'scan-build-032' 2017-09-15 16:40:11 -04:00
Nick Mathewson c1deabd3b0 Run our #else/#endif annotator on our source code. 2017-09-15 16:24:44 -04:00
Nick Mathewson 7a597718bb Split some long #if lines to make the #endif annotator happy 2017-09-15 16:24:21 -04:00
Nick Mathewson 9201e4c74b Merge branch 'bug23487_029' 2017-09-15 14:27:58 -04:00
Nick Mathewson 75659fd548 Use different variable names for pw_uid usages 
Catalyst points out that using pw_uid for two different purposes
here is likely to be confusing.
 2017-09-15 14:26:59 -04:00
Nick Mathewson 0f4f40b70f Merge remote-tracking branch 'dgoulet/ticket12541_032_02' 2017-09-15 12:00:50 -04:00
David Goulet 6e598bbcd8 sched: Add sandbox support for KIST 
Signed-off-by: David Goulet <dgoulet@torproject.org>
 2017-09-15 11:40:59 -04:00
teor 42e7d0ea14 Explain the restrictions on divisor in round*_to_next_multiple_of 
Closes 23528.
 2017-09-15 16:06:17 +10:00
Nick Mathewson 4ff170d7b1 Fix warnings about passing uninitialized buffers into functions 
Most of these buffers were never actually inspected, but it's still
bad style.
 2017-09-12 21:32:42 -04:00
Nick Mathewson f2f729e26b Clear up dead-assignment warnings from scan-build 2017-09-12 21:32:34 -04:00
Nick Mathewson a4847ffa91 clang scan-build: Fix "dead increment" warnings. 
For the most part, these indicated a spot where the code could have
been better.
 2017-09-12 19:03:04 -04:00
Nick Mathewson 7ee486c15f Log correctly on owner/user mismatch. 
Found with clang's scan-build while looking at dead assignments.

Fixes bug 23487; bugfix on 1135405c8c in 0.2.9.1-alpha
 2017-09-12 17:37:25 -04:00
Nick Mathewson 0729ba2868 Merge branch 'maint-0.2.9' into maint-0.3.0 2017-09-12 09:23:57 -04:00
Nick Mathewson bac160b4e0 One more implicit fallthrough warning to fix on GCC 7 2017-09-12 09:22:50 -04:00
Nick Mathewson c894e9d3d4 Merge branch 'maint-0.2.9' into maint-0.3.0 2017-09-11 16:29:10 -04:00
Nick Mathewson 6a49e3360b Fix mixed-sign comparison warning in fix for 22797. 2017-09-11 16:29:06 -04:00
Nick Mathewson a25d97e530 Merge branch 'teor-bug22797-025' into maint-0.2.9 2017-09-11 16:28:59 -04:00
Nick Mathewson 52c40330c8 Merge branch 'maint-0.3.1' 2017-09-11 13:49:20 -04:00
Nick Mathewson 72ea4a8f08 Extract the important parts of the run-pending-timers function. 
Our unit tests will need this, so that they can simulate advancing
time without getting libevent involved.
 2017-09-11 13:48:39 -04:00
Nick Mathewson c151f46445 Merge branch 'ticket20119' 2017-09-08 08:56:53 -04:00