9871fcbcd9
Use #warning instead of #warn: one is C and one isn't.
2019-10-22 09:24:25 -04:00
ded6d9fcb4
Run test_operator_cleanup on our unit tests
...
Coccinelle doesn't understand it when we use "==" and "!=" and so on as
arguments to macros. To solve this, we prefer OP_EQ, OP_NE, and so
on.
This commit is automatically generated by running
./scripts/coccinelle/test_operator_cleanup over all of the source
code in src.
2019-09-11 18:47:19 -04:00
41261c3b5c
Merge branch 'tor-github/pr/1296'
2019-09-11 09:42:31 -04:00
478141e617
Document inconsistent usage of config_var_is_listable()
...
See also ticket 31654.
2019-09-11 09:42:19 -04:00
e61bfd0bfd
Extract common list of flags to use for obsolete variables.
2019-09-11 09:42:19 -04:00
fe5033d3b0
Clarify documentation on config_var_is_listable()
...
Here we make it clear we're only looking at listable variable names,
not at whether the variables themselves are gettable.
Also, remove an extraneous h.
(This commit is not a fixup, because of rebase conflicts.)
2019-09-11 09:42:19 -04:00
14f48cb083
Add test_cmdline.sh to distribution.
2019-09-11 09:42:19 -04:00
7a8ea0d3c3
integration test for --list-torrc-options
...
(This option tests our existing behavior, not necessarily the most
sensible behavior.)
2019-09-11 09:42:19 -04:00
5ffe6ec0e3
Test: Make sure NOLIST options are not listed.
2019-09-11 09:42:19 -04:00
bbd40e690e
Revise documentation on CFLG_* flags
2019-09-11 09:42:19 -04:00
0d6d96396c
Remove all CVFLAG_* usage.
2019-09-11 09:42:19 -04:00
5ca5d196ac
Remove all VTFLAG_* usage.
2019-09-11 09:42:19 -04:00
9b571d4729
confparse, conftypes: Replace flags with their new names.
...
The old names remain as #defines that cause variables to get one or
more flags.
Now every flag-testing function in confparse.c tests exactly one flag.
2019-09-11 09:42:19 -04:00
1b3b6d9f2d
Replace low-level {var_type,struct_var}_is_*() with flag inspection
...
Since the flags are now stored with compatible numbering, we can
just OR them together and see whether the flag we want is in the
result.
(Net code removal!)
2019-09-11 09:42:19 -04:00
4b92f4c83a
Re-number VTFLAG_* values so they don't conflict with CVFLAG_*
2019-09-11 09:42:19 -04:00
c650ab8061
Move VTFLAG_* declarations to conftypes.h
2019-09-11 09:42:19 -04:00
03e4183043
typed_var: Make flags into an unsigned OR of bits.
...
Using a bitfield here will enable us to unify the var_type_def_t flags
with the config_var_t flags.
(This commit does not yet do that unification, and does not yet
rename or refactor any flags. It only changes booleans into bits.)
2019-09-11 09:42:19 -04:00
4f6b592691
struct_var: refactor struct_var_is*() functions to delegate
...
Previously they checked the individual flags inside var_type_def_t;
now they call the appropriate var_type_is_*() functions.
(These functions will be removed entirely by the end of this branch.)
2019-09-11 09:42:19 -04:00
7171ce2a2a
config: make config_var_is_dumpable static.
2019-09-11 09:42:19 -04:00
8d685aee7c
config: rename "contained" to "derived", and explain it better.
...
Don't use "derived" directly, but check its implications for listing
and copying.
2019-09-11 09:42:19 -04:00
668e3a7709
config: Introduce the concept of an "ungettable" variable.
...
We had though to make all obsolete and invisible variables
ungettable, so that GETCONF would reject them. But it turns out
that this isn't the current behavior of GETCONF with those
variables. So for now, I'm leaving the current behavior unchanged.
(See ticket 31647 for a proposal to change the behavior.)
2019-09-11 09:42:19 -04:00
3bf38ffff5
Document config_var_is_dumpable and config_var_is_settable.
2019-09-11 09:42:19 -04:00
049705fc1c
Merge branch 'tor-github/pr/1311'
2019-09-11 09:36:28 -04:00
3b32f2508c
Merge branch 'tor-github/pr/1307'
2019-09-11 16:19:21 +03:00
39c7f46d36
main: add some newlines to the subsystem list, for readability
2019-09-10 09:06:36 +10:00
5fa75a6cd4
main: remove level number comments from the subsystem list (master)
...
Part of 31615.
2019-09-10 09:04:38 +10:00
987768b077
Merge branch 'bug31615_041' into bug31615_master
...
Merged modified lines from bug31615_041, and unmodified lines
from master.
2019-09-10 09:03:37 +10:00
f1c57cd1e5
main: remove level number comments from the subsystem list (0.4.1)
...
Part of 31615.
2019-09-10 08:44:35 +10:00
7e22d99346
Merge branch 'bug31615_040' into bug31615_041
...
Merged modified lines from bug31615_040, and unmodified lines
from maint-0.4.1.
2019-09-10 08:43:13 +10:00
2e2a35b694
main: remove level number comments from the subsystem list (0.4.0)
...
These levels get out of date really easily: we'll implement a level
dump command in tor in 31614.
They also cause conflicts and inconsistencies when merging forward
level changes.
Part of 31615.
2019-09-10 08:35:56 +10:00
409df19b5a
build: The <sys/sysctl.h> is now deprecated on Linux
...
Closes #31673
2019-09-09 17:07:08 -04:00
6846d14868
Merge branch 'ticket30924_042_04_squashed_merged'
2019-09-09 12:35:27 -04:00
a642a4cbd7
Merge branch 'ticket30924_042_04_squashed' into ticket30924_042_04_squashed_merged
2019-09-09 11:10:53 -04:00
622c2c7884
hs-v3: Rename validation function in hs_intropoint.c
...
Signed-off-by: David Goulet <dgoulet@torproject.org >
2019-09-09 11:07:51 -04:00
385f6bcfcc
hs-v3: Move DoS parameter check against 0
...
Move it outside of the validation function since 0 is a valid value but
disables defenses.
Signed-off-by: David Goulet <dgoulet@torproject.org >
2019-09-09 11:07:36 -04:00
f16fc262e5
Merge branch 'tor-github/pr/1298'
2019-09-09 11:05:51 -04:00
1e7c7870e8
Merge branch 'tor-github/pr/1287'
2019-09-09 10:51:19 -04:00
612b0a4139
subsys: Make the subsystem init order match the module dependencies
...
Fix levels for subsystems that depend on log/err
* winprocess (security) doesn't use err:
* call windows process security APIs as early as possible
* init err after winprocess
* move wallclock so it's still after err
* network and time depend on log:
* make sure that network and time can use logging.
* init network and time after log
Add comments explaining the module init order.
Fixes bug 31615; bugfix on 0.4.0.1-alpha.
2019-09-06 16:58:53 +10:00
a727d4a3a1
Remove unused struct_var_* functions.
...
These turned out to be unnecessary, so let's not keep them around
and let them start getting complicated.
Closes ticket 31630.
2019-09-05 15:24:54 -04:00
16cf9424c1
config: Invert sense of _is_invisible, and rename to is_listable()
2019-09-05 11:32:32 -04:00
22e7d33735
config: replace config_var_is_cumulative with is_replaced_on_set()
...
This change replaces the higher-level property check to match our
intended flag factoring.
2019-09-05 11:32:32 -04:00
545c21e23d
Merge branch 'tor-github/pr/1295'
2019-09-05 17:13:29 +03:00
ddd01541b9
Merge branch 'tor-github/pr/1294'
2019-09-05 17:12:19 +03:00
fb56b4c2bf
Merge branch 'tor-github/pr/1293'
2019-09-05 17:10:07 +03:00
c750ec20ab
Merge branch 'tor-github/pr/1291'
2019-09-05 17:09:20 +03:00
c29f05b159
Merge branch 'tor-github/pr/1292'
2019-09-05 17:06:58 +03:00
cdd7e88970
Merge branch 'tor-github/pr/1261'
2019-09-05 17:02:53 +03:00
0127888b06
Add tests for IPv6 exit policies on microdescriptors
2019-09-05 17:02:45 +03:00
be4a60945d
Check IPv6 exit policies on microdescriptors in node_exit_policy_rejects_all()
2019-09-05 17:02:45 +03:00
eb909c4e43
config: note that some arguments are required.
2019-09-05 07:57:36 -04:00
Nick Mathewson
David Goulet
George Kadianakis
teor
Neel Chauhan