fdd6352506
hs-v3: Report introduction failure SOCKS ExtendedErrors
...
Signed-off-by: David Goulet <dgoulet@torproject.org >
2020-04-08 07:56:54 -04:00
1720a2191d
address: Simplify tor_addr_is_valid()
...
And rewrite the function comment.
Part of 33679.
2020-04-07 23:11:17 +05:30
cbd3f88831
Added tests for tor_addr_is_null/valid()
...
Added tests for tor_addr_is_valid(),
and added tests for tor_addr_is_null(),
which is not modfied.
Ticket 33679
2020-04-07 23:11:17 +05:30
6fbf624b50
hs-v3: Fix typo in log info when PublishHidServDescriptors is set to 0
...
Fixes #33779
Signed-off-by: David Goulet <dgoulet@torproject.org >
2020-04-07 13:17:21 -04:00
065ccda4f6
Merge branch 'pr1838_squashed'
2020-04-07 17:36:17 +10:00
ea9ff58921
Try rewriting normalize_srcdir to normalize harder.
2020-04-07 17:36:05 +10:00
d3db84c1e7
Make check_subsystem_order work in distcheck builds.
2020-04-07 17:36:02 +10:00
5f49695f94
Make check_subsystem_order work in out-of-tree builds.
2020-04-07 17:35:58 +10:00
f9c57313d0
add changes file for 31634
2020-04-07 17:35:55 +10:00
9b434b79ce
Add a test script to check subsystem order as part of make check.
2020-04-07 17:35:51 +10:00
00ce25a720
channel: Fix a comment typo
2020-04-06 19:10:30 +10:00
6df16022a1
channel: Remove a newline at the start of the file
2020-04-06 19:08:33 +10:00
7adf72f1b4
Merge branch 'maint-0.4.3'
2020-04-05 17:17:51 +10:00
80a306c6e7
doc: Fix another man page typo
...
The default value of the option is "auto", not "default".
2020-04-05 17:17:03 +10:00
5c35bb38df
Merge branch 'maint-0.4.3'
2020-04-05 17:12:11 +10:00
613077229f
doc: Fix a typo in the man page
...
"proceeding" means starting an action.
"preceding" means the thing before this thing.
In this context, it's a bit ambiguous.
2020-04-05 17:10:37 +10:00
1e75974362
core/or: Fix a comment typo in onion.h
...
Comment-only change.
2020-04-04 15:05:34 +10:00
a84fd949ed
Merge branch 'maint-0.4.3'
2020-04-04 13:23:56 +10:00
b1e1c6b505
changes: file for ticket 33782
...
Avoid conflicts between the fake sockets in tor's unit tests, and real
file descriptors. Resolves issues running unit tests with GitHub
Actions, where the process that embeds or launches the tests has
already opened a large number of file descriptors.
Fixes bug 33782; bugfix on 0.2.8.1-alpha.
Found and fixed by Putta Khunchalee.
2020-04-04 13:20:06 +10:00
c0fe88b236
doc: Also stop running practracker in hooks
...
When making a new maint branch, stop running practracker in hooks.
2020-04-03 22:10:01 +10:00
6db2e59f20
doc: Minor restructure for Release Lifecycle
...
* make end and beginning of life into second-level sections
* write an intro for beginning
* tweak intro for end
2020-04-03 22:06:27 +10:00
0f10ddaa29
Re-apply: doc: Replace "underline" with "## Section name".
...
Re-applying changes after merge.
2020-04-03 22:02:11 +10:00
0efcdb8918
Merge remote-tracking branch 'tor-github/pr/1739'
...
Ignored conflicting style changes: they will be re-applied in
the next commit.
2020-04-03 21:59:19 +10:00
f43a841d94
Change starting file descriptor for tests.
2020-04-03 16:47:38 +07:00
a762234ba2
scripts: Ignore editor temporary files
...
Ignore editor temporary files when autostyling in:
* rectify_include_paths.py
* rename_c_identifier.py
Obviously correct changes to already-reviewed code.
2020-04-03 19:16:57 +10:00
442e0caea2
Merge branch 'maint-0.4.3'
2020-04-03 14:44:34 +10:00
7d2b6cacee
doc: Rewrite the approved-routers man page entry
...
Obviously correct documentation changes.
2020-04-03 14:43:48 +10:00
6fbb9af96c
Merge branch 'tor-github/pr/1851'
2020-04-02 02:38:11 +03:00
a8a92b9456
Merge branch 'maint-0.4.3'
2020-04-01 23:03:51 +10:00
6c5c503a4c
configure: Fix enabled module variable expansion
...
Fixes #33646
Signed-off-by: David Goulet <dgoulet@torproject.org >
2020-04-01 23:02:24 +10:00
eecf6c5199
hs-v3: Move to log notice the registration of an OB instance
...
This is to allow a visual feedback in the logs for operators setting up Onion
Balance so they can confirm they properly configured the instances.
Signed-off-by: David Goulet <dgoulet@torproject.org >
2020-04-01 08:31:20 -04:00
b5412d12f9
Merge branch 'tor-github/pr/1844'
2020-04-01 08:22:36 -04:00
cc5319bf8e
Updated the TestingTorNetwork man page options
...
Updated 'doc/tor.1.txt' to match 'src/app/config/testnet.inc'.
2020-04-01 01:00:09 -04:00
f863954f1e
Move LOG_PROTOCOL_WARN to app/config.h
...
LOG_PROTOCOL_WARN was in core/or.h, but the function it depends on is in
app/config.h. Put them in the same header, to reduce dependencies.
Part of 33633.
2020-04-01 09:17:18 +10:00
8fda94f944
hs-v3: Move ob_subcreds to hs_service_state_t.
...
It's more natural there since it's runtime state.
2020-03-30 23:37:26 +03:00
0667a5af8d
hs-v3: Don't crash after SIGHUP in Onionbalance backend mode.
...
The ob_subcreds array was not copied after SIGHUP, and that left the
post-SIGHUP service with a NULL ob_subcreds pointer (until the next descriptor
gets build where we regenerate ob_subcreds in hs_ob_refresh_keys()).
Fixes bug #33762 ; not in any released tor version.
2020-03-30 23:35:19 +03:00
ca8e6451f2
Merge branch 'maint-0.4.3'
2020-03-30 13:38:58 -04:00
42e56f5bac
hs-v3: Relax severity of a log message when decoding descriptors.
...
Make it LOG_PROTOCOL_WARN and also add the expiration timestamp in there to
ease debugging in the future.
2020-03-30 13:38:29 -04:00
ec8d41e699
changes: Add file for ticket 33014
...
Signed-off-by: David Goulet <dgoulet@torproject.org >
2020-03-30 13:36:54 -04:00
27e2989fe9
Merge branch 'tor-github/pr/1775'
2020-03-30 13:31:56 -04:00
0dc25a4b66
Use a macro to make our hs_opts checking terser.
2020-03-30 13:31:44 -04:00
84868109d2
Use SECTION_HEADER, not "HiddenServiceDir".
...
Add a nonfatal assertion about a branch that should be unreachable.
2020-03-30 13:31:44 -04:00
8aacd78e14
Update expected log messages in tests to new format.
2020-03-30 13:31:44 -04:00
d421050f3a
Derive hidden service configuration from hs_opts_t.
...
This simplifies our parsing code by about 150 lines, and makes the
functions more straightforward.
2020-03-30 13:31:44 -04:00
cfaf1bca98
Start using confmgt logic to parse HS configuration.
...
This patch doesn't actually use the results of the parsed object to
create the service configuration: subsequent patches will do
that. This patch just introduces the necessary configuration tables
and starts using them to validate the configuration.
As of this writing, this patch breaks tests. I'll likely fix that
in a rebase later on: the current error messages for failures to
parse options are a regression, so I've opened #33640 for that.
2020-03-30 13:31:44 -04:00
43b578e099
Use config_lines_partition() to parse hs config sections.
2020-03-30 13:31:44 -04:00
9061303080
Put *.a wildcard entry into .gitignore instead of listing all .a files
2020-03-28 14:01:07 +02:00
d9e042983f
Merge remote-tracking branch 'tor-github/pr/1832/head'
2020-03-27 09:15:29 -04:00
3a0f200505
fix typo in struct addr_policy_t comment
2020-03-27 03:48:15 -04:00
46f4f82ac9
correct tor_addr_family() function comment
...
kind of a losing game to remember to update that comment when
we add another possible family, but hey, maybe it will be a while
until we add one more.
2020-03-27 03:46:54 -04:00
David Goulet
teor
MrSquanchee
Nick Mathewson
Putta Khunchalee
George Kadianakis
Steven Engler
rl1987
Roger Dingledine