096cbfb8b0
Merge remote-tracking branch 'tor-github/pr/1480'
2019-11-01 09:35:17 -04:00
fa0257eda0
Merge branch 'tor-github/pr/1484'
2019-10-31 15:31:14 +08:00
a18e84ad01
config: Improve some function comments
2019-10-31 11:11:51 +10:00
4666ca73a1
config: Give warn_about_relative_paths() const args
...
Also gives make_path_absolute() const args.
Obviously correct fixes to already reviewed code.
2019-10-31 10:53:26 +10:00
a6ad26fd5f
Merge remote-tracking branch 'tor-github/pr/1485'
2019-10-30 16:16:12 -04:00
cfc60e566c
circ: Add an handle to circuit_t
...
Closes #32343
Signed-off-by: David Goulet <dgoulet@torproject.org >
2019-10-30 16:12:56 -04:00
5a1dfca071
Fix 32167: comment in config.c
2019-10-30 16:05:48 -04:00
183f9e490f
test: Fix a comment typo in src/test/test_hs_ntor.sh
2019-10-31 00:43:13 +10:00
861b9366df
test: Fix a loop variable bug in test_parseconf.sh
...
Obviously correct fixes to already reviewed code.
No changes file required: not in any released version of tor.
2019-10-31 00:23:30 +10:00
f81e4aa831
hs-v2: Lookup intro failure cache when picking an intro from descriptor
...
When picking an intro point from the service descriptor, the client failed to
lookup the failure cache.
It made an HS v2 client re-pick bad intro points for which we already know it
won't work in the first place.
Based on Neel Chauhan original patch.
Fixes #25568
Signed-off-by: David Goulet <dgoulet@torproject.org >
2019-10-30 08:47:21 -04:00
dce1f63d44
fs: Clarify an ambiguous comment about string/pointer equality
2019-10-30 16:15:43 +10:00
4413b98190
Merge branch 'tor-github/pr/1456'
2019-10-29 21:29:13 +08:00
30705e8294
app/config: Fix a comment typo in config.c
...
The options validation is now a callback.
Bugfix on 31241; not in any released version of tor.
2019-10-29 12:40:20 +10:00
ceca6e7c35
ewma: Implement unit tests
...
At this commit, 93.9% of line coverage and 95.5% of function coverage.
Closes #32196
Signed-off-by: David Goulet <dgoulet@torproject.org >
2019-10-28 13:17:11 -04:00
48781c32ca
ewma: Move private struct into header private section
...
Facilitate testing.
Part of #32196 .
Signed-off-by: David Goulet <dgoulet@torproject.org >
2019-10-28 13:17:11 -04:00
bbcded554a
test: Implement unit tests for circuitmux.c
...
Signed-off-by: David Goulet <dgoulet@torproject.org >
2019-10-28 13:17:11 -04:00
dba249bc73
test: Add fakecircs.{h|c} helper
...
Fake circuits are created everywhere in the unit tests. This is an attempt at
centralizing a "fake circuit creation" API like fakechans.c does for channel.
This commit introduces fakecircs.c and changes test_relay.c and
test_circpadding.c which were using roughly the same code.
This will allow easier OR circuit creation for the future tests in
test_circuitmux.c
Signed-off-by: David Goulet <dgoulet@torproject.org >
2019-10-28 13:17:11 -04:00
a41ec84914
test: Implement cmux allocate unit test
...
Signed-off-by: David Goulet <dgoulet@torproject.org >
2019-10-28 13:17:11 -04:00
d2e51aca7d
test: Remove circuitmux/destroy_cell_queue code duplication
...
This also rename a function to improve code clarity.
Signed-off-by: David Goulet <dgoulet@torproject.org >
2019-10-28 13:17:11 -04:00
839bc4814e
test: Add testcase setup object for test_cmux
...
Also remove a scheduler_init() from a test and MOCK the appropriate function
so the test can pass.
This is done in order to minimize initialization functions in the unit test
and try to only go through the testcase setup object.
Signed-off-by: David Goulet <dgoulet@torproject.org >
2019-10-28 13:17:11 -04:00
7678022e85
cmux: Move circuitmux_s object into header in private section
...
Step needed in order to access members of the object for unit tests.
Signed-off-by: David Goulet <dgoulet@torproject.org >
2019-10-28 13:17:11 -04:00
4c95022658
core: Add missing include in destroy_cell_queue_st.h
...
Signed-off-by: David Goulet <dgoulet@torproject.org >
2019-10-28 13:17:11 -04:00
bf16efeb07
nodelist: fix a comment typo in routerset.h
2019-10-28 23:44:08 +10:00
b98631d280
Merge branch 'tor-github/pr/1476'
2019-10-28 08:47:57 -04:00
25d66a3391
add missing docs in crypto_digest*
2019-10-28 08:27:42 -04:00
f751cc020f
Documentation cleanup in confmacros.h
2019-10-26 17:24:22 -04:00
b314b68d61
Fix doxygen HTML warnings in src/feature.
2019-10-26 12:07:09 -04:00
68f8086041
doxygen: add @file declarations for src/feature/
...
If a file doesn't use the file command (either \file or @file),
Doxygen won't try to process it.
2019-10-26 12:05:28 -04:00
30c6ab5150
doxygen: add @file declarations for src/app
...
If a file doesn't use the file command (either \file or @file),
Doxygen won't try to process it.
2019-10-26 11:41:43 -04:00
5f299feb82
doxygen: add @file declarations for src/core/crypto
...
If a file doesn't use the file command (either \file or @file),
Doxygen won't try to process it.
2019-10-26 11:39:17 -04:00
ff7a70ca09
doxygen: add @file declarations for src/core/or
...
If a file doesn't use the file command (either \file or @file),
Doxygen won't try to process it.
2019-10-26 11:37:25 -04:00
943fd734f9
doxygen: add @file declarations for src/core/mainloop
...
If a file doesn't use the file command (either \file or @file),
Doxygen won't try to process it.
2019-10-26 11:26:06 -04:00
4d4a3eeeb1
doxygen: add @file declarations for src/core/proto
...
If a file doesn't use the file command (either \file or @file),
Doxygen won't try to process it.
These declarations also turned up a doxygen warning for
proto_socks.c; I fixed that too.
2019-10-26 11:21:25 -04:00
39d09ea081
doxygen: add @file declarations for src/lib
...
If a file doesn't use the file command (either \file or @file),
Doxygen won't try to process it.
These declarations also turned up a doxygen warning for
crypto_ope.c; I fixed that too.
2019-10-26 11:13:29 -04:00
16dffa523e
Rename confparse.[ch] identifiers to confmgt.[ch] identifiers.
...
This is an automated commit, generated by this command:
./scripts/maint/rename_c_identifier.py \
confparse.h confmgt.h \
confparse.c confmgt.c \
CONFPARSE_PRIVATE CONFMGT_PRIVATE \
TOR_CONFPARSE_H TOR_CONFMGT_H
2019-10-26 10:09:03 -04:00
2402d95715
Rename confparse.[ch] to confmgt.[ch]
...
This will break compilation until includes etc are fixed.
2019-10-26 10:07:14 -04:00
407fb0c35c
Move config_format_t and allied definitions into conftypes.h
...
Since these are needed by every module that is _configurable_, they
belong in lib/conf, not lib/confmgt.
2019-10-26 10:05:03 -04:00
e7993dc046
Merge branch 'ticket31241_v3'
2019-10-25 08:10:39 -04:00
63f2a310cb
config,state: check magic in all callbacks.
2019-10-25 08:09:05 -04:00
aa6b4b62db
confparse: Add a function to check the magic of a toplevel object.
2019-10-25 08:08:43 -04:00
0ae530c8f6
test: Use SEVERITY_MASK_IDX() to find the LOG_* mask indexes
...
In the unit tests.
Fixes a regression to bug 31334; bug not in any released version of tor.
2019-10-25 17:23:46 +10:00
60aa6dac34
Merge remote-tracking branch 'tor-github/pr/1467'
2019-10-25 17:17:39 +10:00
a91f52a443
Merge branch 'maint-0.4.2'
2019-10-25 10:38:22 +10:00
620e40bcfc
test_options: add a test for options_trial_assign()
...
This function is used by controllers to set options. I refactored
it a bit when refactoring options validation, so it needs to get
tested.
2019-10-24 20:38:02 -04:00
06475f30e9
tests: set DataDirectory_option as well as DataDirectory.
...
options_validate_cb() derives DataDirectory (which we use) from
DataDirectory_option (which the user sets). I want to add a test
that will call options_validate_cb(), but it will fail unless it
derives the same value.
2019-10-24 20:38:02 -04:00
4d53bbeafb
config: make options_act*() mockable.
...
I'll need this for testing options_trial_assign().
2019-10-24 20:38:02 -04:00
c8aa3cc17d
Merge remote-tracking branch 'tor-github/pr/1466' into maint-0.4.2
2019-10-25 10:38:01 +10:00
f796bf3aa5
Extend confmgr tests to handle validation callbacks.
2019-10-24 20:37:53 -04:00
d17aa09308
config.c: Turn options_transition_allowed() into a proper callback
2019-10-24 20:30:32 -04:00
bd891f517f
config.c: extract validate, check-transition, and set into a function
...
This eliminates duplicated code. The options_validate() function
itself is now tests-only.
2019-10-24 20:30:32 -04:00
Nick Mathewson
George Kadianakis
teor
David Goulet
Neel Chauhan