7e7b3d3df3
Add unit tests for IPv6 address summaries and IPv4 netblock rejection
...
These tests currently fail due to bug 21357
2017-02-01 09:39:06 -05:00
f3c040e33e
test: fix memory leak in single onion poisoning
...
Closes #20938
Signed-off-by: David Goulet <dgoulet@torproject.org >
2016-12-09 12:59:40 -05:00
9fe6ffa588
Use the correct preprocessor macro for Linux
...
Also combine all of the checks into one if-tree as only one of them
should actually succeed.
2016-12-08 07:48:19 -05:00
53d4e89626
Netbsd doesn't have ipfw, only the regular pf transport stuff.
...
Attempted fix for 19960.
Also, fixes a typo.
2016-12-07 15:22:44 -05:00
e7ade23f97
Increase verbosity on options/validate__transproxy
...
This is an attempt to figure out what's up with #19960
2016-12-07 11:24:58 -05:00
fce425e3ff
Increase tolerances in util/monotonic_time tests
...
This is an attempt to fix #19974 .
2016-12-07 11:08:54 -05:00
e8ce57e6e8
Move a comment in test_single_onion_poisoning
2016-12-03 06:30:58 +11:00
8d42aab3f6
Add a missing return value check in test_single_onion_poisoning
2016-12-03 06:30:06 +11:00
fdd368d656
Remove a double-free in test_single_onion_poisoning
...
We were freeing both dir{1,2} directly, and service_{1,2}->directory via
rend_service_free, even though they are the same pointer.
2016-12-03 06:27:32 +11:00
c100c5c69b
Refactor poison_dir allocation and free in test_single_onion_poisoning
...
This pattern is much less error-prone when future changes are made.
2016-12-03 06:25:46 +11:00
1221c5aa02
test_single_onion_poisoning: Free dir[12] on all paths
...
Coverity doesn't like it when there are paths to the end of the
function where something doesn't get freed, even when those paths
are only reachable on unit test failure.
Fixes CID 1372899 and CID 1372900. Bug not in any released Tor.
2016-12-02 07:39:14 -05:00
f8a7972b29
Merge branch 'bug20638_029_v2_squashed' into maint-0.2.9
2016-12-01 09:45:14 -05:00
f80a43d16f
Stop ignoring hidden service key anonymity when first starting tor
...
Instead, refuse to start tor if any hidden service key has been used in
a different hidden service anonymity mode.
Fixes bug 20638; bugfix on 17178 in 0.2.9.3-alpha; reported by ahf.
The original single onion service poisoning code checked poisoning state
in options_validate, and poisoned in options_act. This was problematic,
because the global array of hidden services had not been populated in
options_validate (and there were ordrering issues with hidden service
directory creation).
This patch fixes this issue in rend_service_check_dir_and_add, which:
* creates the directory, or checks permissions on an existing directory, then
* checks the poisoning state of the directory, then
* poisons the directory.
When validating, only the permissions checks and the poisoning state checks
are perfomed (the directory is not modified).
2016-12-01 09:44:53 -05:00
91abd60cad
Update unit tests for 20484, 20529
...
Add extra logging and extra validity checks for hidden services.
2016-12-01 09:44:53 -05:00
e2c881487c
Merge remote-tracking branch 'arma/bug20423' into maint-0.2.9
2016-11-21 12:40:08 -05:00
3bb40b213b
refactor router_pick_published_address to have another arg
...
no change in behavior except fewer log entries in the case where we use
a cached result.
2016-11-16 16:13:03 -05:00
150a2b39b0
fixup! Add expect_log_msg_containing_either3() and expect_log_msg_containing_either4()
...
Fix typos:
* extra '('
* use assert_log_predicate (without 3 or 4 at the end)
Tidy whitespace.
Wrap long lines.
2016-11-16 13:14:00 +11:00
0825fc6af9
Add all four error messages to test_address_get_if_addrs6_list_no_internal()
2016-11-16 12:57:13 +11:00
01492d3869
Add all four error messages to test_address_get_if_addrs6_list_internal()
2016-11-16 12:57:09 +11:00
cccc08ad56
Add expect_log_msg_containing_either3() and expect_log_msg_containing_either4()
2016-11-16 12:57:05 +11:00
89ec191b68
Merge remote-tracking branch 'public/bug20306_029' into maint-0.2.9
2016-11-08 18:51:07 -05:00
c2fc0941a5
Merge remote-tracking branch 'teor/bug20484_029_v2' into maint-0.2.9
2016-11-07 16:12:13 -05:00
e482541cfb
Fix another 20499-broken test
2016-11-07 16:10:42 -05:00
d2071c36f6
Fix a unit test (broken by recent 20499 hacking)
2016-11-07 16:02:55 -05:00
def41e93bd
In test_tortls_classify_client_ciphers(), s/ECDH/ECDHE/
...
(We weren't actually using these ciphers; we were just requing that
ciphers of that name existed.)
Patch from rubiate. Fixes 20460
2016-11-06 20:23:40 -05:00
01fe039b78
Test single onion service configs where the directory does not exist
...
Runs a test for each combination of create/don't create directories.
Tests #20484 .
2016-11-02 14:17:52 +11:00
13fbbe9cce
Make sure passthrough_test_setup doesn't inadvertently fail or skip tests
...
passthrough_test_setup doesn't pass through arguments if the argument
is equal to 0 or TT_SKIP. Instead, it fails or skips the test.
Assert on this, so we don't accidentally fail or skip tests.
2016-11-02 14:16:14 +11:00
77e1d660ee
Add get_fname_rnd for unit tests that want a unique path every time
2016-11-02 14:14:19 +11:00
d7634dc519
Create get_fname_suffix, and refactor get_fname to use it
2016-11-02 14:13:34 +11:00
fedafe7c0e
Use check_private_dir in test_single_onion_poisoning
...
This avoids Win32 conditionals for mkdir.
2016-11-02 11:37:11 +11:00
ff3e08f2af
Attempt to fix unit tests on netbsd
2016-11-01 13:32:21 -04:00
d73c671d6d
policy_is_reject_star():
...
ome policies are default-reject, some default-accept. But
policy_is_reject_star() assumed they were all default_reject. Fix
that!
Also, document that policy_is_reject_star() treats a NULL policy as
empty. This allows us to simplify the checks in
parse_reachable_addresses() by quite a bit.
Fxes bug 20306; bugfix on 0.2.8.2-alpha.
2016-10-31 15:05:56 -04:00
55c468c521
Whitespace cleaning
2016-10-14 10:40:31 -04:00
af70e43131
Merge remote-tracking branch 'public/spaces_in_unix_addrs'
2016-10-14 10:21:41 -04:00
9615ad338f
Make the FreeBSD ersatz_socketpair test even more skippable.
...
(This is safe, since only windows actually -uses- erstaz_socketpair.)
2016-10-14 09:14:07 -04:00
07f2e5748e
ersatz socketpair tests: work around freebsd jails.
2016-10-13 09:47:28 -04:00
0e1b228aa6
Fix a bug in displaying IPv6 addrs in test_op_ipv6_ with --verbose
...
The test code, if it failed, or if it was run in verbose mode, would
use the wrong variable for its loop. Patch from rubiate uploaded to
19999.
2016-10-11 20:09:24 -04:00
ab78a4df93
torrc parsing b0rks on carriage-return
...
(Specifically, carriage return after a quoted value in a config
line. Fixes bug 19167; bugfix on 0.2.0.16-alpha when we introduced
support for quoted values. Unit tests, changes file, and this
parenthetical by nickm.)
2016-10-11 09:25:22 -04:00
05aed5b635
Allow a unix: address to contain a C-style quoted string.
...
Feature 18753 -- all this to allow spaces.
2016-10-04 15:43:20 -04:00
ed5d2daba1
Merge remote-tracking branch 'public/ticket20001_v2'
2016-09-26 11:01:10 -07:00
97337844b7
Merge branch 'protover_v2_squashed'
2016-09-26 11:00:08 -07:00
3a3120819c
Rename compute_protover_vote to protover_compute_vote
2016-09-26 10:56:53 -07:00
e402cddefe
Clean whitespace, add missing documentation
2016-09-26 10:56:52 -07:00
a232161f7b
Cover the error cases of parsing protocol versions
...
Also, detect an additional failure type. Thanks, tests!
(How distinctly I recall thee)
2016-09-26 10:56:50 -07:00
0697e413ef
Unit tests for protover_all_supported
2016-09-26 10:56:49 -07:00
c1be8f9d57
Basic backend for the protocol-versions voting algorithm.
...
[This is a brute-force method that potentially uses way too much
RAM. Need to rethink this a little. Right now you can DOS an
authority by saying "Foo=1-4294967295".]
2016-09-26 10:56:49 -07:00
4df12239f6
Emit and parse protocol lists in router descriptors
2016-09-26 10:56:49 -07:00
b2b2e1c7f2
checkpoint basic protover backend
2016-09-26 10:56:48 -07:00
0baa276ea9
Coverity warning fix: let coverity tell we're closing sockets
...
Our use of the (mockable) tor_close_socket() in the util/socket_..
tests confused coverity, which could no longer tell that we were
actually closing the sockets.
2016-09-22 09:24:56 -04:00
6cb9c2cf77
Add support for AES256 and AES192
...
(This will be used by prop224)
2016-09-16 11:21:33 -04:00
teor
David Goulet
cypherpunks
Nick Mathewson
Roger Dingledine
Neel Chauhan
paolo.ingls@gmail.com