3adabaf3e9
tls: Make buf_read_from_tls() read at most bytes
...
The buf_read_from_tls() function was designed to read up to a certain number
of bytes a TLS socket using read_to_chunk_tls() which boils down to SSL_read()
(with OpenSSL, common case).
However, at the end of the loop, the returned number of bytes from
read_to_chunk_tls() was treated like the syscall read() for which if less
bytes than the total asked are returned, it signals EOF.
But, with SSL_read(), it returns up to a TLS record which can be less than
what was asked. The assumption that it was EOF was wrong which made the while
loop exiting before it was able to consume all requested bytes (at_most
parameter).
The general use case that Tor sees is that it will ask the network layer to
give it at most 16KB (that is roughly 32 cells) but because of KIST scheduler,
the highest possible TLS record we currently observe is 4096 bytes (4KB or 8
cells). Thus the loop would at best always return 8 cells even though much
more could be on the TLS socket. See ticket #40006 for more details.
Fixes #40006
Signed-off-by: David Goulet <dgoulet@torproject.org >
2020-06-24 10:47:53 -04:00
9fdaede3f7
Remove AssumeReachable from TestingTorNetwork.
...
Closes ticket 34446.
2020-06-15 14:08:42 -04:00
3cb77a9cca
Merge branch 'maint-0.4.4'
2020-06-11 17:29:54 +03:00
52edea121e
Fold in a changes file and update exceptions.txt.
...
Co-authored-by: Florentin Rochet <florentin.rochet@uclouvain.be >
2020-06-11 16:13:25 +03:00
1797d05165
Merge branch 'tor-github/pr/1925'
2020-06-10 15:37:59 +03:00
963c3591c8
Bug 30992: Changes file
2020-06-10 15:37:44 +03:00
354f085e5f
Merge remote-tracking branch 'tor-github/pr/1888/head'
2020-06-09 15:44:58 -04:00
1fb9be5396
Merge remote-tracking branch 'tor-github/pr/1902/head'
2020-06-05 10:08:27 -04:00
b335ef1781
changes file for ticket 32888
2020-06-04 10:35:51 -04:00
22a26a273e
Merge branch 'tor-github/pr/1909'
2020-06-02 14:01:49 +03:00
b6e60f26dd
Merge branch 'maint-0.4.3'
2020-06-01 09:50:04 -04:00
688d1b3f03
Merge remote-tracking branch 'tor-github/pr/1905/head' into maint-0.4.3
2020-06-01 09:47:37 -04:00
39f2411b3f
Preemptive circs should work with UseEntryGuards 0
...
Resume being willing to use preemptively-built circuits when
UseEntryGuards is set to 0. We accidentally disabled this feature with
that config setting (in our fix for #24469 ), leading to slower load times.
Fixes bug 34303; bugfix on 0.3.3.2-alpha.
2020-05-30 02:20:48 -04:00
6891d1bbcb
Merge branch 'tor-github/pr/1792' into maint-0.4.3
2020-05-28 12:25:57 +03:00
ca356b952e
changes: Add changes file for ticket 33458
...
Signed-off-by: David Goulet <dgoulet@torproject.org >
2020-05-28 12:25:42 +03:00
8d8a9d7f1d
Merge branch 'tor-github/pr/1898'
2020-05-27 15:17:55 +03:00
f6943d702c
Add changes file for ticket #24844
2020-05-27 15:16:39 +03:00
d6186c7435
Man page: MinUptimeHidServDirectoryV2 defaults to 96 hours
...
Bugfix on 0.2.6.3-alpha; fixes bug 34299.
2020-05-23 04:37:57 -04:00
43f4324e29
Merge remote-tracking branch 'tor-github/pr/1899/head'
2020-05-21 10:08:48 -04:00
3121e5c103
Merge branch 'tor-github/pr/1850'
2020-05-21 16:24:32 +03:00
fb281daf29
Merge branch 'tor-github/pr/1861'
2020-05-21 16:22:47 +03:00
17c4e489e9
Add changes file
2020-05-21 13:43:37 +03:00
c4fb3bfed5
Add support for console control signals in Windows
2020-05-20 23:28:39 +05:30
9b55a62e73
Merge branch 'maint-0.4.3'
2020-05-19 09:39:12 -04:00
68fe8826dd
Doxygen: fix unbalanced groups.
...
Closes ticket 34255.
2020-05-19 09:18:39 -04:00
1df451aba1
changes: file for 34200
2020-05-18 22:12:26 +10:00
3efe53562f
rust/protover: Fix protocol version support error handling
...
Make Rust protocol version support checks consistent with the
undocumented error behaviour of the corresponding C code.
Fixes bug 34251; bugfix on 0.3.3.5-rc.
2020-05-18 21:50:35 +10:00
f05c144d7c
rust: declare HSIntro=5
...
Declare support for the onion service introduction point denial of
service extensions, when building tor with Rust.
Fixes bug 34248; bugfix on 0.4.2.1-alpha.
2020-05-18 20:16:11 +10:00
db4815dd8e
Merge branch 'maint-0.4.3'
2020-05-15 10:28:36 -04:00
6f2b6ede1b
Add a changes file for 34233.
...
This bug was merged back to 0.3.5 with our #34078 fix, but only
released in 0.4.3.5, so the changes file goes here.
2020-05-15 10:27:49 -04:00
85cfd04c0c
remove changes files that have already appeared in 0.4.3.
2020-05-14 20:29:00 -04:00
4d2822ee74
changes: file for 33222 and 33226
2020-05-13 16:05:54 +10:00
1557e73c82
Merge branch 'bug34130_035'
2020-05-12 12:58:19 -04:00
2913dbd6d9
Fix crash when tor is compiled with NSS and seccomp sandbox is enabled
...
Adds seccomp rules for socket and getpeername used by NSS
2020-05-12 12:56:06 -04:00
86b5bcd80a
Merge remote-tracking branch 'tor-github/pr/1885/head'
2020-05-12 12:52:41 -04:00
cc169eb120
Add documentation about %include and seccomp sandbox limitations
2020-05-08 00:21:12 +01:00
b7a165228f
Merge remote-tracking branch 'tor-github/pr/1880/head'
2020-05-07 08:19:11 -04:00
0daa1da3ba
Define and use TOR_ADDRPORT_BUF_LEN
2020-05-07 20:38:25 +10:00
3a785dd5be
Merge branch 'maint-0.4.3'
2020-05-06 17:17:19 -04:00
b444096be5
Fix a boolean logic error when logging about invalid hostnames.
...
Fixes bug 34131; bugfix on 0.4.3.1-alpha.
2020-05-06 17:15:37 -04:00
e39b35f1de
Merge branch 'maint-0.4.3'
2020-05-06 16:58:12 -04:00
ae1ebb5f44
Merge branch 'maint-0.4.2' into maint-0.4.3
2020-05-06 16:58:12 -04:00
d46f67ef0e
Merge branch 'maint-0.4.1' into maint-0.4.2
2020-05-06 16:58:12 -04:00
633366efcd
Merge branch 'maint-0.3.5' into maint-0.4.1
2020-05-06 16:58:12 -04:00
dd795fbee4
changes file for bug 34078.
2020-05-06 16:58:06 -04:00
42dfcd0ae3
core/or: Lift slow call out of loop, #33977
2020-05-05 15:07:42 -04:00
2e519fbfb0
changes: File for #33789
...
Signed-off-by: David Goulet <dgoulet@torproject.org >
2020-05-05 14:24:04 -04:00
f96b6ccee1
Merge branch 'maint-0.4.3'
2020-05-04 10:25:53 -04:00
bbfc498e21
Merge branch 'maint-0.4.1' into maint-0.4.2
2020-05-04 10:25:52 -04:00
6aaee6133d
Merge branch 'bug34077_042' into bug34077_043
2020-04-30 23:01:58 -04:00
David Goulet
Nick Mathewson
George Kadianakis
Mike Perry
Roger Dingledine
Neel Chauhan
rl1987
Damon Harris
teor
Daniel Pinto
Alex Xu (Hello71)