05b54f6a6a
Use subsystems manager for subsystems used in tests.
2018-11-05 09:22:02 -05:00
a0ee54549f
Turn the wallclock module into a subsystem.
...
(This may be slightly gratuitous.)
2018-11-05 09:22:02 -05:00
d3e4afcc9b
Turn the logging code into a subsystem
2018-11-05 09:22:02 -05:00
b8c50eabfe
Add a subsystem for our threading support
2018-11-05 09:22:02 -05:00
178c1821b2
Make the windows process parameter initialization a subsystem
...
Also, move it from "main" into lib/process
2018-11-05 09:22:02 -05:00
175153a329
Make initialization for the "err" library into a subsystem.
2018-11-05 09:22:02 -05:00
6e7ff8cba0
Move the code that knows our tor version into a lowest-level lib
2018-11-05 09:22:02 -05:00
7bb76b24cf
Code to manage the list of subsystems.
2018-11-05 09:22:02 -05:00
0ce1f2d466
Declare the subsystem structure.
2018-11-01 12:55:52 -04:00
084924360a
Merge branch 'ticket23082_squashed'
2018-10-30 09:05:42 -04:00
1425549ca6
Code cleanups for tor_addr_parse()
2018-10-30 09:05:11 -04:00
742cd15649
Move a check for trailing colon to tor_inet_pton()
...
That way, string_is_valid_ipv6_address() can benefit from it
2018-10-30 09:05:11 -04:00
b77889fc5f
Merge branch 'maint-0.3.5'
2018-10-24 10:20:53 -04:00
d1d66866b2
Rename a function; it is used to convert a value _From_ le.
...
We can't use htons()/ntohs() -- those are no-ops on exactly the
wrong platforms.
2018-10-19 08:42:28 -04:00
f8a1dc64f9
Fix a misspelled macro test that was breaking big-endian OPE
...
Fixes bug 28115; bugfix on 0.3.5.1-alpha.
2018-10-19 08:41:25 -04:00
a56451af42
evloop: fix docs for threadpool_register_reply_event
...
Commit 6a5f62f68f
2018-10-17 20:27:19 +00:00
f07ab5b95c
evloop: fix docs
...
alert_sockets_t was moved in 544ab27a94
2018-10-17 20:27:19 +00:00
8b3ec74e5f
Merge remote-tracking branch 'public/bug27990'
2018-10-16 08:02:01 -04:00
feed41bed3
Merge branch 'maint-0.3.4'
2018-10-15 12:47:46 -04:00
23ce9a60fb
Merge branch 'maint-0.3.4'
2018-10-15 10:48:35 -04:00
4983322cc7
Merge branch 'maint-0.3.4'
2018-10-15 10:37:53 -04:00
2dccef0eb4
Merge branch 'bug27772_squashed'
2018-10-14 15:31:52 -04:00
7c8f20ba44
In tor_tls_get_my_certs(), set cert ptrs even on failure
...
Nothing should ever look at them on failure, but in some cases,
the unit tests don't check for failure, and then GCC-LTO freaks out.
Fixes part of 27772.
2018-10-14 15:25:16 -04:00
d3d6c59557
Add sys/time.h include back to procmon.c
2018-10-10 11:26:38 -04:00
361eaa9931
Merge remote-tracking branch 'public/ticket27856'
2018-10-09 09:04:53 -04:00
58299b2927
Merge remote-tracking branch 'public/bug27728'
2018-10-01 12:06:39 -05:00
b058f64cc0
Detect an unlikely integer overflow.
2018-09-27 16:30:02 -04:00
9e1a3be064
Prevent duplicate initialization of NSS DH module
...
Allowing this didn't do any actual harm, since there aren't any
shared structures or leakable objects here. Still, it's bad style
and might cause trouble in the future.
Closes ticket 27856.
2018-09-27 13:26:47 -04:00
34402ece8c
geoip: fix windows compilation
2018-09-27 11:02:58 -04:00
c8f2a6d2fe
Extract the non-stats part of geoip into a new src/lib/geoip.
2018-09-27 10:26:01 -04:00
6c739c3fb2
Fix arm compilation with openssl <1.1
...
Bug 27781; bugfix on 0.3.5.1-alpha.
2018-09-24 11:11:29 -04:00
4e2028152d
Fix an NSS socket leak-on-error found by dgoulet
2018-09-20 13:53:04 -04:00
d6c564e09a
Use the correct macro to detect an invalid socket in tortls_nss.c
...
Fixes bug 27782; bugfix on 0.3.5.1-alpha
2018-09-20 12:55:31 -04:00
62b709bc26
Release ownership of the dummy socket that tortls_nss.c will close
...
Related to #27795 -- since NSS will close the socket, we must not
count it as owned by Tor.
2018-09-20 12:53:39 -04:00
1c1e84281d
Add a tor_release_socket_ownership() function.
2018-09-20 12:46:47 -04:00
1f377e910f
Merge branch 'maint-0.3.4'
2018-09-20 10:43:08 -04:00
7ace8d5a61
Assert that some trunnel _new() functions return non-NULL
...
The trunnel functions are written under the assumption that their
allocators can fail, so GCC LTO thinks they might return NULL. In
point of fact, they're using tor_malloc() and friends, which can't
fail, but GCC won't necessarily figure that out.
Fixes part of #27772 .
2018-09-18 14:43:57 -04:00
ea5792f333
Make crypto_strongest_rand() non-mockable
...
Instead, have it call a mockable function. We don't want
crypto_strongest_rand() to be mockable, since doing so creates a
type error when we call it from ed25519-donna, which we do not build
in a test mode.
Fixes bug 27728; bugfix on 0.3.5.1-alpha
2018-09-18 12:40:18 -04:00
43324b0e4d
Fix minor memleak in edge-case of crypto_rsa.c function.
2018-09-18 14:01:15 +03:00
f606b3cfd1
Lower the maximum size of a private key file to 16 MB
...
This shouldn't be a user-visible change: nobody has a 16 MB RSA
key that they're trying to use with Tor.
I'm doing this to fix CID 1439330 / ticket 27730, where coverity
complains (on 64-bit) that we are making a comparison that is never
true.
2018-09-17 11:08:56 -04:00
991bec67ee
When Tor is compiled with NSS, don't claim support for LinkAuth=1
...
Closes ticket 27288
2018-09-16 13:28:29 -04:00
035166e7bf
Add a missing function for windows
2018-09-14 15:02:11 -04:00
af39649aad
Explicitly ignore BIO_set_close() return val to fix #27711
2018-09-14 13:09:10 -04:00
79f8641ee5
Merge branch 'nss_countbytes_squashed'
2018-09-14 12:45:30 -04:00
ac93c911ce
Allow malloc includes in tls library
2018-09-14 12:44:56 -04:00
126819c947
Add support for lower-level byte counting with NSS
...
This is harder than with OpenSSL, since OpenSSL counts the bytes on
its own and NSS doesn't. To fix this, we need to define a new
PRFileDesc layer that has its own byte-counting support.
Closes ticket 27289.
2018-09-14 12:44:56 -04:00
0e4fcd3996
Merge branch 'nss_27664'
2018-09-14 10:24:46 -04:00
e43ae24e7d
Merge branch 'nss_27451'
2018-09-14 10:22:38 -04:00
d8280216c0
Include torint.h in socketpair.c for intptr_t definition.
2018-09-13 17:54:26 -04:00
92357a07bd
Fix a 32-bit off_t/size_t warning in crypto_rsa.c
...
Bug not in any released Tor.
2018-09-13 17:49:39 -04:00
Nick Mathewson
rl1987
cypherpunks
George Kadianakis