Zero a cipher completely before freeing it

We used to only zero the first ptrsize bytes of the cipher. Since
cipher is large enough, we didn't zero too many bytes. Discovered
and fixed by ekir. Fixes bug 1254.
This commit is contained in:
Sebastian Hahn
2010-02-22 11:39:29 +01:00
parent a7e0b2d6d9
commit f5112fa487
2 changed files with 4 additions and 1 deletions
+1 -1
View File
@@ -268,7 +268,7 @@ aes_free_cipher(aes_cnt_cipher_t *cipher)
#ifdef USE_OPENSSL_EVP
EVP_CIPHER_CTX_cleanup(&cipher->key);
#endif
memset(cipher, 0, sizeof(cipher));
memset(cipher, 0, sizeof(aes_cnt_cipher_t));
tor_free(cipher);
}