From eab81b12e92ea3ae53d14337a6fafc9d6c32b39a Mon Sep 17 00:00:00 2001 From: rl1987 Date: Mon, 29 Oct 2018 11:31:03 +0200 Subject: [PATCH 1/3] Fix shellcheck warning SC2086 in run_calltool.sh --- scripts/maint/run_calltool.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/scripts/maint/run_calltool.sh b/scripts/maint/run_calltool.sh index efb8706fea..f36810f5b6 100755 --- a/scripts/maint/run_calltool.sh +++ b/scripts/maint/run_calltool.sh @@ -15,7 +15,7 @@ SUBITEMS="fn_graph fn_invgraph fn_scc fn_scc_weaklinks module_graph module_invgr for calculation in $SUBITEMS; do echo "======== $calculation" - python -m calltool $calculation > callgraph/$calculation + python -m calltool "$calculation" > callgraph/"$calculation" done echo < callgraph/README From 6aef0ce94e9bfe5d3bd06f0a3349f9e8930218f5 Mon Sep 17 00:00:00 2001 From: rl1987 Date: Mon, 29 Oct 2018 11:37:16 +0200 Subject: [PATCH 2/3] Fix shellcheck issue SC2217 in run_calltool.sh --- scripts/maint/run_calltool.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/scripts/maint/run_calltool.sh b/scripts/maint/run_calltool.sh index f36810f5b6..b0268322f4 100755 --- a/scripts/maint/run_calltool.sh +++ b/scripts/maint/run_calltool.sh @@ -18,7 +18,7 @@ for calculation in $SUBITEMS; do python -m calltool "$calculation" > callgraph/"$calculation" done -echo < callgraph/README +cat < callgraph/README This directory holds output from calltool, as run on Tor. For more information about each of these files, see the NOTES and README files in the calltool distribution. From 5a3cb495ce5bf010440fc0288c1ca00fff6ec8e5 Mon Sep 17 00:00:00 2001 From: rl1987 Date: Mon, 29 Oct 2018 11:41:36 +0200 Subject: [PATCH 3/3] Add changes file --- changes/ticket28011 | 3 +++ 1 file changed, 3 insertions(+) create mode 100644 changes/ticket28011 diff --git a/changes/ticket28011 b/changes/ticket28011 new file mode 100644 index 0000000000..5efc3c917b --- /dev/null +++ b/changes/ticket28011 @@ -0,0 +1,3 @@ + o Code simplification and refactoring: + - Fix shellcheck warnings in run_calltool.sh. Resolves + ticket 28011.