From f21328adfcc4e2b13b3c940e2e3c264a12c09861 Mon Sep 17 00:00:00 2001
From: Roger Dingledine <arma@torproject.org>
Date: Fri, 30 Jan 2004 15:15:11 +0000
Subject: [PATCH] note an assert trigger, if you use an old broken netscape
 socks4

svn:r1022
---
 trunk/src/or/buffers.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/trunk/src/or/buffers.c b/trunk/src/or/buffers.c
index 9a759a7c28..0b56481304 100644
--- a/trunk/src/or/buffers.c
+++ b/trunk/src/or/buffers.c
@@ -532,6 +532,9 @@ int fetch_from_buf_socks(buf_t *buf, socks_request_t *req) {
       }
       log_fn(LOG_DEBUG,"Everything is here. Success.");
       strcpy(req->address, socks4_prot == socks4 ? tmpbuf : startaddr);
+      /* XXX on very old netscapes (socks4) the next line triggers an
+       * assert, because next-buf->mem+1 is greater than buf->datalen.
+       */
       buf_remove_from_front(buf, next-buf->mem+1); /* next points to the final \0 on inbuf */
       return 1;