torproject/tor
1
0
Fork 0
mirror of https://gitlab.torproject.org/tpo/core/tor.git synced 2024-12-06 19:41:15 +01:00
Code Issues Actions Packages Projects Releases Wiki Activity

squash! Pass const uint64_t pointers, document array length.

Browse Source 
Don't cast uint64_t * to const uint64_t * explicitly.  The cast is always
safe, so C does it for us.  Doing the cast explitictly can hide bugs if
the input is secretly the wrong type.

Suggested by Nick.
This commit is contained in:
Karsten Loesing
2013-10-28 10:48:18 +01:00
parent b43a37bc5b
commit e46de82c97
2 changed files with 20 additions and 20 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/test/test_controller_events.c
+8 -8
View File
@@ -159,31 +159,31 @@ test_cntev_append_cell_stats(void *arg)
/* All array entries empty. */
append_cell_stats_by_command(event_parts, key,
(const uint64_t *) include_if_non_zero,
(const uint64_t *) number_to_include);
include_if_non_zero,
number_to_include);
tt_int_op(0, ==, smartlist_len(event_parts));
/* There's a RELAY cell to include, but the corresponding field in
* include_if_non_zero is still zero. */
number_to_include[CELL_RELAY] = 1;
append_cell_stats_by_command(event_parts, key,
(const uint64_t *) include_if_non_zero,
(const uint64_t *) number_to_include);
include_if_non_zero,
number_to_include);
tt_int_op(0, ==, smartlist_len(event_parts));
/* Now include single RELAY cell. */
include_if_non_zero[CELL_RELAY] = 2;
append_cell_stats_by_command(event_parts, key,
(const uint64_t *) include_if_non_zero,
(const uint64_t *) number_to_include);
include_if_non_zero,
number_to_include);
tt_str_op("Z=relay:1", ==, smartlist_pop_last(event_parts));
/* Add four CREATE cells. */
include_if_non_zero[CELL_CREATE] = 3;
number_to_include[CELL_CREATE] = 4;
append_cell_stats_by_command(event_parts, key,
(const uint64_t *) include_if_non_zero,
(const uint64_t *) number_to_include);
include_if_non_zero,
number_to_include);
tt_str_op("Z=create:4,relay:1", ==, smartlist_pop_last(event_parts));
done: