mirror of
https://gitlab.torproject.org/tpo/core/tor.git
synced 2024-12-06 19:41:15 +01:00
scripts/git: Quote shell arguments where possible
Most shell arguments should be quoted to avoid mistakes. But since all branch names are hard-coded, or supplied by the script user, we don't need to be too concerned about command injection. Quoting all shell arguments would take a major refactor. (Probably using arrays.) Part of 31314.
This commit is contained in:
@@ -171,7 +171,7 @@ fi
|
||||
if [ "$PUSH_SAME" -eq 0 -a "$TEST_BRANCH_PREFIX" ]; then
|
||||
NEW_PUSH_BRANCHES=
|
||||
for b in $PUSH_BRANCHES; do
|
||||
PUSH_COMMIT=`git rev-parse $b`
|
||||
PUSH_COMMIT=`git rev-parse "$b"`
|
||||
SKIP_UPSTREAM=
|
||||
for u in $DEFAULT_UPSTREAM_BRANCHES $UPSTREAM_BRANCHES; do
|
||||
UPSTREAM_COMMIT=`git rev-parse "$u"`
|
||||
|
||||
Reference in New Issue
Block a user