mirror of
https://gitlab.torproject.org/tpo/core/tor.git
synced 2024-12-06 19:41:15 +01:00
Fix compile error against miniupnpc-1.6 when --enable-upnp
The bump from miniupnpc-1.5 to 1.6 changes the definition of two functions used by tor-fw-helper-upnp.c, upnpDiscover() and UPNP_AddPortMapping(). This patch addresses this and adds a check in configure.in for backwards compatibility. Thanks to Nickolay Kolchin-Semyonov for some hints. X-Tor-Bug-URL: https://trac.torproject.org/projects/tor/ticket/5434 X-Gentoo-Bug-URL: https://bugs.gentoo.org/show_bug.cgi?id=376621 Signed-off-by: Anthony G. Basile <blueness@gentoo.org>
This commit is contained in:
committed by
Nick Mathewson
parent
bdd7e2878b
commit
cffc85bb0b
@@ -78,7 +78,11 @@ tor_upnp_init(tor_fw_options_t *options, void *backend_state)
|
||||
memset(&(state->data), 0, sizeof(struct IGDdatas));
|
||||
state->init = 0;
|
||||
|
||||
#ifdef MINIUPNPC15
|
||||
devlist = upnpDiscover(UPNP_DISCOVER_TIMEOUT, NULL, NULL, 0);
|
||||
#else
|
||||
devlist = upnpDiscover(UPNP_DISCOVER_TIMEOUT, NULL, NULL, 0, 0, NULL);
|
||||
#endif
|
||||
if (NULL == devlist) {
|
||||
fprintf(stderr, "E: upnpDiscover returned: NULL\n");
|
||||
return UPNP_ERR_NODEVICESFOUND;
|
||||
@@ -178,7 +182,11 @@ tor_upnp_add_tcp_mapping(tor_fw_options_t *options, void *backend_state)
|
||||
r = UPNP_AddPortMapping(state->urls.controlURL,
|
||||
state->data.first.servicetype,
|
||||
external_port_str, internal_port_str,
|
||||
#ifdef MINIUPNPC15
|
||||
state->lanaddr, UPNP_DESC, "TCP", 0);
|
||||
#else
|
||||
state->lanaddr, UPNP_DESC, "TCP", 0, 0);
|
||||
#endif
|
||||
if (r != UPNPCOMMAND_SUCCESS)
|
||||
return UPNP_ERR_ADDPORTMAPPING;
|
||||
|
||||
|
||||
Reference in New Issue
Block a user