torproject/tor
1
0
Fork 0
mirror of https://gitlab.torproject.org/tpo/core/tor.git synced 2024-12-06 19:41:15 +01:00
Code Issues Actions Packages Projects Releases Wiki Activity

r16279@catbus: nickm | 2007-10-30 11:14:29 -0400

Browse Source 
Improved skew reporting:  "You are 365 days in the duture" is more useful than "You are 525600 minutes in the future".  Also, when we get something that proves we are at least an hour in the past, tell the controller "CLOCK_SKEW MIN_SKEW=-3600" rather than just "CLOCK_SKEW"


svn:r12283
This commit is contained in:
Nick Mathewson
2007-10-30 15:17:07 +00:00
parent 7709fb7143
commit c0c2001a5b
7 changed files with 78 additions and 22 deletions
Download Patch File Download Diff File Expand all files Collapse all files
doc/TODO
+2 -2
View File
@@ -58,10 +58,10 @@ Things we'd like to do in 0.2.0.x:
- Revised handshake.
- Have a 'waiting_for_authentication' state.
- Only do version negotiation if we use the normalized TLS.
. Skew issues:
o Skew issues:
o if you load (nick says receive/set/anything) a consensus that's
in the future, then log about skew.
- should change the "skew complaint" to specify in largest units
o should change the "skew complaint" to specify in largest units
rather than just seconds.
- Learn new authority IPs from consensus/certs.
- karsten's patches
doc/spec/control-spec.txt
+8 -6
View File
@@ -1200,14 +1200,16 @@ $Id$
CLOCK_SKEW
SKEW="+" / "-" SECONDS
MIN_SKEW="+" / "-" SECONDS.
SOURCE="DIRSERV:IP:Port" / "NETWORKSTATUS:IP:PORT" / "CONSENSUS"
If "SKEW" is present, it's an estimate of how far we are from the
time declared in the source. If the source is a DIRSERV, we got
the current time from a connection to a dirserver. If the source is
a NETWORKSTATUS, we decided we're skewed because we got a v2
networkstatus from far in the future. If the source is
CONSENSUS, we decided we're skewed because we got a networkstatus
consensus from the future.
time declared in the source. (In other words, if we're an hour in
the past, the value is -3600.) "MIN_SKEW" is present, it's a lower
bound. If the source is a DIRSERV, we got the current time from a
connection to a dirserver. If the source is a NETWORKSTATUS, we
decided we're skewed because we got a v2 networkstatus from far in
the future. If the source is CONSENSUS, we decided we're skewed
because we got a networkstatus consensus from the future.
{Controllers may want to warn the user if the skew is high, or if
multiple skew messages appear at severity WARN. Controllers