torproject/tor
1
0
Fork 0
mirror of https://gitlab.torproject.org/tpo/core/tor.git synced 2024-12-06 19:41:15 +01:00
Code Issues Actions Packages Projects Releases Wiki Activity

Move "Didn't recognize cell, but circ stops here" into heartbeat.

Browse Source 
When we looked, this was the third most frequent message at
PROTOCOL_WARN, and doesn't actually tell us what to do about it.
Now:
 * we just log it at info
 * we log it only once per circuit
 * we report, in the heartbeat, how many times it happens, how many
   cells it happens with per circuit, and how long these circuits
   have been alive (on average).

Fixes the final part of #40400.
This commit is contained in:
Nick Mathewson
2021-10-19 15:16:49 -04:00
committed by Alexander Færøy
parent d455f9e18a
commit bcc953307b
6 changed files with 75 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files
changes/bug40400_part3
+7
View File
@@ -0,0 +1,7 @@
o Minor features (logging, heartbeat):
- When a relay receives a cell that isn't encrypted properly for
it, but the relay is the last hop on the circuit, the relay
now counts how many cells of this kind it receives, on how
many circuits, and reports this information in the log.
Previously, we'd log each cell at PROTOCOL_WARN level, which
is far too verbose to be useful. Fixes part of ticket 40400.